[SOLVED] This code is not functioning the way I expect it too.

[bobleny]

The idea of this segment of code is to display the links that are stored in the database. If there are no links in there, echo "No Links".

 

For some reason, it echos "No Links" regardless of whether or not there is links in the database. It will display the links, then it will display "No Links".

 

<?php


$sql = "SELECT * FROM `links` WHERE `page` = '" . $page . "'";
$query = mysql_query($sql);
if(!$query)
{
$_SESSION['error_message'] = mysql_error();
$_SESSION['error_location'] = "Page: " . $page . " - Line: " . __LINE__;
mysql_close();
sendem(error, .1);
die();
}

while($fetch = mysql_fetch_assoc($query))
{
echo "<div class='related_link'><a href='" . $fetch['href'] . "' class='related'>" . $fetch['name'] . "</a></div>";
}

if (!$fetch)
{
echo "<div class='text_lable'>No Links</div>";
}


?>

 

 

I'm not sure how to fix this. What do you think?

[per1os]

<?php


$sql = "SELECT * FROM `links` WHERE `page` = '" . $page . "'";
$query = mysql_query($sql);
if(!$query)
{
$_SESSION['error_message'] = mysql_error();
$_SESSION['error_location'] = "Page: " . $page . " - Line: " . __LINE__;
mysql_close();
sendem(error, .1);
die();
}

$links = false;
while($fetch = mysql_fetch_assoc($query))
{
echo "<div class='related_link'><a href='" . $fetch['href'] . "' class='related'>" . $fetch['name'] . "</a></div>";
        $links = true;
}

if (!$links)
{
echo "<div class='text_lable'>No Links</div>";
}


?>

 

Should take care of the problem.

[pocobueno1388]

Scratch what I just said...it won't work.

[bobleny]

pocobueno1388

 

Why not?

 

If there are no rows in the table, then there is logically no links in the table...

[pocobueno1388]

Because I was typing the code as if you had an IF statement...if you want I can add it in to work with your code, but I am sure Frost's code will work just fine, that is the reason I didn't bother re-doing it.

[bobleny]

pocobueno1388

 

Actually, I am using what you posted, and I do have it as an if statement.

 

Works fine.

 

I tried frost110 idea yesterday and it worked, but I didn't like it; It seems wrong.....

[pocobueno1388]

Oh, okay then...maybe I just looked at it wrong the first time, hah. Glad it worked for you =]

[per1os]

It's not wrong, just another way of doing things, this might work better for you (stealin poco's thunder)

 

<?php


$sql = "SELECT * FROM `links` WHERE `page` = '" . $page . "'";
$query = mysql_query($sql);
if(!$query)
{
$_SESSION['error_message'] = mysql_error();
$_SESSION['error_location'] = "Page: " . $page . " - Line: " . __LINE__;
mysql_close();
sendem(error, .1);
die();
}elseif (mysql_num_rows($query) > 0) {
     while($fetch = mysql_fetch_assoc($query)) {
        	echo "<div class='related_link'><a href='" . $fetch['href'] . "' class='related'>" . $fetch['name'] . "</a></div>";
     }
}else {
    echo "<div class='text_lable'>No Links</div>";
}
?>

 

In the programming world there is more than one way to skin a cat.