CONTACT FORM

[khujo56]

Hi guys

 

i created a contact form in html and a code in php to send the info to my e-mail account. the problem i have is that i want an error to show if nothing or some of the info is not filled in when i press the submit button. if i click the submit button with nothing filled out, it says the info has been sent to my e-mail account. can anyone look at my code and see what i'm doing wrong. below is the php code.

 

<?php

if(isset($_POST['submit'])) {

$to = "jnr1975@hotmail.com";

$subject = "Contact Info";

$name_field = $_POST['name'];

$email_field = $_POST['email'];

$message = $_POST['message'];

 

$errors = '';

 

if ( empty($name_field) ) $errors .= 'fill out name<br/>';

if ( empty($email_field) ) $errors .= 'fill out email<br/>';

if ( empty($message) ) $errors .= 'fill out message<br/>';

 

$body = "From: $name_field\n E-Mail: $email_field\n Message:\n $message";

 

 

if ( !empty($errors) ) {

echo $errors;

} else {

mail($to, $subject, $body);

echo "Data has been submitted to $to!";

}

?>

 

[teng84]

if(mail($to, $subject, $body)

{

echo "Data has been submitted to $to!";

}

else

{

echo 'failed';

}

 

and to verify if forms are filled up completely use the isset()

[khujo56]

sorry i should have said someone else wrote this script.

do i just add what you put

[teng84]

yes

[teng84]

<?php

if(isset($_POST['submit']))

{

$to = "jnr1975@hotmail.com";

$subject = "Contact Info";

$name_field = $_POST['name'];

$email_field = $_POST['email'];

$message = $_POST['message'];

 

$errors = '';

 

if (!isset($name_field))

{

$errors .= 'fill out name';

}

if (!isset($email_field))

{

$errors .= 'fill out email';

}

if (!isset($message))

{

$errors .= 'fill out message';

}

$body = "From: $name_field\n E-Mail: $email_field\n Message:\n $message";

 

 

if ( !empty($errors) )

{

echo $errors;

}

else

{

if(mail($to, $subject, $body)

{

echo "Data has been submitted to $to!";

}

}

}

?>

 

practice this way of coding

[soycharliente]

IMHO: Using empty() is fine. I do it all the time.

[teng84]

<?php

$var = 0;

 

// Evaluates to true because $var is empty

if (empty($var)) {

    echo '$var is either 0, empty, or not set at all';

}

 

// Evaluates as true because $var is set

if (isset($var)) {

    echo '$var is set even though it is empty';

}

?>

 

see the diff. any way it base on the needs

[soycharliente]

If someone typed 0, NULL, or "" for any input to a form I made, I'd want it to return that it was blank.

[khujo56]

Hi

 

i've tried the new script and when i put nothing in the form and click submit, all i get is a blank page. there is no message saying to fill in the form. any idea what's causing this

[teng84]

can we have the new code

[khujo56]

Hi Teng

 

Actually i got the code from your prior post.

here it is below.

here is the page where the form is on.

http://www.iheartvacation.com/index-4.html

 

here is the code

 

<?php

if(isset($_POST['submit']))

{

  $to = "jnr1975@hotmail.com";

  $subject = "Contact Info";

  $name_field = $_POST['name'];

  $email_field = $_POST['email'];

  $message = $_POST['message'];

 

  $errors = '';

 

  if (!isset($name_field))

  {

      $errors .= 'fill out name';

  }

  if (!isset($email_field))

  {

    $errors .= 'fill out email';

  }

  if (!isset($message))

  {

      $errors .= 'fill out message';

  }

  $body = "From: $name_field\n E-Mail: $email_field\n Message:\n $message";

 

 

  if ( !empty($errors) )

  {

      echo $errors;

  }

  else

  {

      if(mail($to, $subject, $body)

      {

        echo "Data has been submitted to $to!";

      }

  }

}

?>

[teng84]

  $to = "jnr1975@hotmail.com";

  $subject = "Contact Info";

  $name_field = $_POST['name'];

  $email_field = $_POST['email'];

  $message = $_POST['message'];

 

  $errors = '';

 

  if (!isset($name_field))

  {

      $errors .= 'fill out name';

  }

  if (!isset($email_field))

  {

    $errors .= 'fill out email';

  }

  if (!isset($message))

  {

      $errors .= 'fill out message';

  }

  $body = "From: $name_field\n E-Mail: $email_field\n Message:\n $message";

 

 

  if ( !empty($errors) )

  {

      echo $errors;

  }

  else

  {

      if(mail($to, $subject, $body))

      {

        echo "Data has been submitted to $to!";

      }

  }

try that first i remove the condition isset post coz that maybe coz the blank any way try that

and tell me what happen coz it works fine here

[khujo56]

yeah it' still does not work..it's odd

 

[teng84]

i see the site and its still blank mmm!!

 

try to echo something anywhere on that page and see if there will be an output

because that works fine on me

 

say echo 'test 101'; then check if that will appear i view the source of the site ant thats blank alco so try echoing something that will help you debug

[khujo56]

sorry i'm a php newbie..i'm not sure what u mean by that

[teng84]

put this anywhere on your mail.php

 

echo 'test 101';

 

thats the 1st step to debug

[khujo56]

ok i deleted the script and put echo 'test 101'; and clicked submit, it went to another page with test 101 on it

[teng84]

$to = "jnr1975@hotmail.com";

  $subject = "Contact Info";

  $name_field = $_POST['name'];

  $email_field = $_POST['email'];

  $message = $_POST['message'];

  $errors = '';

 

  if (!isset($name_field))

  {

      $errors .= 'fill out name';

  }

  if (!isset($email_field))

  {

    $errors .= 'fill out email';

  }

  if (!isset($message))

  {

      $errors .= 'fill out message';

  }

  $body = "From: $name_field\n E-Mail: $email_field\n Message:\n $message";

 

 

  if ( !empty($errors) )

  {

      echo $errors;

  }

  else

  {

      if(mail($email_field , $subject, $message))

      {

        echo "Data has been submitted to $to!";

      }

  }

 

that will work now ^^

 

if(mail($to, $subject, $body))// you dont change this  $to, $subject, $body this variable are not set

 

 

 

[teng84]

i know y you dont get the message

 

$to = "jnr1975@hotmail.com";

  $subject = "Contact Info";

  $name_field = $_POST['name'];

  $email_field = $_POST['email'];

  $message = $_POST['message'];

  $errors = '';

 

  if (!isset($name_field))

  {

      $errors .= 'fill out name';

  }

  if (!isset($email_field))

  {

    $errors .= 'fill out email';

  }

  if (!isset($message))

  {

      $errors .= 'fill out message';

  }

  $body = "From: $name_field\n E-Mail: $email_field\n Message:\n $message";

 

 

  if ($errors!='')

  {

      echo $errors;

  }

  else

  {

      if(mail($email_field , $subject, $message))

      {

        echo "Data has been submitted to $to!";

      }

  }

 

just paste that

 

 

[khujo56]

hey, yeah

 

i've tried the new code, still gettting the white page when i click submit. so odd why it does that.

could it be the form itself that's messing up..everything looks ok on the form.

[khujo56]

can anyone please help me with this..it's so close to working but something is not functioning properly

[scarhand]

Try this:

 

if(isset($_POST['submit']))

{

if ( empty($_POST['name']) )

{

exit("You must fill in your name!");

}

if ( empty($_POST['email']) )

{

exit("You must fill in your email address!");

}

if ( empty($_POST['message']) )

{

exit("You must write a message to send!");

}

}

 

Or, if you want the form to appear under the error message than echo it, like so:

 

if(isset($_POST['submit']))

{

    if ( empty($_POST['name']) )

    {

        echo 'You must fill in your name!';

    }

    if ( empty($_POST['email']) )

    {

        echo 'You must fill in your email address!';

    }

    if ( empty($_POST['message']) )

    {

        echo 'You must write a message to send!';

    }

}

 

 

You can use echo or exit, whichever you prefer.

 

I am a PHP newbie too, but if you're unsure how to use echo or exit look it up on PHP.net

[khujo56]

thanks that helped. is there a way you can write a message that is has been posted, then have it re-directed to another page..like back to the main page ?

[scarhand]

thanks that helped. is there a way you can write a message that is has been posted, then have it re-directed to another page..like back to the main page ?

 

You would have to simply echo the variable you stated for the posted message in order to display it.

 

example:

 

echo $message;

 

Redirection to another page can be done using header.

 

example:

 

header('Location: http://www.placeiwanttoredirectto.com/');

 

this must be placed before the <html> tag in order to work properly though.

[xyn]

Try this.

<?php
if(isset($_POST['name']) && empty($_POST['name']))
{
     $error[] = "Post your name";
}
if(isset($_POST['email']) && empty($_POST['email']))
{
     $error[] = "Post your name";
}
if(isset($_POST['message']) && empty($_POST['message']))
{
     $error[] = "Post your name";
}
if(is_array($error))
{
    echo("errors:<br>");
    foreach($error as $x => $i)
    {
        echo("- ".$i."<br>");
    }
}
else
{
     // submit mail stuff here!
}
?>