Please help me find mistake in this scropt

[jck]

$r2 = mysql_query("select RateSum,RateCount from dd_items where ItemID = '$_POST[itemID]'");
$rows = mysql_fetch_array($result);
$rc = $rows['RateCount'];
$rs = $rows['RateSum'];
$rc = $rc + 1;
$rs = $rs + '$_POST[rr]';
$nrate = $rs/$rc;
UPDATE dd_items SET RateSum = '$rs' ,RateCount = '$rc' , Rating = '$nrate' WHERE = ItemID '$_POST[itemID]';

[pocobueno1388]

It would help if we knew what the problem was.

[pocobueno1388]

From what I could see, I fixed the problems:

 

<?php

$r2 = mysql_query("select RateSum,RateCount from dd_items where ItemID '{$_POST['ItemID']}'");
$rows = mysql_fetch_array($result);

$rc = $rows['RateCount'];
$rs = $rows['RateSum'];
$rc = $rc + 1;
$rs = $rs + $_POST['rr'];
$nrate = $rs/$rc;

$query = "UPDATE dd_items SET RateSum = '$rs' ,RateCount = '$rc' , Rating = '$nrate' WHERE ItemID '{$_POST['ItemID']}'";
$result = mysql_query($query)or die(mysql_error());

?>

[Oldiesmann]

Either change $r2 to $result or change mysql_fetch_array($result) to mysql_fetch_array($r2).

[jck]

oops 

 

my old system of rating was to store all votes in 1 table with itemid, username and rating i wanted to make it like this for some reasons.....

now i have a huge problem there are already 60 jokes and many votes stored in the old method any way to transfer them directly of should i feed manually ???

[jck]

i guess i can write a while loop and run it once..... but the problem in that is some ItemID's in the jokes database dont exist

[xyn]

try this?

$sql = mysql_query("select RateSum,RateCount from dd_items where ItemID = '".$_POST[itemID]."'");
while($r = mysql_fetch_array($sql))
{
$rc = $r['RateCount'];
$rs = $r['RateSum'];
$rc2 = $rc + 1;
$rs2 = $rs + $_POST[rr];
$nrate = $rs2/$rc2;
}
mysql_query("UPDATE dd_items SET RateSum = '$rs' , RateCount = '$rc' , Rating = '$nrate' WHERE ItemID = '".$_POST[itemID]."'");

[jck]

thanks for the reply xyn but that had already been solved please read the further ones to see the new problem

[xyn]

Lol i did, but it must have sent that one instead.

 

I'd advise doing 2 fields in your jokes table called "timesvoted" and "rating"

set rating as "0.0" by default. then just add the number of votes...

[jck]

im planning to use rate sum if two jokes have same rate avg.....

but how do i transfer from old table......