[SOLVED] Aner Update problem

[almightyegg]

$ip = $_SERVER["REMOTE_ADDR"];
$time = date("d-m-Y H:i:s");
$memberid = $mem[id];
$update = mysql_query("UPDATE users SET lastlogin = '$time' and ip = '$ip' WHERE id = '$memberid'") or die(mysql_error());

 

The problem is that it doesn't update lastlogin (and perhaps IP - I'm still on the same one as before) correctly. It updates as 1 every time, so it just puts 1 into the database ;( it's really bugging me because I can't think why??

[Barand]

if lastlogin is a DATETIME field, use 'Y-m-d H:i:s'.

 

In fact, even it is varchar use that format anyway. d-m-Y is useless as a db date.

 

You could just ... SET lastlogin = NOW()

[almightyegg]

I changed the format, yet it is still inputting it as 1 ???

[Barand]

What column type is lastlogin?

[Barand]

Aha!

 

$update = mysql_query("UPDATE users SET lastlogin = '$time' and ip = '$ip' WHERE id = '$memberid'") or die(mysql_error());

 

Change the "and" to a comma, it's treating the whols expression as a boolean: lastlogin = ($time && ip=$ip)

 

.... SET lastlogin = '$time' , ip = '$ip' ....

[almightyegg]

Ah great thanks