eddy556 Posted August 15, 2007 Share Posted August 15, 2007 Hi, I'm writing a PHP application which deals with mp3 files and uses a bit of javascript. However I cannot get PHP to output this following line correctly without errors: <a href="embed.php?mp3=<?php echo $filename ?>" onClick="return popup(this, 'notes')"><img src="stream.gif" alt="Stream this song" width="14" height="14" border="0"></a> At the moment I close PHP ?> put this line in and open PHP again <?PHP Please can you post a PHP line to output the above? Thanks :-) Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/ Share on other sites More sharing options...
pranav_kavi Posted August 15, 2007 Share Posted August 15, 2007 what is the error ur getting?? Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324532 Share on other sites More sharing options...
eddy556 Posted August 15, 2007 Author Share Posted August 15, 2007 Expected ; or , somewhere in the line Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324533 Share on other sites More sharing options...
MadTechie Posted August 15, 2007 Share Posted August 15, 2007 try echo "<a href='embed.php?mp3='$filename' onClick='return popup(this, \"notes\")'><img src='stream.gif' alt='Stream this song' width='14' height='14' border='0'></a>"; Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324534 Share on other sites More sharing options...
eddy556 Posted August 15, 2007 Author Share Posted August 15, 2007 Okay that gets rid of the errors however '$filename' is not returning and is being left blank so I end up with an URL like embed.php?mp3= for the link Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324559 Share on other sites More sharing options...
Orio Posted August 15, 2007 Share Posted August 15, 2007 That's probably because $filename is not being defined or not being defined well. Some more code would help in this case. Orio. Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324575 Share on other sites More sharing options...
eddy556 Posted August 15, 2007 Author Share Posted August 15, 2007 OKay wel when I had the code: <a href="embed.php?mp3=<?php echo $filename ?>" onClick="return popup(this, 'notes')"><img src="stream.gif" alt="Stream this song" width="14" height="14" border="0"> $filename works and I also call it from other places and that works fine so I can deduce that $filename works correctly and is populated with the right data. What other code are you wanting? The whole script is 71 lines. Should I post the lot? Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324579 Share on other sites More sharing options...
chocopi Posted August 15, 2007 Share Posted August 15, 2007 try adding the ; after filename <a href="embed.php?mp3=<?php echo $filename; ?>" onClick="return popup(this, 'notes')"><img src="stream.gif" alt="Stream this song" width="14" height="14" border="0"> Hope that helps ~ Chocopi Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324585 Share on other sites More sharing options...
eddy556 Posted August 15, 2007 Author Share Posted August 15, 2007 Thank you that would help if I wanted the link to appear in HTML but I am wanting PHP to reproduce that. Thanks for pointing it out though I never noticed that Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324602 Share on other sites More sharing options...
eddy556 Posted August 15, 2007 Author Share Posted August 15, 2007 Just solved it...I'm dumb lol echo "<a href='embed.php?mp3='$filename' onClick='return popup(this, \"notes\")'><img src='stream.gif' alt='Stream this song' width='14' height='14' border='0'></a>"; I had an extra ' just before $filename when I needed to remove this as I had already opened a ' just before embed.php Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324620 Share on other sites More sharing options...
MadTechie Posted August 15, 2007 Share Posted August 15, 2007 heehee Link to comment https://forums.phpfreaks.com/topic/65033-solved-get-php-to-output-this-line/#findComment-324622 Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.