Is there a simpler way to this (below-mysql query) ?

[jd2007]

if i want to display each row from a table:

 

$que1="select MAX(id) from table";
$res1=mysql_query($que1);
$row1=mysql_fetch_row($res1);

for ($i=0; $i<=$row1[0]; $i++)
{
$que2="select cola from table where id='$i'";
$res2=mysql_query($que2);
$row2=mysql_fetch_row($res2);
echo $row2[0]."<br />";
}

 

what function to use or query to use to make the above simpler ?

[gurroa]

  $res = mysql_query("select cola from table");
  while($row = mysql_fetch_assoc($res)) {
     echo $row['cola']."<br />";
  }

[jd2007]

thanks...is it wrong to use the way i used ?

[tibberous]

It's slower the way you did it - guess you could say it's wrong.

[NArc0t1c]

It's slower the way you did it - guess you could say it's wrong.

 

Actually a clever way, most people would not have thought of it.

It's another method of doing it, it's not "Wrong".

[Orio]

It's not wrong, but its much more better querying the database only once compared to who knows how many times- better performance.

 

Orio.

[gurroa]

Actually a clever way, most people would not have thought of it.

It's another method of doing it, it's not "Wrong".

 

Disagree.

Imagine that you have three rows in such table

id    cola

85    boo

93    foo

132  boo2

 

Now you will query dbase 133times to read 3 rows with 129 error messages.

[NArc0t1c]

133 times?

 

And error messages could be avoidable(ever heard of the at(@) sign).

I just cannot think of any examples on how I could use that for an application that would be better than a while loop(maybe there isn't).

 

But it is "unique", and not wrong.

[jd2007]

is it ok to use my way ?

[NArc0t1c]

is it ok to use my way ?

 

For what you wanted to do, it's more efficiant to use a while loop.

[gurroa]

133 times?

First is the query for "select MAX(id)".

And the loop try to fetch 132 rows started from id = 1 to id = 132.

[mmarif4u]

Agree with gurroa .

The best option is to use while loop.

[NArc0t1c]

133 times?

First is the query for "select MAX(id)".

And the loop try to fetch 132 rows started from id = 1 to id = 132.

 

I'm not disagreeing that it will loop 133 times, I wanted to know why.

It starts counting at 0 not one, that's why it has 133 loops.

for ($i=0; $i<=$row1[0]; $i++)

 

Agree with gurroa .

The best option is to use while loop.

For what jd2007 wants it for, yes.

[jd2007]

thank you !