Re-populating text fields for Image Upload?

[Solarpitch]

Hi Guys,

 

When a user submits a form on my page and there are errors, the page returns the errors and re-populates the correct fields - So the user doesnt have to complete them again. I using the below code to do that...

 

<input style="width:200px; "  name="userfile" type="file"  id="menu_textbox" value="<?print $file_path; ?>" />

 

However, for the file upload field above it doesnt seem to work and the user must select the file they wish to upload from there computer again. Should the code for this be a little different or is there something I am missing?

[simcoweb]

You can try this:

 

<input style="width:200px;" name="userfile" type="file" id="menu_textbox" value="<? if(isset($_POST['submit'])) echo $_POST['userfile']; ?>">

[plutomed]

I think if you use javascript:history.go(-1) ans your link back it does it automatically I think

[Solarpitch]

You can try this:

 

<input style="width:200px;" name="userfile" type="file" id="menu_textbox" value="<? if(isset($_POST['submit'])) echo $_POST['userfile']; ?>">

 

I tried this and it still doesnt seem to work. The userfile text field still clears when the form returns errors instead of holding the value that the user selected.

[simcoweb]

Well, then let me ask you a question. What is the name of your 'submit' button in your form code?

[Solarpitch]

I use a hidden field to submit the value of the form...

 

<input type="hidden" name="process" value="4">

<input type="submit" name="Submit" value="Submit Ad" onClick="return validate(this);">

[simcoweb]

Ok, you have this:

 

name="Submit"

 

but in my code I had:

 

name="submit"

 

with lower case S. Change it to uppercase and give it a try.

[Solarpitch]

Umm.. Still no joy. It must be something to do with the properties of the type="file" textfield. But there is a way, cant understand why it wont work.

[MadTechie]

can you post the page ?

in code tags (#)

[Solarpitch]

Not the page, its massive. Heres the important parts...

 

[b]// FILE CODE[/b]

function generate_rand($l){
$c= "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
srand((double)microtime()*1000000);
for($i=0; $i<$l; $i++)
{
$rand.= $c[rand()%strlen($c)];
}
return $rand;
}

$uploaddir = "user_images/";
$maxfilesize = 1048576; //1 megabyte
$filename = $_FILES['userfile']['name'];
$filesize = $_FILES['userfile']['size'];
$filetmpname = $_FILES['userfile']['tmp_name'];
$valid = array (".jpg",".gif",".png");

if ($filename) {
$error = "";
if ($filesize == 0) {
$error_file .= "The submitted file was invalid.<br />";

$execute = "no";
}
$type = strtolower(strstr($filename, '.'));
if (!in_array($type, $valid)) {
$error_file .= "The submitted file was of invalid type.<br />";

$execute = "no";
}
if ($filesize>$maxfilesize) {
$error_file .= "The submitted file was larger than a Megabyte.<br />";

$execute = "no";
}
$randnum = generate_rand(10);
$randnum .= $type;
$file_exists = true;
while ($file_exists) {
if (file_exists("$uploaddir$randnum")) {
$randnum = generate_rand(10);
$randnum .= $type;
}else{
$file_exists = false;
}
}
if ($error_file == "") {
if (move_uploaded_file($filetmpname, "$uploaddir$randnum")) {
chmod("$uploaddir$randnum", 0644);
$file_complete = "";
} 
else {
$file_complete = "Your file could not be uploaded.";

$execute = "no";
}
}else{
echo "";
}
}else{
echo "";
}


[b]// EXECUTE FORM CODE[/b]

if (($_POST['process'] == 4) & ($execute != "no"))
{
..... do insertion to database stuff
}


[b]// HTML FORM PART[/b]

<form name="myform" method="post" action="upload_ad.php">

...

<input  type="hidden" name="MAX_FILE_SIZE" value="1048576)">
<input style="width:200px; "  name="userfile" type="file"  id="menu_textbox" value="<? if(isset($_POST['process'])) 
{
echo $_POST['userfile']; 
}
?>" />

[MadTechie]

Erm your trying to set a form file element.. thats which is always readonly so can't be done as its a security risk..

 

[Solarpitch]

Ah I see what you mean! Is there anyway around this. User's wont be aware that they will need to select the file again once there was an error on the form, not best practice obviously.

[MadTechie]

theirs aworkaround but due to the security risks most have been coved as their classed as exploits and as any that may know, i couldn't say as they are a major secuirty risk.

 

think about it your viewing a page and any file on your HDD could be taken without you knowing.. this is why its read only

[Solarpitch]

I see, I'll think of something. Just wonder how other sites implement this

 

[MadTechie]

implement what exaclty (got an example?)