spdwrench Posted September 8, 2007 Share Posted September 8, 2007 this code loads 10 members thumbnails to be displayed on the home page.... I did not write the original code but I modified it... it seems to take a while to comeback with the results... is there a way to optimize this code.... is something written Poorly??? thanks for any help or comments $personnum = 0; while($tnct<11) { $search_query = "SELECT p.id, p.gender, f.filename_1 FROM (dt_profile p, dt_photos f, dt_members m, dt_privacy pr) WHERE (p.status='1' AND (pr.featured_yn IS NULL OR pr.featured_yn='') AND pr.member_id=m.id AND p.member_id=m.id AND f.member_id=m.id AND f.filename_1<>'' AND p.gender='$genders[name]') "; $search_query .= "ORDER BY RAND()"; $search_query .= " LIMIT 1"; $person[$personnum] = f(q($search_query)); $personnum++; $tnct++; if ($genders[name]=="male"){$genders[name]="female";}else{$genders[name]="male";} } $curr = 0; while($curr < $personnum) { if($person[$curr][id] != "") { $current_profile_id = $person[$curr][id]; if($person[$curr][filename_1] != "") $profile_image = sysGetThumbnail("photos/{$person[$curr][filename_1]}"); else $profile_image = '<img src="images/default_photo.gif" width="100" height="100" border="0">'; $top_thumbs .= parseVariables("templates/mainthumbs.html",0); } $curr++; } Quote Link to comment https://forums.phpfreaks.com/topic/68434-can-i-improve-this-code-is-slow-running/ Share on other sites More sharing options...
cooldude832 Posted September 8, 2007 Share Posted September 8, 2007 just off the top I see you are running the same query 10 times. Why, instead query once getting 10 results and then store them for later use or use them right through a while($row = mysql_fetch_array($result)) Quote Link to comment https://forums.phpfreaks.com/topic/68434-can-i-improve-this-code-is-slow-running/#findComment-344077 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.