Jump to content

Can I improve this code? is slow running


spdwrench

Recommended Posts

this code loads 10 members thumbnails to be displayed on the home page.... I did not write the original code but I modified it...

 

it seems to take a while to comeback with the results...

 

is there a way to optimize this code.... is something written Poorly??? thanks for any help or comments

 

$personnum = 0;
while($tnct<11)
{
	$search_query = "SELECT p.id, p.gender, f.filename_1 FROM (dt_profile p, dt_photos f, dt_members m, dt_privacy pr) WHERE (p.status='1' AND (pr.featured_yn IS NULL OR pr.featured_yn='') AND pr.member_id=m.id AND p.member_id=m.id AND f.member_id=m.id AND f.filename_1<>'' AND p.gender='$genders[name]') ";

			$search_query .= "ORDER BY RAND()";
	        $search_query .= " LIMIT 1";

	$person[$personnum] = f(q($search_query));

	$personnum++;
	$tnct++;
	if ($genders[name]=="male"){$genders[name]="female";}else{$genders[name]="male";}
}

$curr = 0;

    while($curr < $personnum)
{
    if($person[$curr][id] != "")
    {
    	$current_profile_id = $person[$curr][id];
    		
         if($person[$curr][filename_1] != "") 
         	$profile_image = sysGetThumbnail("photos/{$person[$curr][filename_1]}");
		else 
			$profile_image = '<img src="images/default_photo.gif" width="100" height="100" border="0">';
   
		$top_thumbs .= parseVariables("templates/mainthumbs.html",0);
    }
    $curr++;
}

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.