Jump to content

Recommended Posts

<?php
$seed = "http://www.site.com/page.html";
$data = file_get_contents($seed);
if (preg_match_all(/http:[^"\s']+/", $data, $links)) 
{
     for ($i=0;$i<count($links[0]);$i++)  // I think the problem is here?
     {

$data_b = file_get_contents('http://www.site.com/sub/'. $links[0][$i]);

if (preg_match_all(/http:[^"\s']+/", $data_b, $links_b)) 
{

@header("Content-type: text/plain");

     for ($i_b=0;$i_b<count($links_b[0]);$i_b++) 
     
     {
     
     echo $links_b[0][$i_b]. "\n";
     
     }
}
}
}

?>

 

The above works great EXCEPT that if there are two of the same links on the first page, it spiders them twice, which is using up double the resources. How can I get it to only use one of the two links?

Link to comment
https://forums.phpfreaks.com/topic/71856-solved-only-using-unique-values-in-for/
Share on other sites

Add each link you check into an array, call this array $checked_urls. Then every time you go to parse a url check whether that url has been parsed already using is_array. If its in the array skip to next url, else parse url.

Abit like this:

<?php

$seed = "http://www.site.com/page.html";
$data = file_get_contents($seed);

$checked_links = array();

if (preg_match_all("/http:[^\"\s']+/", $data, $links))
{
    foreach($links[0] as $key => $link)
    {
        // check that the link has not been parsed already
        if(!in_array($link, $checked_links))
        {
            // link has not been parsed we'll add it to the checked links array
            $checked_links[] = $link;

            $data_b = file_get_contents('http://www.site.com/sub/'. $link);

            if (preg_match_all("/http:[^\"\s']+/", $data_b, $links_b))
            {
                @header("Content-type: text/plain");

                foreach($links_b[0] as $skey => $sub_link)
                {
                    // check that the sublink has not been parsed already
                    if(!in_array($sub_link, $checked_links))
                    {
                        // sublink has not been parsed we'll add it to the checked links array
                        $checked_links[] = $sub_link;

                        echo $sub_link . "\n";
                    }
                }
            }
        }
    }
}

?>

Notice: I changed your for loops to foreach loops. foreach loops are much easier to loop through arrays.

 

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.