[SOLVED] Need PHP code checked

[$username]

Hello Guys,

  I am having issues with this drop down box look up from MYSQL.

Here is the error

 

Notice: Undefined variable: row in c:\web\www\app\addmember.php on line 58

 

Notice: Undefined variable: row in c:\web\www\app\addmember.php on line 59

 

these are the lines it errors out on

    while ($row = mysql_fetch_assoc($result)) {

        echo \"<option value=\"{$row['UserType']}</option>\";

 

 

<?PHP
$sql = \"SELECT UserType FROM values \";
  if ($result = mysql_query($sql)) {
    if (mysql_num_rows($result)) {
      while ($row = mysql_fetch_assoc($result)) {
        echo \"<option value=\"{$row['UserType']}</option>\";
      }
    }
  }
?>  

 

Thanks,

Brett

[darkfreaks]

you need to define $row as $row=mysql_num_rows($result);

[$username]

Can you be more specific on where I would add    $row=mysql_num_rows($result);

 

This would be over written by this line of code

 

while ($row = mysql_fetch_assoc($result)) {

 

Thank you,

Brett

[darkfreaks]

that line of code needs to be also defined before the while statement or it will error undefined row

[darkfreaks]

you need

 

<?php
$row=mysql_num_rows($result);
while ($row = mysql_num_rows($result,MYSQL_ASSOC)){ ?>

 

 

[darkfreaks]

<?php
$row=mysql_fetch_array($result,MYSQL_ASSOC);
while ($row = mysql_fetch_array($result,MYSQL_ASSOC)){ ?>

my bad

[emehrkay]

also this is incorrect, unnecessary backslashes and it is incomplete html

 

echo \"<option value=\"{$row['UserType']}</option>\";

 

I prefer concatenation, like this

 

echo "<option value=\"". $row['UserType'] ."\">". $row['UserType'] ."</option>";

 

[$username]

I re-did the why I am using PHP and HTML. So it works for now.

 

Thank you,

Brett