[SOLVED] error in syntax help

[samoht]

hello,

 

I am receiving this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Kingston,Flintwood,PA,19082,213-209-9908,'A',date('YmdHis'),date('YmdHis'))' at line 2

 

When filling out a form. Here is the function that inserts the form info into my table

 

<?php
		// save ship address
			$sql = "INSERT INTO clientaddresses(Name, Address1, City, State, Zip, Phone, FlagStatus, DateStatus, DateCreated)
					VALUES ($txtShippingLastName,$txtShippingAddress1,$txtShippingCity,$txtShippingState,$txtShippingPostalCode,$txtShippingPhone,'A',date('YmdHis'),date('YmdHis'))";
			$result = dbQuery($sql);					

			$_SESSION['ShipAddressId'] = $ShipAddressId = dbInsertId();

 

Any Ideas what's wrong with my insert??

 

Thanks

[MadTechie]

lack of quotes

$sql = "INSERT INTO clientaddresses(Name, Address1, City, State, Zip, Phone, FlagStatus, DateStatus, DateCreated)
					VALUES ('$txtShippingLastName','$txtShippingAddress1','$txtShippingCity','$txtShippingState','$txtShippingPostalCode','$txtShippingPhone','A',date('YmdHis'),date('YmdHis'))";

 

also check the date field

[samoht]

thanks, I changed the dates to NOW()

 

seems to work, but I need help with a concat,

 

Is this right?

VALUES(CONCAT('$txtShippingFirstName','','$txtShippingLastName'),etc

 

 

[MadTechie]

on an INSERT.. don't use CONCAT (theirs no need) use this (same as echo'ing)

VALUES('$txtShippingFirstName $txtShippingLastName'),etc

or even

$FullName = "$first $surname";

VALUES('$FullName '),etc