[SOLVED] little help with this user online code

[irkevin]

Hi everyone, someone mind tell me if there are some changes i need to make with this code?

 

<?php
include('config.php');
include('functions.php');
mysql_connect($server, $dbusername, $dbpassword);
mysql_select_db("$user_online");

$uname = $_SESSION['user_name'];
if (!$uname)
{ 
$guest = "1"; 
} 
else
{ 
$guest = "0"; 
}
$ip = $_SERVER['REMOTE_ADDR'];
$time = time();
$query = "SELECT * FROM user_online WHERE ip = '$ip'";
$result = mysql_query($query);
if (mysql_num_rows($result) == 1)
{
      $query2 = "UPDATE user_online SET uname='$uname',time='$time',guest='$guest' WHERE ip = '$ip'";
      $result2 = mysql_query($query2);
}
else
{
      $query2 = "INSERT INTO user_online (uname,ip,time,guest)VALUES('$uname', '$ip', '$time','$guest')";
      $result2 = mysql_query($query2);
}

$time3 = time() - 300;
$query3 = "DELETE FROM user_online WHERE time < $time3";
$result3 = mysql_query($query3);
$query4 = "SELECT * FROM user_online WHERE guest = '1'";
$result4 = mysql_query($query4);
$guestonline = mysql_num_rows($result4);
$query5 = "SELECT * FROM user_online WHERE guest = '0'";
$result5 = mysql_query($query5);
$memonline = mysql_num_rows($result5);
$totalonline = $guestonline + $memonline;
echo 
"Guests: $guestonline<br />
Members: $memonline<br />
Total: $totalonline<br /><br />";
?>

 

sometimes, it shows only one user online even if there are more than one user logged in in my site

 

[kratsg]

Why do you have this?

 

mysql_select_db("$user_online");

 

Isn't the database "user_online" and not a variable? That may be your problem. Remove the dollar sign.

[darkfreaks]

it still works its parsed in double quotes 

[irkevin]

yeps somehow the scripts is working even with the dollar sign but i removed it tho..

 

Thanks for this remark kratsg and thanks for helping me test the code darkfreaks

[darkfreaks]

np buddy

[irkevin]

Hi again with a little problem with this code, it actually shows the user who is online but it removes it after a short period of time even if the user is still logged in..

 

What should i modify in this code in order that it removes the user only when he logs out?

 

Can someone help me with this?

 

Thanks 

[darkfreaks]

try something like

<?php
if(!isset($_SESSION['loggedin'])) { $query3 = "DELETE FROM user_online";} ?>

[irkevin]

yeps i think it's a good idea..

 

so i got rid of the time()- 300 and added this part

 

if(!isset($_SESSION['loggedin'])) {
$query3 = "DELETE FROM user_online WHERE guest = '0'";
} 

 

and now we'll see the results thnx darkfreaks

[darkfreaks]

final code:

 

 

<?php
if(!isset($_SESSION['user_name'])) {
$query3 = "DELETE FROM user_online WHERE guest = '0'";
} ?>

[irkevin]

yeps and it works..

 

thanks for ur time

[darkfreaks]

no problem

[irkevin]

Sorry to bug you with this again

 

for the logged users, the code works but supposed a guest is looking at the website, basically it will add him as a guest but how do I removed the guest from the database once he close the browser and dont watch the website again.. Is there a way i can do that?

 

Thanks for all your help btw

[darkfreaks]

<?php
function session_restart()
{
    if (session_name()=='') {
        // Session not started yet
        session_start();
    }
    else {
        // Session was started, so destroy
        session_destroy();



?>

[darkfreaks]

<?php
function session_restart()
{
    if (session_name()=='') {
        // Session not started yet
        session_start();
    }
    else {
        // Session was started, so destroy
        session_destroy();
}
}
if($_SESSION['user_name']=="guest"||"javascript:window.close()") 
{ $query="DELETE*FROM user_name WHERE guest=0";
session_restart($_SESSION['user_name']);}



?>

[irkevin]

coool but how do i insert this into the actual code  ??? i've never used functions before