help with php function

[mast3rpyr0]

hi, i have this function to switch between two different strings for each variable it uses so that it creates a properly formatted table (ya i know who uses tables...). the function is called but it doesnt change anything, is there somethign wrong?

 

<?php
$start = '<tr><td>';
$end = '</td>';
function doSwitch($a, $b)
{
  if ($a == '<tr><td>')
    $start = '<td>';
  else if ($a == '<td>')
    $start = '<tr><td>';
  
  if ($b == '</td>')
    $end = '</td></tr>';
  else if ($b == '</td>')
    $end = '</td>';
}
if(!isset($_GET['img']))
{
$folder=dir("imgpath/."); 
$path = "imgpath";

echo '<table border="1">';

while($folderEntry=$folder->read()){ 
  if ($folderEntry !="." & $folderEntry !=".." & $folderEntry !="folder.php" & $folderEntry !="Thumbs.db")
  {
    echo $start;
    echo '<a href="?p=gallery&img=' . $folderEntry . '">';
    echo '<img src="' . $path . $folderEntry . '" alt="image" />';
    echo $end;
    doSwitch($start, $end);
} 
}
if($end == '</td>')
echo '</table>';
else
echo '</tr></table>';
$folder->close(); 
}
else{
echo 'You have selected image ' . $_GET['img'];
}
?>

 

 

thanks

[MadTechie]

try using pointers

 

doSwitch(&$start, &$end);

[mast3rpyr0]

no that still didnt seem to do it. i set it up to work with a few images and they should have 2 to a row and then go down.

 

http://pyroaudio.cpcdesigns.com/files/public_html/

[MadTechie]

untested, but should work

 

<?php
$start = '<tr><td>';
$end = '</td>';
if(!isset($_GET['img']))
{
$folder=dir("imgpath/."); 
$path = "imgpath";

echo '<table border="1">';

while($folderEntry=$folder->read())
{ 
	if ($folderEntry !="." & $folderEntry !=".." & $folderEntry !="folder.php" & $folderEntry !="Thumbs.db")
	{
		echo $start;
		echo '<a href="?p=gallery&img=' . $folderEntry . '">';
		echo '<img src="' . $path . $folderEntry . '" alt="image" />';
		echo $end;
		list($start, $end) = doSwitch($start, $end);
	} 
}
if($end == '</td>')
{
	echo '</table>';
}else{
	echo '</tr></table>';
}
	$folder->close(); 
}else{
echo 'You have selected image ' . $_GET['img'];
}


function doSwitchA($a, $b)
{
if($a == '<tr><td>')
{
	$start = '<td>';
}elseif($a == '<td>'){
    	$start = '<tr><td>';
}

if($b == '</td>')
{
    	$end = '</td></tr>';
}elseif ($b == '</td>'){
	$end = '</td>';
}
return array($start, $end);
}
?>