header("Location: members.php"); error

[jsucupira]

this code is working good for post and retrieving information from db, but it won't direct the user to the next page once they log in. could anyone tell me the problem? thnx

 

 

 

 

<?php
$hotname = 'p50mysql53.secureserver.net';
$database='';
$username='';
$pass='';
//Connect to db
mysql_connect($hostname, $username,$pass) or die (mysql_error());
mysql_select_db($database) or die (mysql_error());
//Check for cookie
if(isset($_COOKIE['ID_my_site']))
//if there is, it logs you in and directes you to the members page
{
$username = $_COOKIE['ID_my_site'];
$pass = $_COOKIE['Key_my_site'];
$check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());
while($info = mysql_fetch_array( $check ))
{
if ($pass != $info['password'])
{
}
else
{
header("Location: members.php");
}
}
}
//if the login form is submitted
if (isset($_POST['submit'])) {
// if form has been submitted
// makes sure they filled it in
if(!$_POST['username'] | !$_POST['pass']) {
die('You did not fill in a required field.');
}
// checks it against the database
if (!get_magic_quotes_gpc()) {
$_POST['email'] = addslashes($_POST['email']);
}
$check = mysql_query("SELECT * FROM users WHERE username = '".$_POST['username']."'")or die(mysql_error());
//Gives error if user dosen't exist
$check2 = mysql_num_rows($check);
if ($check2 == 0) {
die('That user does not exist in our database.<a href=registration.php>Click Here to Register</a>');
}
while($info = mysql_fetch_array( $check ))
{
$_POST['pass'] = stripslashes($_POST['pass']);
$info['password'] =stripslashes($info['password']);
$_POST['pass'] = md5($_POST['pass']);
//gives error if the password is wrong
if ($_POST['pass'] != $info['password']) {
die('Incorrect password, please try again.');
}
else
{
// if login is ok then we add a cookie
$_POST['username'] = stripslashes($_POST['username']);
$hour = time() + 3600;
setcookie(ID_my_site, $_POST['username'], $hour);
setcookie(Key_my_site, $_POST['pass'], $hour);
//then redirect them to the members area
header("Location: members.php");
}
}
}
else
{
// if they are not logged in
?>
<form action="<?php echo $_SERVER['PHP_SELF']?>" method="post">
<table border="0">
<tr><td colspan=2><h1>Login</h1></td></tr>
<tr><td>Username:</td><td>
<input type="text" name="username" maxlength="40">
</td></tr>
<tr><td>Password:</td><td>
<input type="password" name="pass" maxlength="50">
</td></tr>
<tr><td colspan="2" align="right">
<input type="submit" name="submit" value="Login">
</td></tr>
</table>
</form>
<?php
}
?>

[revraz]

If you're getting a Header Error

 

http://www.phpfreaks.com/forums/index.php/topic,37442.0.html

[murali]

be sure that should not display/echo some data before using the header("Location:page.php"); statement.

 

 

If there is any browser output before header function ;

we will get error like output started....

 

 

[lewis987]

the first error i caught on was:

 

$hotname = 'p50mysql53.secureserver.net';

 

and u call "$hostname" with the mysql_connect function

 

another thing: It checks whether the script can get a cookie or not... could be one problem (use sessions instead for debugging)

 

change:

if(isset($_COOKIE['ID_my_site']))

 

to:

 

if($_COOKIE['ID_my_site'] != "")

 

change:

 

$check = mysql_query("SELECT * FROM users WHERE username = '$username'")or die(mysql_error());
while($info = mysql_fetch_array( $check ))
{
if ($pass != $info['password'])
{
}
else
{
header("Location: members.php");
}
}
}

 

to:

 

$check = mysql_query("SELECT * FROM users WHERE username = '$username'");
if($check){
while($info = mysql_fetch_array( $check ))
{
if ($pass != $info['password'])
{
}
else
{
header("Location: members.php");
}
}
}else{
die(mysql_error());
}

 

the code isnt tested so... no promises