Most Likely A Simple Fix...

[streetkid]

Hey everyone, I'm a newbie (really new) just starting out with using PHP and MySQL.  I'm having a weird problem with a simple guestbook I'm trying to create.  I get an error in the file viewguestbook.php, it comes up as Parse error: syntax error, unexpected $end in C:\wamp\www\sampleGuestbook\viewguestbook.php on line 61.  Line 61 is at the very bottom of the viewguestbook.php file, I'm not sure how to properly end it, or really whats causing the unexpected ending. I'm sure this is a simple fix, I just don't have much of a background with this stuff yet and do not know how to get it working.  Will you guys help a annoying newbie coder geek girl out?  .

 

I'm not sure whats really causing it so I'm going to post all of the code I have so far:

 

Here is the code I input into my database, after creating a database named "guestbook" (using MySQL):

DROP DATABASE IF EXISTS guestbook;
CREATE DATABASE guestbook;
USE guestbook;

CREATE TABLE `guestbook` (
`id` int(4) NOT NULL auto_increment,
`name` varchar(65) NOT NULL default '',
`email` varchar(65) NOT NULL default '',
`comment` longtext NOT NULL,
`datetime` varchar(65) NOT NULL default '',
PRIMARY KEY (`id`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1 AUTO_INCREMENT=1 ;

 

Here is the code in viewguestbook.php (the problem file):

<table width="400" border="0" align="center" cellpadding="3" cellspacing="0">
<tr>
<td><strong>View Guestbook | <a href="guestbook.php">Sign Guestbook</a> </strong></td>
</tr>
</table>
<br>

<?php

$host="localhost"; // Host name 
$username="root"; // Mysql username 
$password=""; // Mysql password 
$db_name="test"; // Database name 
$tbl_name="guestbook"; // Table name 

// Connect to server and select database.
mysql_connect("$host", "$username", "$password")or die("cannot connect server "); 
mysql_select_db("$db_name")or die("cannot select DB");

$sql="SELECT * FROM $tbl_name";
$result=mysql_query($sql);

while($rows=mysql_fetch_array($result)){
?>
<table width="400" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<td><table width="400" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td>ID</td>
<td>:</td>
<td><? echo $rows['id']; ?></td>
</tr>
<tr>
<td width="117">Name</td>
<td width="14">:</td>
<td width="357"><? echo $rows['name']; ?></td>
</tr>
<tr>
<td>Email</td>
<td>:</td>
<td><? echo $rows['email']; ?></td>
</tr>
<tr>
<td valign="top">Comment</td>
<td valign="top">:</td>
<td><? echo $rows['comment']; ?></td>
</tr>
<tr>
<td valign="top">Date/Time </td>
<td valign="top">:</td>
<td><? echo $rows['datetime']; ?></td>
</tr>
</table></td>
</tr>
</table>
<BR>
<?
}
mysql_close(); //close database
?>

 

Here is the code in guestbook.php:

<?php
?>
<table width="400" border="0" align="center" cellpadding="3" cellspacing="0">
<tr>
<td><strong>Sign Guestbook </strong></td>
</tr>
</table>
<table width="400" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<form id="form1" name="form1" method="post" action="addguestbook.php">
<td>
<table width="400" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td width="117">Name</td>
<td width="14">:</td>
<td width="357"><input name="name" type="text" id="name" size="40" /></td>
</tr>
<tr>
<td>Email</td>
<td>:</td>
<td><input name="email" type="text" id="email" size="40" /></td>
</tr>
<tr>
<td valign="top">Comment</td>
<td valign="top">:</td>
<td><textarea name="comment" cols="40" rows="3" id="comment"></textarea></td>
</tr>
<tr>
<td> </td>
<td> </td>
<td><input type="submit" name="Submit" value="Submit" /> <input type="reset" name="Submit2" value="Reset" /></td>
</tr>
</table>
</td>
</form>
</tr>
</table>
<table width="400" border="0" align="center" cellpadding="3" cellspacing="0">
<tr>
<td><strong><a href="viewguestbook.php">View Guestbook</a> </strong></td>
</tr>
</table>

 

Here is the code in addguestbook.php:

<?php
$host="localhost"; // Host name 
$username="root"; // Mysql username 
$password=""; // Mysql password 
$db_name="test"; // Database name 
$tbl_name="guestbook"; // Table name 

// Connect to server and select database.
mysql_connect("$host", "$username", "$password")or die("cannot connect server "); 
mysql_select_db("$db_name")or die("cannot select DB");

$datetime=date("y-m-d h:i:s"); //date time

$sql="INSERT INTO $tbl_name(name, email, comment, datetime)VALUES('$name', '$email', '$comment', '$datetime')";
$result=mysql_query($sql);

//check if query successful 
if($result){
echo "Successful";
echo "<BR>";
echo "<a href='viewguestbook.php'>View guestbook</a>"; // link to view guestbook page 
}

else {
echo "ERROR";
}

mysql_close();
?>

 

 

[streetkid]

Sorry, I'm using Eclipse for all PHP code... if that helps

[PFMaBiSmAd]

There is a 99.9% chance that it is the short php opening tag <? being used near the end of the file with the error (all the other files are irrelevant, why did you post them?)

 

Always use full php opening tags <?php to make your code portable between any server configuration.

[streetkid]

Sorry about posting all the files, I didn't know where the error was and thought I'd just post everything I had so far. (newbie  ???)

 

Okay, I changed all of the tags to include php at the start.  The original error no longer is shown, but now a new error is output to the screen: Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\wamp\www\sampleGuestbook\viewguestbook.php on line 23.  Line 23 is the following code:

 

while($rows=mysql_fetch_array($result)){

 

Why is this not valid?

 

[PFMaBiSmAd]

Because your mysql_query() failed and returned a FALSE value instead of a result resource.