advancedfuture Posted December 3, 2007 Share Posted December 3, 2007 I wrote a simple registration form to signup new users.... It creates new users in the DB no problem, however it skips the IF statement and goes straight to the else statement for some reason... so its allowing people to register the same username over and over.... what am I doing wrong ? <? $username = $_POST['username']; $password = $_POST['password']; include 'dbConnect.php'; $query = "SELECT * FROM users WHERE username = '$username'"; $results = mysql_query($query); if($results > 0) { echo "Sorry Username is already taken"; } else { $insert = "INSERT INTO users (username, password) VALUES ('$username', '$password')"; mysql_query($insert); echo "Registration Successful"; } ?> Link to comment https://forums.phpfreaks.com/topic/79929-solved-problems-with-if-else-in-user-authentication/ Share on other sites More sharing options...
phpQuestioner Posted December 3, 2007 Share Posted December 3, 2007 try this and see if it work: <?php $username = $_POST['username']; $password = $_POST['password']; include 'dbConnect.php'; $query = "SELECT * FROM users WHERE username = '$username'"; $results = mysql_query($query); if($results == $username ) { echo "Sorry Username is already taken"; exit; } else { $insert = "INSERT INTO users (username, password) VALUES ('$username', '$password')"; mysql_query($insert); echo "Registration Successful"; } ?> Link to comment https://forums.phpfreaks.com/topic/79929-solved-problems-with-if-else-in-user-authentication/#findComment-404835 Share on other sites More sharing options...
advancedfuture Posted December 3, 2007 Author Share Posted December 3, 2007 Nope still just skips to "registration successful" and creates a duplicate entry in the database. Link to comment https://forums.phpfreaks.com/topic/79929-solved-problems-with-if-else-in-user-authentication/#findComment-404837 Share on other sites More sharing options...
Crew-Portal Posted December 3, 2007 Share Posted December 3, 2007 <?php $username = $_POST['username']; $password = $_POST['password']; include 'dbConnect.php'; $sql = "SELECT * FROM users WHERE username = '$username'"; $results = mysql_query($sql); $num=mysql_num_rows($results); if($num >0) { $error = $tblstart . 'Username Is Taken!' . $tblend; } else { $insert = "INSERT INTO users (username, password) VALUES ('$username', '$password')"; mysql_query($insert); echo "Registration Successful"; } // Hope that helps! ?> Link to comment https://forums.phpfreaks.com/topic/79929-solved-problems-with-if-else-in-user-authentication/#findComment-404842 Share on other sites More sharing options...
advancedfuture Posted December 3, 2007 Author Share Posted December 3, 2007 Thank you that did the trick! Link to comment https://forums.phpfreaks.com/topic/79929-solved-problems-with-if-else-in-user-authentication/#findComment-404848 Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.