Jump to content

[SOLVED] Problem with my first MySQL Delete Script


Recommended Posts

Hello,

 

I've just started to learn PHP/MySQL from some online tutorials

I'm currently working on my first PHP script for deleting a row from my db

 

I'm facing 2 problems with the code:

 

1- It's not deleting the selected row

 

2- It's only displaying the rows that have Even indices

 

Hope u can help me  ;)

 

this is my code:

 

<?php //connect to mysql$con = mysql_connect("localhost","###","###" , $con ) or die('Unable to connect to DB.<br>'.mysql_connect_error());
// connect or show error message
mysql_select_db("sm_FSpeaches") or die('Unable to select DB.'); 
//select or show error message
//If cmd has not been initialized
// Specifying that cmd is coming from a GET request helps keeping the script running, 
// in case the option register_globals was turned off (for security reasons)

if(!isset($_GET["cmd"])) 
{
//display all the rows 
$result = mysql_query("SELECT * FROM Speaches order by No") or die('Query failed.'); 
//run the while loop that grabs all the rows 

while($r=mysql_fetch_array($result)) {	 
echo '<a href="delete.php?cmd=delete&No='.$r["No"].'>Delete '.$r["No"].' - '.$r["Title"].'</a><br>';	 
//make the title a link 
}
}
else if($_GET["cmd"]=="delete"){		
$num=$_GET["No"]; 
//MUST BE FILTERED TO AVOID CODE-INJECTION ATTACKS!       	
mysql_query("DELETE FROM Speaches WHERE No=$num");	
if (!mysql_query("DELETE FROM Speaches WHERE No=$num")) echo 'Could not delete!';	
else echo 'Row delete.';        

}
else {
echo 'Uh oh! Someone made a bobo!<br>Are you playing with the url? DONT!';
}
@mysql_free_result($result); 
//clean & dont show errors if any
mysql_close($con);
?>

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.