embedding php

[westminster86]

im trying to embed some php in a htlm form action however im getting syntax errors

 

 

    <form action="showCart.php?new=<?php$productid?>" method="post">

 

 

dnt know if im putting the open and close php tags in the right place

 

e suggestions

[awpti]

<form action="showCart.php?new=<?=$productid; ?>" method="post">

[simcoweb]

Don't think he needs that second = sign. Also, be sure that the $productid variable has a value.

[The Little Guy]

<form action="showCart.php?new=<?=$productid; ?>" method="post">

 

or

 

<form action="showCart.php?new=<?php echo $productid; ?>" method="post">

 

the error is probably from forgetting the semi colon.

[revraz]

I would assume short tags are not supported and use his 2nd example below.  Also, you don't need a semi colon if its the last line of code before a ?>

 

<?php echo $productid ?> would work just as good.

 

He just forgot the echo

 

<form action="showCart.php?new=<?=$productid; ?>" method="post">

 

or

 

<form action="showCart.php?new=<?php echo $productid; ?>" method="post">

 

the error is probably from forgetting the semi colon.

[westminster86]

I would assume short tags are not supported and use his 2nd example below.  Also, you don't need a semi colon if its the last line of code before a ?>

 

<?php echo $productid ?> would work just as good.

 

He just forgot the echo

 

<form action="showCart.php?new=<?=$productid; ?>" method="post">

 

or

 

<form action="showCart.php?new=<?php echo $productid; ?>" method="post">

 

the error is probably from forgetting the semi colon.

thanks for ur response but still no joy... syntax errors have gone but its not getting the value of the productid

[revraz]

That means $productid is empty before it hits this part of the code.

[The Little Guy]

where do you set $productid?

[westminster86]

where do you set $productid?

 

function get_product_details($productid)

{

  // query database for all details for a particular product

  if (!$productid || $productid=='')

    return false;

 

    @ $db = mysql_connect('');

    mysql_select_db(');

 

  $query = "select * from products where productid='$productid'";

  $result = mysql_query($query);

  if (!$result)

    return false;

  $result = mysql_fetch_assoc($result);

  return $result;

}

 

function display_product_details($product)

{

  // display all details about this product

  if (is_array($product))

  {

    echo '<table><tr>';

    //display the picture if there is one

    if (@file_exists($product['productid'].'.jpg'))

    {

$myproduct = GetImageSize(($product['productid'].'.jpg'));

 

echo '<img src='.($product['productid']).'.jpg border= '.img_resize($myproduct[0], 

      $myproduct[1], 450).' />';     

 

    }

 

    echo '<td><ul>';

    echo '</li><li><b>Price:</b> £';

    echo number_format($product['price'], 2);

    echo '</li><li><b>Colour:</b> ';

    echo $product['colour'];

    echo '<li><b>Fabric:</b> ';

    echo $product['fabric'];

    echo '</li></ul></td></tr></table>';?>

 

<form action="showCart.php?new=<?php echo $productid ?>" method="post">

    Select size:

    <select name="size">

      <option value=""></option>

      <option value="6">6</option>

      <option value="8">8</option>

      <option value="10">10</option>

      <option value="12">12</option>

        <option value="14">14</option>

    </select> <br/>

Select quantity:

    <select name="quantity">

      <option value="1">1</option>

      <option value="2">2</option>

      <option value="3">3</option>

      <option value="4">4</option>

      <option value="5">5</option>

    </select>

 

<?php

  }

  else

    echo 'The details of this book cannot be displayed at this time.';

  echo '<hr />';

}

[revraz]

What happens when it returns false?

[westminster86]

What happens when it returns false?

 

the line of code in the form action was used with a button, but i wasnt getting the form values in this case size.... so now ive tried doing it this way and now its not passing on the value of product id

[redarrow]

please dont post with your database info, can a admin or mod take the database info out please cheers........

 

 

write is the productid in a session..........

 

i still dont see where the productid is set...........

[duclet]

I don't see anywhere in the source code you provided where it sets the $productid. Also, next time you post the source code, it would be better to wrap them around with the BB code.

[westminster86]

please dont post with your database info, can a admin or mod take the database info out please cheers........

 

 

write is the productid in a session..........

 

i still dont see where the productid is set...........

 

my bad im new to this site... ive taken it off... wont happen again

[revraz]

That's just for your protection so someone doesn't go in and mess with your DB.

[westminster86]

I don't see anywhere in the source code you provided where it sets the $productid. Also, next time you post the source code, it would be better to wrap them around with the BB code.

 

$productid = $_GET['productid'];

 

used at start of script after session_start()

[westminster86]

I don't see anywhere in the source code you provided where it sets the $productid. Also, next time you post the source code, it would be better to wrap them around with the BB code.

 

$productid = $_GET['productid'];

 

used at start of script after session_start()

 

ok ive printed the contents of the variable to see if does actually have  value and it does. Its just not passing on this value on the next page where i render the output in html... so i think that there still a problem in the form action line.... i maybe wrong

[revraz]

Maybe you should use $productid = $_POST['productid']; instead

[westminster86]

Maybe you should use $productid = $_POST['productid']; instead

 

i tryed that

[revraz]

Thats because you are still not getting any data into $productid.

 

You use both $_GET and $_POST but where do you actually get the $productid from?  It has to come from something.  You use it in your FORM, but what generates it?  You are trying to use a variable that has no data is the problem.

[westminster86]

Thats because you are still not getting any data into $productid.

 

You use both $_GET and $_POST but where do you actually get the $productid from?  It has to come from something.  You use it in your FORM, but what generates it?  You are trying to use a variable that has no data is the problem.

 

productid does have a value. basically on the previous page a user selects a product and this product is then passed on to the next page where the browser can view more information about the product. so they click the reference link which has the productid appened to the end of the url... so here im using get. so now they come to the show_product page.. here is where they add the product to the cart... at this stage productid has a value but then it does not pass along to the next page which is the showcartpage... ive probably confused u more now sorry

[revraz]

Ok, if there is in fact a URL with this info, then $_GET is the right way.

 

Show us the all the code that we're trying to help you with.

[westminster86]

Ok, if there is in fact a URL with this info, then $_GET is the right way.

 

Show us the all the code that we're trying to help you with.

 

 

    $url = 'showProduct.php?productid='.($row['productid']);

 

ive created a function where by i have a image and and url link so they can click either. everything works on this page. so then on the next page retriev this value by

  $productid = $_GET['productid'];

 

and this is successful but now when i try agin to pass it on to the page where u add it to the cart its nt passing and i believ its the form action thats causing it

[westminster86]

Ok, if there is in fact a URL with this info, then $_GET is the right way.

 

Show us the all the code that we're trying to help you with.

 

coding for which page?

    $url = 'showProduct.php?productid='.($row['productid']);

 

ive created a function where by i have a image and and url link so they can click either. everything works on this page. so then on the next page retriev this value by

  $productid = $_GET['productid'];

 

and this is successful but now when i try agin to pass it on to the page where u add it to the cart its nt passing and i believ its the form action thats causing it

[revraz]

We want to look at showCart.php don't we?  Which page is having the problem, showCart or showProduct?