Jump to content

Is this correct?


carylson

Recommended Posts

Im not sure if I'm using mysql_fetch_array() and mysql_query() correctly.  I get mysql errors on the following line:

$UserInfo = mysql_fetch_array(mysql_query("SELECT * FROM Users WHERE Username = '". $_REQUEST['frmUsername'] ."' && Password = '". $_REQUEST['frmPassword'] ."'"));

 

Can anybody help?

Thanks!

 

The rest of the code:

<?php

if ($_REQUEST['fcn'] == "login") {

 

if ($_REQUEST['frmUsername'] == "" || $_REQUEST['frmPassword'] == "") {

echo "Invalid login.  Please complete all form data and try again.";

}

else {

$UserInfo = mysql_fetch_array(mysql_query("SELECT * FROM Users WHERE Username = '". $_REQUEST['frmUsername'] ."' && Password = '". $_REQUEST['frmPassword'] ."'"));

 

if ($UserInfo) {

$_SESSION['LoggedIn'] = True;

$_SESSION['ID'] = $UserInfo['ID'];

$_SESSION['Username'] = $UserInfo['Username'];

$_SESSION['AdminLevel'] = $UserInfo['AdminLevel'];

 

echo "Login successful.  Hello, ". $_SESSION['Username'] ."!";

}

else {

echo "Invalid login.  The specified user could not be found.  Please double check your information and try again.";

}

}

}

?>

            ... some html ...

Link to comment
https://forums.phpfreaks.com/topic/84358-is-this-correct/
Share on other sites

Change it to this so I can see the error message:

 

         $query = mysql_query("SELECT * FROM Users WHERE Username = '". $_REQUEST['frmUsername'] ."' && Password = '". $_REQUEST['frmPassword'] ."'")
                  or die(mysql_error());
         $UserInfo = mysql_fetch_array($query);

Link to comment
https://forums.phpfreaks.com/topic/84358-is-this-correct/#findComment-429797
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.