vozzek Posted January 14, 2008 Share Posted January 14, 2008 In the beginning, there was nothingness. I was a snot-nosed web rookie armed with a dozen html tags, a high-speed internet connection, and the daunting task of creating my own retail website. I knew two things: jack and squat. That was about four months ago. Since then, I've self-taught myself CSS, mySQL, some javascript, and with very much help from this board - php. In fact, I went absolutely php berserk. The unlimited flexibility and power it affords you just can't be matched by anything else, and so most of my site ended up being php-driven. Cookie-cutter code didn't cut it, and I ended up doing a lot of things myself. I wrote my own php-based shopping cart, for better or for worse. In the end I know I probably took the long way around certain things, and I know many things can be done a lot better. Still, nothing beats knowing what 100% of your entire site's code means simply because you wrote it all yourself. Please critique my site. I'm open to all criticism, and would love your feedback. So if you can make it look better, load faster, feel cleaner... whatever - I am sooooo totally open to suggestions. The people on this board are sharp-eyed (and sharp-tongued ) but I've always gotten great advice and I respect the opinions here. So without further ado: http://www.thefrogandtheprincess.com/ Keep in mind that I know very little about securing folders or any of that type of stuff. I'd be grateful to learn about that. Any help or advice given is much appreciated. Thanks in advance. Quote Link to comment https://forums.phpfreaks.com/topic/85902-whew-its-finished-thanks-to-all-of-you/ Share on other sites More sharing options...
tibberous Posted January 14, 2008 Share Posted January 14, 2008 I like it. Are you rewriting those links, or is that just how you setup the files? Quote Link to comment https://forums.phpfreaks.com/topic/85902-whew-its-finished-thanks-to-all-of-you/#findComment-438884 Share on other sites More sharing options...
tomfmason Posted January 14, 2008 Share Posted January 14, 2008 The welcome image is pretty pixelated. I would open that image in your image editing software and zoom in to about 300% to 400%(until you can see individual pixels) and remove the offending pixels. You can do this by changing the color of that pixel to match the color behind it. Otherwise it is a decent site. I would work on the color scheme though. I don't really think that green matches that pink very well. Quote Link to comment https://forums.phpfreaks.com/topic/85902-whew-its-finished-thanks-to-all-of-you/#findComment-439031 Share on other sites More sharing options...
tomfmason Posted January 14, 2008 Share Posted January 14, 2008 (this time limit on editing posts is annoying) I really don't like that fact that you used tables for the layout. They should only be used to display tabular data. Quote Link to comment https://forums.phpfreaks.com/topic/85902-whew-its-finished-thanks-to-all-of-you/#findComment-439034 Share on other sites More sharing options...
vozzek Posted January 14, 2008 Author Share Posted January 14, 2008 You're right about the pixelation of some images. I'll get that cleaned up. As for the tables, I didn't know anything about <div> at the time. I'm still learning. In fact, I don't think I used div in the entire site. Are tables slower to load? Quote Link to comment https://forums.phpfreaks.com/topic/85902-whew-its-finished-thanks-to-all-of-you/#findComment-439036 Share on other sites More sharing options...
tomfmason Posted January 14, 2008 Share Posted January 14, 2008 Yes they are a little slower to load and that is mostly due to the fact that when using table based layouts you tend to have almost twice the amount of code that you would have in a css and div based layout. Quote Link to comment https://forums.phpfreaks.com/topic/85902-whew-its-finished-thanks-to-all-of-you/#findComment-439043 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.