[SOLVED] Else's and If's

Lamez · January 17, 2008

Alright I have this code here:

	        $field = "first";  
      if(!$subfirst || strlen($subfirst = trim($subfirst)) == 0){
         $form->setError($field, "* First Name not entered");
      }
  	  /*Last Name has data*/
        $field = "last";  
      if(!$sublast || strlen($sublast = trim($sublast)) == 0){
         $form->setError($field, "* Last Name not entered");
      }
  
  	  	  /*Store Number has data*/
        $field = "store";  
      if(!$substore || strlen($substore = trim($substore)) == 0){
         $form->setError($field, "* Store Number not entered");
      }

its for my registration script, but all three fields return as it was not entered!

Am I doing somthing wrong?

NOTE: This is only part of the code.

predator · January 17, 2008

you are not resetting them else where in the script before you run the actual if statements are you?

regards

mark

teng84 · January 17, 2008

if(!$subfirst || strlen($subfirst = trim($subfirst)) == 0) what do you want with that

Lamez · January 17, 2008

you are not resetting them else where in the script before you run the actual if statements are you?

regards

mark

what do you mean?

predator · January 17, 2008

like you are not nulling them before you do the checks else where are you so you set it then later down the script u make the var = "" and then you are doing the check. Sometimes simple things can cause big probs.

teng84 · January 17, 2008

$field = "first";  
      if(empty($subfirst)){
         $form->setError($field, "* First Name not entered");
      }
  	  /*Last Name has data*/
        $field = "last";  
      if(empty($sublast)){
         $form->setError($field, "* Last Name not entered");
      }
  
  	  	  /*Store Number has data*/
        $field = "store";  
      if(empty($substore)){
         $form->setError($field, "* Store Number not entered");
      }

this works the same as you want try ... you dont need that extra condition

Lamez · January 17, 2008

it still returns as if it was empty.

teng84 · January 17, 2008

it still returns as if it was empty.

men can you explain your prob a bit more the code is actually doing it well

Lamez · January 17, 2008

Sorry, I made this script because these fields are required upon registration. If they leave it empty then it returns with a error code (Ex: * First Name not entered, etc)

Well even if I do put something in the field, it returns with the errors.

teng84 · January 17, 2008

show us this function .. in your class

setError

Lamez · January 17, 2008

   function setError($field, $errmsg){
      $this->errors[$field] = $errmsg;
      $this->num_errors = count($this->errors);
   }

also I have other fields, and they work.

teng84 · January 17, 2008

your function and ifs works well i believe.

can you show us how you contition like if error == 0 etc...

and maybe more of that code..

and are this message like * Last Name not entered displayed?

Lamez · January 17, 2008

<?
include("database.php");
include("mailer.php");
include("form.php");
class Session
{
   var $username;     //Username given on sign-up
   var $userid;       //Random value generated on current login
   var $userlevel;    //The level to which the user pertains
   var $time;         //Time user was last active (page loaded)
   var $logged_in;    //True if user is logged in, false otherwise
   var $userinfo = array();  //The array holding all user info
   var $url;          //The page url current being viewed
   var $referrer;     //Last recorded site page viewed
   /**
    * Note: referrer should really only be considered the actual
    * page referrer in process.php, any other time it may be
    * inaccurate.
    */

   /* Class constructor */
   function Session(){
      $this->time = time();
      $this->startSession();
   }

   /**
    * startSession - Performs all the actions necessary to 
    * initialize this session object. Tries to determine if the
    * the user has logged in already, and sets the variables 
    * accordingly. Also takes advantage of this page load to
    * update the active visitors tables.
    */
   function startSession(){
      global $database;  //The database connection
      session_start();   //Tell PHP to start the session

      /* Determine if user is logged in */
      $this->logged_in = $this->checkLogin();

      /**
       * Set guest value to users not logged in, and update
       * active guests table accordingly.
       */
      if(!$this->logged_in){
         $this->username = $_SESSION['username'] = GUEST_NAME;
         $this->userlevel = GUEST_LEVEL;
         $database->addActiveGuest($_SERVER['REMOTE_ADDR'], $this->time);
      }
      /* Update users last active timestamp */
      else{
         $database->addActiveUser($this->username, $this->time);
      }
      
      /* Remove inactive visitors from database */
      $database->removeInactiveUsers();
      $database->removeInactiveGuests();
      
      /* Set referrer page */
      if(isset($_SESSION['url'])){
         $this->referrer = $_SESSION['url'];
      }else{
         $this->referrer = "/";
      }

      /* Set current url */
      $this->url = $_SESSION['url'] = $_SERVER['PHP_SELF'];
   }
   /**
    * checkLogin - Checks if the user has already previously
    * logged in, and a session with the user has already been
    * established. Also checks to see if user has been remembered.
    * If so, the database is queried to make sure of the user's 
    * authenticity. Returns true if the user has logged in.
    */
   function checkLogin(){
      global $database;  //The database connection
      /* Check if user has been remembered */
      if(isset($_COOKIE['cookname']) && isset($_COOKIE['cookid'])){
         $this->username = $_SESSION['username'] = $_COOKIE['cookname'];
         $this->userid   = $_SESSION['userid']   = $_COOKIE['cookid'];
      }

      /* Username and userid have been set and not guest */
      if(isset($_SESSION['username']) && isset($_SESSION['userid']) &&
         $_SESSION['username'] != GUEST_NAME){
         /* Confirm that username and userid are valid */
         if($database->confirmUserID($_SESSION['username'], $_SESSION['userid']) != 0){
            /* Variables are incorrect, user not logged in */
            unset($_SESSION['username']);
            unset($_SESSION['userid']);
            return false;
         }

         /* User is logged in, set class variables */
         $this->userinfo  = $database->getUserInfo($_SESSION['username']);
         $this->username  = $this->userinfo['username'];
         $this->userid    = $this->userinfo['userid'];
         $this->userlevel = $this->userinfo['userlevel'];
         return true;
      }
      /* User not logged in */
      else{
         return false;
      }
   }

   /**
    * login - The user has submitted his username and password
    * through the login form, this function checks the authenticity
    * of that information in the database and creates the session.
    * Effectively logging in the user if all goes well.
    */
   function login($subuser, $subpass, $subremember){
      global $database, $form;  //The database and form object

      /* Username error checking */
      $field = "user";  //Use field name for username
      if(!$subuser || strlen($subuser = trim($subuser)) == 0){
         $form->setError($field, "* Username not entered");
      }
      else{
         /* Check if username is not alphanumeric */
         if(!eregi("^([0-9a-z])*$", $subuser)){
            $form->setError($field, "* Username not alphanumeric");
         }
      }

      /* Password error checking */
      $field = "pass";  //Use field name for password
      if(!$subpass){
         $form->setError($field, "* Password not entered");
      }
      
      /* Return if form errors exist */
      if($form->num_errors > 0){
         return false;
      }

      /* Checks that username is in database and password is correct */
      $subuser = stripslashes($subuser);
      $result = $database->confirmUserPass($subuser, md5($subpass));

      /* Check error codes */
      if($result == 1){
         $field = "user";
         $form->setError($field, "* Username not found");
      }
      else if($result == 2){
         $field = "pass";
         $form->setError($field, "* Invalid password");
      }
      
      /* Return if form errors exist */
      if($form->num_errors > 0){
         return false;
      }

      /* Username and password correct, register session variables */
      $this->userinfo  = $database->getUserInfo($subuser);
      $this->username  = $_SESSION['username'] = $this->userinfo['username'];
      $this->userid    = $_SESSION['userid']   = $this->generateRandID();
      $this->userlevel = $this->userinfo['userlevel'];
      
      /* Insert userid into database and update active users table */
      $database->updateUserField($this->username, "userid", $this->userid);
      $database->addActiveUser($this->username, $this->time);
      $database->removeActiveGuest($_SERVER['REMOTE_ADDR']);

      /**
       * This is the cool part: the user has requested that we remember that
       * he's logged in, so we set two cookies. One to hold his username,
       * and one to hold his random value userid. It expires by the time
       * specified in constants.php. Now, next time he comes to our site, we will
       * log him in automatically, but only if he didn't log out before he left.
       */
      if($subremember){
         setcookie("cookname", $this->username, time()+COOKIE_EXPIRE, COOKIE_PATH);
         setcookie("cookid",   $this->userid,   time()+COOKIE_EXPIRE, COOKIE_PATH);
      }

      /* Login completed successfully */
      return true;
   }

   /**
    * logout - Gets called when the user wants to be logged out of the
    * website. It deletes any cookies that were stored on the users
    * computer as a result of him wanting to be remembered, and also
    * unsets session variables and demotes his user level to guest.
    */
   function logout(){
      global $database;  //The database connection
      /**
       * Delete cookies - the time must be in the past,
       * so just negate what you added when creating the
       * cookie.
       */
      if(isset($_COOKIE['cookname']) && isset($_COOKIE['cookid'])){
         setcookie("cookname", "", time()-COOKIE_EXPIRE, COOKIE_PATH);
         setcookie("cookid",   "", time()-COOKIE_EXPIRE, COOKIE_PATH);
      }

      /* Unset PHP session variables */
      unset($_SESSION['username']);
      unset($_SESSION['userid']);

      /* Reflect fact that user has logged out */
      $this->logged_in = false;
      
      /**
       * Remove from active users table and add to
       * active guests tables.
       */
      $database->removeActiveUser($this->username);
      $database->addActiveGuest($_SERVER['REMOTE_ADDR'], $this->time);
      
      /* Set user level to guest */
      $this->username  = GUEST_NAME;
      $this->userlevel = GUEST_LEVEL;
   }

   /**
    * register - Gets called when the user has just submitted the
    * registration form. Determines if there were any errors with
    * the entry fields, if so, it records the errors and returns
    * 1. If no errors were found, it registers the new user and
    * returns 0. Returns 2 if registration failed.
    */
   function register($subuser, $subpass, $subemail){
      global $database, $form, $mailer;  //The database, form and mailer object
      
      /* Username error checking */
      $field = "user";  //Use field name for username
      if(!$subuser || strlen($subuser = trim($subuser)) == 0){
         $form->setError($field, "* Username not entered");
      }
      else{
         /* Spruce up username, check length */
         $subuser = stripslashes($subuser);
         if(strlen($subuser) < 5){
            $form->setError($field, "* Username below 5 characters");
         }
         else if(strlen($subuser) > 30){
            $form->setError($field, "* Username above 30 characters");
         }
         /* Check if username is not alphanumeric */
         else if(!eregi("^([0-9a-z])+$", $subuser)){
            $form->setError($field, "* Username not alphanumeric");
         }
         /* Check if username is reserved */
         else if(strcasecmp($subuser, GUEST_NAME) == 0){
            $form->setError($field, "* Username reserved word");
         }
         /* Check if username is already in use */
         else if($database->usernameTaken($subuser)){
            $form->setError($field, "* Username already in use");
         }
         /* Check if username is banned */
         else if($database->usernameBanned($subuser)){
            $form->setError($field, "* Username banned");
         }
      }

      /* Password error checking */
      $field = "pass";  //Use field name for password
      if(!$subpass){
         $form->setError($field, "* Password not entered");
      }
      else{
         /* Spruce up password and check length*/
         $subpass = stripslashes($subpass);
         if(strlen($subpass) < 4){
            $form->setError($field, "* Password too short");
         }
         /* Check if password is not alphanumeric */
         else if(!eregi("^([0-9a-z])+$", ($subpass = trim($subpass)))){
            $form->setError($field, "* Password not alphanumeric");
         }
         /**
          * Note: I trimmed the password only after I checked the length
          * because if you fill the password field up with spaces
          * it looks like a lot more characters than 4, so it looks
          * kind of stupid to report "password too short".
          */
      }
      
/* Email error checking */
      $field = "email";  //Use field name for email
      if(!$subemail || strlen($subemail = trim($subemail)) == 0){
         $form->setError($field, "* Email not entered");
      }
      else{
         /* Check if valid email address */
         $regex = "^[_+a-z0-9-]+(\.[_+a-z0-9-]+)*"
                 ."@[a-z0-9-]+(\.[a-z0-9-]{1,})*"
                 ."\.([a-z]{2,}){1}$";
         if(!eregi($regex,$subemail)){
            $form->setError($field, "* Email invalid");
         }
         /* Check if email is already in use */
         else if($database->emailTaken($subemail)){
            $form->setError($field, "* Email already in use");
         }
         $subemail = stripslashes($subemail);
      } 
  /*Fist Name has data*/
$field = "first";  
      if(empty($subfirst)){
         $form->setError($field, "* First Name not entered");
      }
  	  /*Last Name has data*/
        $field = "last";  
      if(empty($sublast)){
         $form->setError($field, "* Last Name not entered");
      }
  
  	  	  /*Store Number has data*/
        $field = "store";  
      if(empty($substore)){
         $form->setError($field, "* Store Number not entered");
      }
  
  
  
      /* Errors exist, have user correct them */
      if($form->num_errors > 0){
         return 1;  //Errors with form
      }
      /* No errors, add the new account to the */
      else{
         if($database->addNewUser($subuser, md5($subpass), $subemail, $subfirst, $sublast, $substore)){
            if(EMAIL_WELCOME){
               $mailer->sendWelcome($subuser,$subemail,$subpass);
            }
            return 0;  //New user added succesfully
         }else{
            return 2;  //Registration attempt failed
         }
      }
   }
   
   /**
    * editAccount - Attempts to edit the user's account information
    * including the password, which it first makes sure is correct
    * if entered, if so and the new password is in the right
    * format, the change is made. All other fields are changed
    * automatically.
    */
   function editAccount($subcurpass, $subnewpass, $subemail, $subfirst, $sublast, $substore, $subabout, $subage, $subavatar, $subaim, $subyahoo, $subicq, $submsn, $subxfire){
      global $database, $form;  //The database and form object
  
  /*Store Number*/
        if($substore){
      $database->updateUserField($this->username,"store",$substore);
      }
  
  /*First Name*/
        if($subfirst){
      $database->updateUserField($this->username,"first",$subfirst);
      }
  /*Last Name*/
        if($sublast){
      $database->updateUserField($this->username,"last",$sublast);
      }
  
  			/*About*/
      if($subabout){
      $database->updateUserField($this->username,"about",$subabout);
      }
	        /*Age*/
      if($subage){
      $database->updateUserField($this->username,"age",$subage);
      }      


          /*Messengers*/
			     //AIM
      if($subaim){
      $database->updateUserField($this->username,"aim",$subaim);
      }
  				//Yahoo!
      if($subyahoo){
      $database->updateUserField($this->username,"yahoo",$subyahoo);
      }
  				//ICQ
      if($subicq){
      $database->updateUserField($this->username,"icq",$subicq);
      }
  				//MSN
      if($submsn){
      $database->updateUserField($this->username,"msn",$submsn);
      }
  				//XFIRE
      if($subxfire){
      $database->updateUserField($this->username,"xfire",$subxfire);
      }
  
      /* New password entered */
      if($subnewpass){
         /* Current Password error checking */
         $field = "curpass";  //Use field name for current password
         if(!$subcurpass){
            $form->setError($field, "* Current Password not entered");
         }
         else{
            /* Check if password too short or is not alphanumeric */
            $subcurpass = stripslashes($subcurpass);
            if(strlen($subcurpass) < 4 ||
               !eregi("^([0-9a-z])+$", ($subcurpass = trim($subcurpass)))){
               $form->setError($field, "* Current Password incorrect");
            }
            /* Password entered is incorrect */
            if($database->confirmUserPass($this->username,md5($subcurpass)) != 0){
               $form->setError($field, "* Current Password incorrect");
            }
         }
         
         /* New Password error checking */
         $field = "newpass";  //Use field name for new password
         /* Spruce up password and check length*/
         $subpass = stripslashes($subnewpass);
         if(strlen($subnewpass) < 4){
            $form->setError($field, "* New Password too short");
         }
         /* Check if password is not alphanumeric */
         else if(!eregi("^([0-9a-z])+$", ($subnewpass = trim($subnewpass)))){
            $form->setError($field, "* New Password not alphanumeric");
         }
      }
      /* Change password attempted */
      else if($subcurpass){
         /* New Password error reporting */
         $field = "newpass";  //Use field name for new password
         $form->setError($field, "* New Password not entered");
      }
      
      /* Email error checking */
      $field = "email";  //Use field name for email
      if($subemail && strlen($subemail = trim($subemail)) > 0){
         /* Check if valid email address */
         $regex = "^[_+a-z0-9-]+(\.[_+a-z0-9-]+)*"
                 ."@[a-z0-9-]+(\.[a-z0-9-]{1,})*"
                 ."\.([a-z]{2,}){1}$";
         if(!eregi($regex,$subemail)){
            $form->setError($field, "* Email invalid");
         }
         $subemail = stripslashes($subemail);
      }
      
      /* Errors exist, have user correct them */
      if($form->num_errors > 0){
         return false;  //Errors with form
      }
      
      /* Update password since there were no errors */
      if($subcurpass && $subnewpass){
         $database->updateUserField($this->username,"password",md5($subnewpass));
      }
      
      /* Change Email */
      if($subemail){
         $database->updateUserField($this->username,"email",$subemail);
      }
      
      /* Success! */
      return true;
   }
   
   /**
    * isAdmin - Returns true if currently logged in user is
    * an administrator, false otherwise.
    */
   function isAdmin(){
      return ($this->userlevel == ADMIN_LEVEL ||
              $this->username  == ADMIN_NAME);
   }
   
   /**
    * generateRandID - Generates a string made up of randomized
    * letters (lower and upper case) and digits and returns
    * the md5 hash of it to be used as a userid.
    */
   function generateRandID(){
      return md5($this->generateRandStr(16));
   }
   
   /**
    * generateRandStr - Generates a string made up of randomized
    * letters (lower and upper case) and digits, the length
    * is a specified parameter.
    */
   function generateRandStr($length){
      $randstr = "";
      for($i=0; $i<$length; $i++){
         $randnum = mt_rand(0,61);
         if($randnum < 10){
            $randstr .= chr($randnum+48);
         }else if($randnum < 36){
            $randstr .= chr($randnum+55);
         }else{
            $randstr .= chr($randnum+61);
         }
      }
      return $randstr;
   }
};


/**
* Initialize session object - This must be initialized before
* the form object because the form uses session variables,
* which cannot be accessed unless the session has started.
*/
$session = new Session;

/* Initialize form object */
$form = new Form;
?>

there is the session code, the code that checks for errors (above)

here is the form for the registration

<h2>Register</h2>
<form action="style/include/process.php" method="POST">
<table align="left" border="0" cellspacing="0" cellpadding="3">
<tr>
  <td width="111" align="left">Username</td>
<td width="163"><input type="text" name="user" maxlength="30" value="<? echo $form->value("user"); ?>"></td><td width="280" align="left"><? echo $form->error("user"); ?></td>
</tr>
<tr>
  <td align="left">Password</td>
  <td align="left"><input type="password" name="pass" maxlength="30" value="<? echo $form->value("pass"); ?>" /></td>
  <td align="left"><? echo $form->error("pass"); ?></td>
</tr>
<tr>
  <td align="left">Email</td>
  <td align="left"><input type="text" name="email" maxlength="50" value="<? echo $form->value("email"); ?>" /></td>
  <td><? echo $form->error("email"); ?></td>
</tr>
<tr>
  <td>First Name</td>
  <td align="left"><input type="text" name="first" maxlength="50" value="<? echo $form->value("first"); ?>" /></td>
  <td align="left"><? echo $form->error("first"); ?></td>
</tr>
<tr>
  <td>Last Name</td>
  <td align="left"><input type="text" name="last" maxlength="50" value="<? echo $form->value("last"); ?>" /></td>
  <td align="left"><? echo $form->error("last"); ?></td>
</tr>
<tr>
  <td>Store Number</td>
  <td align="left"><input type="text" name="store" maxlength="3" value="<? echo $form->value("store"); ?>" onKeyPress="return numbersonly(this, event)" /></td>
  <td align="left"><? echo $form->error("store"); ?></td>
</tr>
<tr><td> </td>
<td align="left">
  <input type="hidden" name="subjoin" value="1" />
  <input name="submit" type="submit" value="Signup!" /></td><td align="right"><a href="user/forgotpass.php">Forgot Password?</a></td>
</tr>
<tr><td colspan="2" align="right"> </td>
</tr>
<tr><td colspan="2" align="left"></td>
</tr>
</table>
</form>

Lamez · January 17, 2008

also here is the ==0 and what not:

      /* Registration Successful */
      if($retval == 0){
         $_SESSION['reguname'] = $_POST['user'];
         $_SESSION['regsuccess'] = true;
         header("Location: ".$session->referrer);
      }
      /* Error found with form */
      else if($retval == 1){
         $_SESSION['value_array'] = $_POST;
         $_SESSION['error_array'] = $form->getErrorArray();
         header("Location: ".$session->referrer);
      }
      /* Registration attempt failed */
      else if($retval == 2){
         $_SESSION['reguname'] = $_POST['user'];
         $_SESSION['regsuccess'] = false;
         header("Location: ".$session->referrer);
      }
   }

teng84 · January 17, 2008

sorry mate got to go home office hour is over..

ill try to fix this tom if this is not fix

Lamez · January 17, 2008

Thanks pal, Take your time.

Ken2k7 · January 17, 2008

1. The variables you're testing with the function empty() are not defined in that php file. What I mean by that is: $subfirst, $substore etc aren't defined so empty($subfirst) and empty($substore) are always true.

2. That php file that you posted isn't really relevant. Where's process.php?

Lamez · January 17, 2008

Ken it is defined, I do know what I did this time.

Thanks!

Sign In

[SOLVED] Else's and If's

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information