[SOLVED] verify input

[pwes24]

This is a small issue I believe, but I just can't get it right. Please help.

 

I'm like to store login info for new users. This script should check user input and if empty, should return error msg and not save anything on the database table. But my code saves whatever is sent even if some sections are empty. What should I do?

 

if ($name == "") {
$error .= "Enter your name";
}
if ($username == "") {
$error .= "Enter username";
}
if($password == "") {
$error .= "Enter password";
}
else {
$query = "insert into 'login' values()";

 

I have shortened to get to the point. If I only use one 'if' and one 'else' statement it works well. What can I do?

[vicodin]

Use Else If

[clown[NOR]]

try this

$error = array();
if (empty($name)) { $error[] = "No name"; }
if (empty($username)) { $error[] = "No username"; }
if (empty($password)) { $error[] = "No password"; }
if (!empty($error)) {
foreach ($error as $error1) {
echo $error1."<br />";
} else { $wuery = "insert into 'login' values()"; }

[toplay]

You forgot the "else" on the "if" conditions, however, the "ifelse" approach will show only one error at a time (and your ".=" notation will not really come into play/work).

 

Here's another approach:

 

<?php

// Example where it collects all errors to display at once.

$blnContinue = TRUE;
$arrError = array();

if (empty($name)) {
   $arrError[] = 'Enter your name';
   $blnContinue = FALSE;
}

if (empty($username)) {
   $arrError[] = 'Enter a username';
   $blnContinue = FALSE;
}

if (empty($password)) {
   $arrError[] = 'Enter a password';
   $blnContinue = FALSE;
}

if ($blnContinue) {

   $query = "insert into 'login' values()";
   // check query worked and display good message

} else { // display errors found

   echo implode('<br/>', $arrError);
}

?>

[clown[NOR]]

my bad... it's 5.30 am here =)

[pwes24]

Thanks everyone! Much love