MySQL Syntax Error

[logicopinion]

hello... there is a code beloew.. which i created... and on my local mashin it works and does not make any error.. but as soon as i upload it to server it give me error.. i do not understant why...

 

This is error:

 

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

 

and this is code of that page:

 

<?php
$login_username =  stripslashes($_POST['login_username']);
$login_password =  stripslashes($_POST['login_password']);

$oneday = 60 * 60 * 24 + time();
setcookie("firstschool_username", "$login_username", 
$oneday);
setcookie("firstschool_password", "$login_password", $oneday);
include ("includes/vars.php");
mysql_connect("$hostname",  "$username",  "$password") or die(mysql_error());
mysql_select_db("$database") or die(mysql_error());
$query = "SELECT * FROM $login";
$result = mysql_query($query) or die(mysql_error());
while($row = mysql_fetch_array($result))
{

if ($login_username == $row[username] && $login_password == $row[password] )
{
echo "<meta http-equiv=\"REFRESH\" content=\"0;url=index.php\">";
}
else
{

echo "<meta http-equiv=\"REFRESH\" content=\"0; url=login.php\">";

exit;
}


}
?>

 

 

also here is the code of vars.php file which is included in this page ...

 

<?php

$hostname="localhost";
$username="schoge_admin";
$password="mypassword";
$database="schoge_firstschool";
$database2="forum";
$news="mynews";
$bulletin="mybulletin";
$navigation="menu";
$login="login";

?>

 

 

Thanks for your attention

 

[revraz]

echo $query and see what it looks like.

[logicopinion]

sorry i am realy newbie in MySQL and .. how to echo quary?

what should i do?

[marcus]

echo $query;

 

Try doing something like:

 

$query = "SELECT * FROM `". $login . "`";

[logicopinion]

oops wait .. mistaken.. wait a moment

[marcus]

You're changing the wrong query, silly.

[revraz]

Looking at your code, it appears you are selecting every record and looping through them to check the id and pw.  This seems like a waste of resources.  What you want to do is do a SELECT statement but only return the record that matches.

 

$query = "SELECT * FROM `login` WHERE `username` = '$login_username' AND `password` = '$login_password'";
$result = mysql_query($query) or die(mysql_error());
if (mysql_num_rows($result) > 0) {
echo "Logged in, redirecting";
echo "<meta http-equiv=\"REFRESH\" content=\"3;url=index.php\">";
}
else {
echo "Wrong username or password";
echo "<meta http-equiv=\"REFRESH\" content=\"3; url=login.php\">";
}

 

[logicopinion]

yes ... no it says

 

incorrect table name

[revraz]

Then `login` is not your tablename?

[logicopinion]

$login="login"

 

this is in my vars.php file

 

so the tablename is login.

 

but even now .. when i check this code on my machine it works fine.. but when putting it online on the server.. it goes wrong...

[marcus]

Does the table even exist.

[haku]

Then the table name on your local machine is "login", but on your server it either has a different name, or the table doesn't exist.

 

Have you set up the database on your server?

[logicopinion]

Incorrect table name ''

 

 

there something wrong withi this sign ( " )

 

 

can`t find the reason spent all day but unsuccssesfully

[revraz]

That means there is nothing in that variable, it's empty.

 

Substitute the actual table name like I did in the example above.

[marcus]

No, it means there's no value within the two quotes.

 

Therefore, login isn't defined.

[logicopinion]

but then why does it works when i do something like

 

mmmm

 

what if i just echo $login

 

if it will print table name it means that value is defined for $login right?

[marcus]

Sure, try echoing $login and see if it really is defined.

[logicopinion]

....
while($row = mysql_fetch_array($result))
{

if ($login_username == $row[username] && $login_password == $row[password] )
{
echo "$login";
}
.....

 

 

yes on my local mashine it works and print just  a word login

 

 

but when on the server ... it prints nothing just an empty white page..

[marcus]

Then login isn't defined, just replace $login with login in your query

[logicopinion]

selecting statement but returning the record that matches solved the problem !!!

 

NOT IT WORKS.

 

but i wonder why?

 

<?php
$login_username =  stripslashes($_POST['login_username']);
$login_password =  stripslashes($_POST['login_password']);

$oneday = 60 * 60 * 24 + time();
setcookie('firstschool_username', '$login_username', $oneday);
setcookie('firstschool_password', '$login_password', $oneday);
include ("includes/vars.php");
mysql_connect("$hostname",  "$username",  "$password") or die(mysql_error());
mysql_select_db("$database") or die(mysql_error());
$query = "SELECT * FROM `login` WHERE `username` = '$login_username' AND `password` = '$login_password'";
$result = mysql_query($query) or die(mysql_error());
if (mysql_num_rows($result) > 0) {
echo "Logged in, redirecting";
echo "<meta http-equiv=\"REFRESH\" content=\"3;url=index.php\">";
}
else {
echo "Wrong username or password";
echo "<meta http-equiv=\"REFRESH\" content=\"3; url=login.php\">";
}

?>

[revraz]

Check your include file, maybe there is a problem.

[logicopinion]

its done man !

 

thank you