Not Updating

[affordit]

Can someone tell me whats wrong with this update query?

$i = 0;
while ($info = mysql_fetch_array($result)) {
$acctnum = createAcctNum();
// UPDATE THE ROW
//
$update = "UPDATE `test` SET `acct_num`= . $city . '-' . $acctnum . '-' . $info['id']  WHERE `id`=" . $info['id'] or die (mysql_error());
mysql_query($update);
echo "updated" .  $username;
$i++;

}

[schilly]

Try this and see if you get an error

<?php
$update = "UPDATE `test` SET `acct_num`= $city-$acctnum-" . $info['id'] . " WHERE `id`=" . $info['id']; 
mysql_query($update) or die (mysql_error());
echo "updated" .  $username;
$i++;
}
?>

[affordit]

Unknown column 'KLA' in 'field list' (This is the city var)

[schilly]

Echo the $update sting and post it.

 

I'm thinking you need quotes around the account_num value.

$update = "UPDATE `test` SET `acct_num`= '$city-$acctnum-" . $info['id'] . "' WHERE `id`=" . $info['id']; 

 

 

 

[affordit]

Just a blank page

[affordit]

Just a blank page

[Bauer418]

<?php
$update = "UPDATE `test` SET `acct_num`='" . mysql_real_escape_string($city . '-' . $acctnum . '-' . $info['id']) . "' WHERE `id`='" . mysql_real_escape_string($info['id']) . "'"; 
mysql_query($update) or die (mysql_error());
echo "updated" .  $username;
$i++;
}
?>

I may have gone overboard with mysql_real_escape_string, but you should always be cleaning your variables before using them in a query.

[affordit]

Thanks work great