Is This The Right Way?

[IT-Guy]

Hey,

 

My login script below is returning a "Wrong Username/Password" So Im going to publish the checklogin.php which handles the data from the login.htm page. I will also post the login.htm page. I can't figure out why its returning that result when the username/password exists in the database any suggestions?

 

login.htm

<table cellSpacing="3" cellPadding="0" width="100%">
	<table width="300" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<form name="form1" method="post" action="checklogin.php">
<td>
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td colspan="3"><strong>Member Login </strong></td>
</tr>
<tr>
<td width="78">Username</td>
<td width="6">:</td>
<td width="294"><input name="myusername" type="text" id="myusername" size="20"></td>
</tr>
<tr>
<td>Password</td>
<td>:</td>
<td><input name="mypassword" type="password" id="mypassword" size="20"></td>
</tr>
<tr>
<td> </td>
<td> </td>
<td><input type="submit" name="submit" value="Login"></td>
</tr>
</table>
</td>
</form>
</tr>
</table>
</table>

 

checklogin.php

<?php
$host="****"; // Host name 
$username="****"; // Mysql username 
$password="****"; // Mysql password 
$db_name="****"; // Database name
$tbl_name="****"; // Table name 

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

// username and password sent from signup form 
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);

// Mysql_num_row is counting table row
$count=@mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row

if($count==1){
// Register $myusername, $mypassword and redirect to file "members/login_successful.php"
session_register("myusername");
session_register("mypassword"); 
header("location:members/login_successful.php");
}
else {
echo "Wrong Username or Password";
}
?>

[mainewoods]

try echoing out the $sql variable just before submitting it to make sure everthing is ok there:

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
echo sql; // debug
$result=mysql_query($sql);