Syntax Question

[jmfillman]

public function addUpdateApp($id, $date, $month, $year, $day) {

  if ($id==0) {

      $query = "INSERT INTO app VALUES (NULL, $date, $month, $year, $day)";

      $result = mysql_query($query);

      $msg=$this->err_prefix."INSERT query error: ".$this->mysql->error;

      throw new Exception($msg);

  }

  else {

      $query = "UPDATE app SET date=$date, month=$month, year=$year, day=$day WHERE id=$id";

      $result = mysql_query($query);

      $msg=$this->err_prefix."UPDATE query error: ".$this->mysql->error;

      throw new Exception($msg);

  }

  return;

}

 

I don't seem to be getting a PHP error, per-se, but there is some sort of syntax issue with the insert and update statements. They look correct to me, so I'm not sure what my error is. The error message is returning "INSERT query error: " or "UPDATE query error: ", but no other details.

 

[p2grace]

Try putting your queries in complete syntax.

 

public function addUpdateApp($id, $date, $month, $year, $day) {
   if ($id==0) {
      $query = "INSERT INTO `app` (`field2`,`field3`,`field4`,`field5`) VALUES ('$date', '$month', '$year', '$day')";
      $result = mysql_query($query);
      $msg=$this->err_prefix."INSERT query error: ".$this->mysql->error;
      throw new Exception($msg);
   }
   else {
      $query = "UPDATE `app` SET `date`='$date', `month`='$month', `year`='$year', `day`='$day' WHERE `id`='$id'";
      $result = mysql_query($query);
      $msg=$this->err_prefix."UPDATE query error: ".$this->mysql->error;
      throw new Exception($msg);
   }
   return true;
}

[tibberous]

...

 

You code funny - like a java programmer.

 

If you add the line: die(mysql_error()) after the $result = mysql_query($query); lines you'll get a readable error. I'm not sure if you can send in NULL for the id or not, but that might be your error.

[jmfillman]

Thank you. Both replies were very helpful.