submit is not a function error

[The Little Guy]

When I press the submit button, I get an error saying:

Error: document.loginForm.submit is not a function

Source File: http://beta.tzfiles.com/

Line: 123

 

function checkLogin(){
var good = true;
if(document.getElementById('usrNT').value.length < 1){
	document.getElementById('usrN').style.color = '#FF0000';
	good = false;
}else{
	document.getElementById('usrN').style.color = '#000000';
	good = true;
}
if(document.getElementById('usrPT').value.length < 1){
	document.getElementById('usrP').style.color = '#FF0000';
	good = false;
}else{
	document.getElementById('usrP').style.color = '#000000';
	good = true;
}
if(good){
	document.loginForm.submit();
}
}

 

 

		<form id="loginForm" name="loginForm" action="/process/login.php" method="post">
		<p><label id="usrN" for="user">Username:</label> <input onkeydown="javascript:hitkey(event);" id="usrNT" type="text" id="user" name="user" size="10" />   
		<label id="usrP" for="pass">Password:</label> <input onkeydown="javascript:hitkey(event);" id="usrPT" name="pass" id="pass" type="password" size="10" />
		<input id="submit" name="submit" value="Login" type="button" onclick="checkLogin();"></p>
	</form>

[haku]

It looks to me like it should work. So since it doesn't, replace the code in error with this:

 

var target = document.getElementById("loginForm")
target.submit()

 

note: does it work if you click the submit button?

 

 

[The Little Guy]

same error here is the page:

 

Page: http://beta.tzfiles.com/

 

top right form

username: demo

password: demo12

[haku]

Take off the leading slash in the action of your form tag. I believe that is your problem.

[The Little Guy]

Nope still same error.

[haku]

First, try to get it working without javascript. You are missing the closing slash on your input button. Add that, then lets see what happens. This shouldn't affect your javascript, but I'm thinking its not a javascript issue at this point, as it doesnt work even with javascript off.

 

edit: I'm slow tonite. 'Name' is deprecated for form elements. Take away the name in your form tag, and use the submit code I posted earlier that has the getElementById in order to submit the form.

[The Little Guy]

still doesn't work.

[haku]

Keep on trying!

 

Change the type in your submit button from 'button' to 'submit'. That solves the problem of the form not submitting at all. After you do that, lets work on the javascript.

[The Little Guy]

OK it is a submit

[haku]

now change the 'name' attribute from 'submit' to 'submit_form'.

[The Little Guy]

fixed it!

 

It was because I had my button named:

 

id="submit"

name="submit"

 

I changed them to

 

id="submitBtn"

name="submitBtn"

[haku]

Thats what I was thinking at the end, which is why I told you to change the name. The ID was no problem, but the fact that you had buttons with the name 'submit' was making the javascript think that 'submit' was an object, not a function. Thats where the conflict was coming from.