Jump to content

[SOLVED] How to prevent this


peranha

Recommended Posts

Cross Site Scripting:

You can submit ">code when adding comments.

 

Cross Site Scripting:

You can submit ">code when creating a PM.

 

I am woundering how to prevent this from happening.

 

Here is my add comment page.

 

<?php
// open connection
$connection = mysql_connect($server, $user, $pass) or die ("Unable to connect!");

// select database
mysql_select_db($db) or die ("Unable to select database!");

// Escape strings, and make sure they are filled in
$subject = empty($_POST['subject']) ? die ("<b class=red>ERROR: Enter Subject</b>") : mysql_real_escape_string(strip_tags($_POST['subject']));
$comment = empty($_POST['post']) ? die ("<b class=red>ERROR: Enter a Comment</b>") : mysql_real_escape_string($_POST['post']);

// create query
$query = "INSERT INTO " . $pre . "comments (subject, comment, user, timestamp) VALUES ('$subject', '$comment', '$_SESSION[username]', '$stamp')";

// execute query
$result = mysql_query($query) or die ("Error in query: $query. ".mysql_error());

// close connection
mysql_close($connection);
?>

Link to comment
Share on other sites

if your just wanting to stop < and > then you could just do

 

$replace=array('<','>');

$with=array('','');

$var=str_replace($replace,$with,$var);

 

that's a simple way but may be other better ways to auto remove everything that could be a vunrability.

 

Regards

Liam

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.