help with my crap code

pumaf1 · March 6, 2008

Hi all

I am having problems with my script here:

http://www.pumaf1.org.uk/infobase/yearall.php

what I want it to do is when you select the year, its lists the rounds (which it does) in this case "1970" then i want the user to click the round, say "round 1" and for it to display the list of the results from that year (1970) and display that rounds results (round 1).

All I can get is get the *********** thing to list all round 1 results!

it works fine upto the point of the round selection:

code for the "yearalld.php" file

  
   // select the database
   mysql_select_db( 'web16-results' )
      or die( "Error! Could not select the database: " . mysql_error() );
    // get the year from URL request
   $year = $_REQUEST['year'];  
   
   // retrieve all the rows from the database
   $query = "SELECT * FROM infobase WHERE `year`='$year' ";
   $query = "SELECT DISTINCT round FROM infobase ORDER BY round asc";
   
   $results = mysql_query( $query );

   // print out the results
   if( $results )
   {
?>

   
<body bgcolor="#000000" background="img/back.jpg" text="#FFFFFF" link="#FFFFFF" vlink="#FFFFFF" alink="#FFFFFF"><div align="center">
  <p><font size="2"> 
    <? include 'top.php' ?>
    </font></p>
  </div>
<table width="300" border="0" align="center">
  <tr> 
    <td>
<div align="center"><font size="2" face="verdana"><span class="style3"></span></font> 
        <font size="2" face="verdana"> </font> <font size="4" face="verdana"><strong>Rounds 
        </strong></font><font size="2" face="verdana"><?php echo( "$year" );?></font><font size="4" face="verdana"><strong> 
        </strong></font></div></td>
  </tr>
</table>
<table width="300" border="0" align="center" cellpadding="1" cellspacing="1">
  <?php
      while( $contact = mysql_fetch_object( $results ) )
      {
         // print out the info
         $id      = $contact -> id;
	 $year    = $contact -> year;
         $round   = $contact -> round;
	?>
  <tr> 
    <td><div align="center"> 
        <p><font size="2" face="verdana"> 
          <?php 
	echo( "<a HREF='rounds.php?round=$round>$round<br></a>" );
	?>
          </font></p>
      </div>
      </td>
  </tr>
  <?		 
         
      }
   }
   else
   {
      die( "Sorry we are having a database problem, please contact admin and report the following error : " . mysql_error() );
   }
   
?>
</table>
<p align="center"><a href="javascript:history.go(-1)" class="style1"><font size="2" face="verdana">Back</font></a></p>
</body>

the code for the round page

 
   // select the database
   mysql_select_db( 'web16-results' )
      or die( "Error! Could not select the database: " . mysql_error() );
   
   // get the round and year from the URL request
   $round = $_REQUEST['round'];
   $year = $_REQUEST['year'];

   // retrieve the row from the database
   $query = "SELECT * FROM `infobase` WHERE `round`='$round'";
   
   $result = mysql_query( $query );

   // print out the results
   if( $result && $contact = mysql_fetch_object( $result ) )
   {
      // print out the info
      $round = $contact -> round;
  $year = $contact -> year;
      ?>
        <table width="100%" border="0" cellpadding="1" cellspacing="1">
          <tr> 
            <th align="left"><div align="center"><font color="#FFFFFF" size="3" face="Arial, Helvetica, sans-serif"><?php echo($round) ?></font></div></th>
          </tr>
          <tr> 
            <th align="left"> </th>
          </tr>
          <tr> 
            <th align="left"> 
              <?php
mysql_select_db($database_results, $results);
$query_driver = "SELECT * FROM infobase WHERE `round`='$round' ORDER BY year asc";
$driver = mysql_query($query_driver, $results) or die(mysql_error());
$row_driver = mysql_fetch_assoc($driver);
$totalRows_driver = mysql_num_rows($driver);
?>
              <table width="1028" border="0" align="center" cellpadding="1" cellspacing="1">
                <tr bgcolor="#666666"> 
                  <td width="67"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Year</span></font></strong></div></td>
                  <td width="76"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Round</span></font></strong></div></td>
                  <td width="83"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Country</span></font></strong></div></td>
                  <td width="70"><div align="center" class="style7"><strong><font size="2" face="verdana">Circuit</font></strong></div></td>
                  <td width="65"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Pos</span></font></strong></div></td>
                  <td width="72"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Team</span></font></strong></div></td>
                  <td width="82"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Engine</span></font></strong></div></td>
                  <td width="68"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Tyres</span></font></strong></div></td>
                  <td width="68"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Laps</span></font></strong></div></td>
                  <td width="92"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Race 
                      Time </span></font></strong></div></td>
                  <td width="92"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Notes</span></font></strong></div></td>
                  <td width="65"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Grid</span></font></strong></div></td>
                  <td width="88"><div align="center" class="style7"><strong><font size="2" face="verdana"><span class="style5">Weather</span></font></strong></div></td>
                </tr>
                <?php do { ?>
                <tr bgcolor="#999999"> 
                  <td><div align="center"><font size="2" face="verdana"><?php echo $row_driver['year']; ?></span></font></div></td>
                  <td><div align="center"><font size="2" face="verdana"><?php echo $row_driver['round']; ?></span></font></div></td>
                  <td><font size="2" face="verdana"><?php echo $row_driver['country']; ?></span></font></td>
                  <td><font size="2" face="verdana"><?php echo $row_driver['track']; ?></span></font></td>
                  <td><div align="center"><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['pos']; ?></span></font></div></td>
                  <td><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['team']; ?></span></font></td>
                  <td><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['engine']; ?></span></font></td>
                  <td><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['tyres']; ?></span></font></td>
                  <td><div align="center"><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['laps']; ?></span></font></div></td>
                  <td><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['racetime']; ?></span></font></td>
                  <td><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['reason']; ?></span></font></td>
                  <td><div align="center"><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['grid']; ?></span></font></div></td>
                  <td><font size="2" face="verdana"><span class="style3"><?php echo $row_driver['weather']; ?></span></font></td>
                </tr>
                <?php } while ($row_driver = mysql_fetch_assoc($driver)); ?>
              </table></th>
          </tr>
          <tr> 
            <th align="left"><div align="center"><a href="javascript:history.go(-1)" class="style1"><font size="2" face="verdana">Back</font></a></div></th>
          </tr>
        </table>
        <font color="#000000">
        <?php

   }
   else
   {
      die( "Error: Could not get contact from database. ".mysql_error() );
   }
   
?>
      </td>
    </tr>
    <tr> 
      <td></td>
    </tr>
  </table>
</div>
</body>
</html>
<?php
mysql_free_result($driver);
?>

craygo · March 6, 2008

You need to pass the year along after they select it

so change this

echo( "<a HREF='rounds.php?round=$round>$round<br></a>" );

to this

echo( "<a HREF='rounds.php?round=$round&year=".$_GET['year']."'>$round<br></a>" );

then make sure you add the year to the query

$year = $_GET['year'];
$query = "SELECT * FROM `infobase` WHERE `round`='$round' AND year = '$year'";

Ray

pumaf1 · March 6, 2008

is that all to the yearalld.php file?

craygo · March 6, 2008

this

echo( "<a HREF='rounds.php?round=$round&year=".$_GET['year']."'>$round<br></a>" );

Is in the yearalld.php file

$year = $_GET['year'];
$query = "SELECT * FROM `infobase` WHERE `round`='$round' AND year = '$year'";

would be in the rounds.php file

Ray

pumaf1 · March 6, 2008

AWESOME thankyou!!!!!!!

Sign In

help with my crap code

Recommended Posts

pumaf1

Link to comment

Share on other sites

craygo

Link to comment

Share on other sites

pumaf1

Link to comment

Share on other sites

craygo

Link to comment

Share on other sites

pumaf1

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information