graham23s Posted March 16, 2008 Share Posted March 16, 2008 Hi Guys, on the registration form i am making if there is any errors in the array they are displayed like this: // display errors if there is any // if(isset($errors)) { print("<div id='signup_errors'>"); foreach($errors as $error) { print("<img src='img/cross.gif'> - $error<br />"); } print("</div>"); } // end errors isset // so i use a div to style the errors, but when there are no errors the div is still displayed but without any errors so it's like the shell but nothing in it! i thought the code inside the foreach would only execute if there was errors so if the is errors then the form is dispalyed does it look right at all? heres the full form: join.php <?php print("<form action='join.php' method='POST' name='join_form' enctype='multipart/form-data'>"); print("<table class='form_table' cellpadding='5' cellspacing='0' >\n"); print("<tr>\n"); print("<td colspan='2' align='left'><h1>Join Up</h1></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td colspan='2' align='left'><h1>Your Profile Details</h1></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Username:</b></label></td><td class='form_style' align='left'><input type='text' name='username' class='textfield' size='40'> <span class='star'>*</span> Required.</td>"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Password:</b></label></td><td class='form_style' align='left'><input type='password' name='pass_1' class='textfield' size='40'> <span class='star'>*</span> Required.</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Confirm Password:</b></label></td><td class='form_style' align='left'><input type='password' name='pass_2' class='textfield' size='40'> <span class='star'>*</span> Required.</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>E-Mail:</b></label></td><td class='form_style' align='left'><input type='text' name='email_1' class='textfield' size='40'> <span class='star'>*</span> Required.</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Confirm E-Mail:</b></label></td><td class='form_style' align='left'><input type='text' name='email_2' class='textfield' size='40'> <span class='star'>*</span> Required.</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Gender:</b></label></td><td class='form_style' align='left'>\n"); print("<select name='gender'>"); foreach($gender_array as $key => $gender_value) { print("<option value='$key'>$gender_value</option>"); } print("</select>"); print("</td>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Birthdate:</b></label></td><td class='form_style' align='left'>\n"); print("<select name='birth_month'>\n"); foreach($birth_month as $key => $birth_month_value) { print("<option value='$key'>$birth_month_value</option>\n"); } print("</select>\n"); print("<select name='birth_day'>\n"); for($i = 1; $i <= 31; $i++) { print("<option value='$i'>$i</option>\n"); } print("</select>\n"); print("<select name='birth_year'>\n"); for($year = 1930; $year <= 2008; $year++) { print("<option value='$year'>$year</option>\n"); } print("</select>\n"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Country:</b></label></td><td class='form_style' align='left'>\n"); print("<select name='country'>\n"); foreach($countries_list as $key => $country_value) { print("<option value='$key'>$country_value</option>\n"); } print("</select>\n"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>State / County:</b></label></td><td class='form_style' align='left'><input type='text' name='state_county' class='textfield' size='40'></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>City:</b></label></td><td class='form_style' align='left'><input type='text' name='city' class='textfield' size='40'></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Zip / Post Code:</b></label></td><td class='form_style' align='left'><input type='text' name='code' class='textfield' size='40'> <span class='star'>*</span> Required.</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td colspan='2' align='left'><h1>Your Personal Details</h1></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Do You Smoke?</b></label></td><td class='form_style' align='left'>"); print("<select name='smoke'>"); foreach($smoking_array as $key => $smoking_value) { print("<option value='$key'>$smoking_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Do You Drink?</b></label></td><td class='form_style' align='left'>"); print("<select name='drink'>"); foreach($drinking_array as $key => $drinking_value) { print("<option value='$key'>$drinking_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Your Height?</b></label></td><td class='form_style' align='left'>"); print("<select name='height'>"); foreach($height_array as $key => $height_value) { print("<option value='$key'>$height_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Your Weight?</b></label></td><td class='form_style' align='left'>"); print("<select name='weight'>"); foreach($weight_array as $key => $weight_value) { print("<option value='$key'>$weight_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Your Eye Colour?</b></label></td><td class='form_style' align='left'>"); print("<select name='eyes'>"); foreach($eyes_array as $key => $eyes_value) { print("<option value='$key'>$eyes_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Your Hair Colour?</b></label></td><td class='form_style' align='left'>"); print("<select name='hair'>"); foreach($hair_array as $key => $hair_value) { print("<option value='$key'>$hair_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Do You Have Children?</b></label></td><td class='form_style' align='left'>"); print("<select name='children'>"); foreach($children_array as $key => $children_value) { print("<option value='$key'>$children_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Your Marital Status?</b></label></td><td class='form_style' align='left'>"); print("<select name='marital_status'>"); foreach($marital_status_array as $key => $marital_status_value) { print("<option value='$key'>$marital_status_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>I'm Looking For A</b></label></td><td class='form_style' align='left'>"); print("<select name='seeking_gender'>"); foreach($seeking_gender_array as $key => $seeking_gender_value) { print("<option value='$key'>$seeking_gender_value</option>\n"); } print("</select>"); print("</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Profession:</b></label></td><td class='form_style' align='left'><input type='text' name='profession' class='textfield' size='40'></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td colspan='2' align='left'><h1>Your Interests</h1>(Optional, you can fill this in later.)</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><textarea name='interests' class='textfield' rows='20' cols='80'></textarea></td><td class='form_style' align='left' valign='top'><div id='tip'>Tell everyone all about your interests and hobbies.</div></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td colspan='2' align='left'><h1>Describe Yourself</h1>(Optional, you can fill this in later.)</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><textarea name='description' class='textfield' rows='20' cols='80'></textarea></td><td class='form_style' align='left' valign='top'><div id='tip'>Please include as much information as possible about yourself, you will recieve far more messages.</div></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td colspan='2' align='left'><h1>Upload An Image Of Yourself</h1></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Main Profile Image:</b></label></td><td class='form_style' align='left'><input type='file' name='image' size='40'> <span class='star'>*</span> Required.</td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td class='form_style' align='left'><label><b>Enter The CAPTCHA Numbers:</b></label></td><td class='form_style' align='left'><img src='captcha.php'></td>\n"); print("</tr>\n"); print("<tr>\n"); print("<td colspan='2' align='right'><input type='submit' name='submit' value='Join Up!' /></td>\n"); print("</tr>\n"); print("</table>\n"); print("</form>"); ?> cheers Graham Quote Link to comment Share on other sites More sharing options...
discomatt Posted March 16, 2008 Share Posted March 16, 2008 Try changing this if(isset($errors)) to this if(is_array($errors)) Quote Link to comment Share on other sites More sharing options...
thebadbad Posted March 16, 2008 Share Posted March 16, 2008 My guess is, that you're setting $errors somewhere, with $errors = array(); before any possible errors are added. So instead of using isset(), use empty(), as that will catch an empty array. Quote Link to comment Share on other sites More sharing options...
graham23s Posted March 16, 2008 Author Share Posted March 16, 2008 Hi Guys, changed it to empty that seems to be good, thanks mate Graham Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.