gotenxds

ok alllot agin for all your help, im seting it on now, and ya it did give me an error msg that helpd my solve it once and for all, agin thx alot.

ho thx alot, i did not know about that, and thx for the tip as well, but i fixed at as you said and set them all to mysqli, but for some reason i now get a "could not query database" error, i chacked and the db login data is correct. here is the "fixed" page thx alot for all the trouble your going trouge to help useless me XD <?php /* $UserName = $_POST['username']; $password = $_POST['password']; $password2 = $_POST['password2']; $Email = $_POST['Email']; $Gender = $_POST['Gender']; $Msn = $_POST['Msn']; $Skype = $_POST['Skype']; $Year = $_POST['Year']; $Month = $_POST['Month']; $Day = $_POST['Day']; $UserName = ""; $password = ""; $password2 =""; $Email = ""; $Gender = ""; $Msn = ""; $Skype = ""; $Year = ""; $Month = ""; $Day = ""; */ require_once('db_login.php'); $connection = mysqli_connect($db_host, $db_username, $db_password, $db_database) or die("error connecting to db". mysqli_error()); $error = ""; if(isset($_POST['submit'])){ //grabing info $UserName = mysqli_real_escape_string($connection, trim($_POST['username'])); $password = mysqli_real_escape_string($connection, trim($_POST['password'])); $password2 = mysqli_real_escape_string($connection, trim($_POST['password2'])); $Email = mysqli_real_escape_string($connection, trim($_POST['Email'])); $Gender = mysqli_real_escape_string($connection, trim($_POST['Gender'])); $Msn = mysqli_real_escape_string($connection, trim($_POST['Msn'])); $Skype = mysqli_real_escape_string($connection, trim($_POST['Skype'])); $Year = mysqli_real_escape_string($connection, trim($_POST['Year'])); $Month = mysqli_real_escape_string($connection, trim($_POST['Month'])); $Day = mysqli_real_escape_string($connection, trim($_POST['Day'])); if(!empty($UserName) && !empty($password) && !empty($password2) && ($password == $password2) ){ $query = "SELECT * FROM users WHERE UserName = '$UserName'" ; $data = mysqli_query($connection, $query); if(mysqli_num_rows($data) == 0){ $query_to_users = "INSERT INTO users VALUES (null,'$UserName','$password',now())"; $query_to_usersDetails = "INSERT INTO user_details VALUES (null,'$B_day','$Email','$Gender','$Msn','$Skype')"; $result = mysqli_query($connection, $query_to_users ); if (!$result){ die("could not query database <br />". mysqli_error()); } $result2 = mysqli_query($connection, $query_to_usersDetails); if (!$result2){ die("could not query database <br />". mysqli_error()); } echo " ok ok ok ok "; mysqli_close($connection); exit(); } else{ $error = "username is allredy taken";} } else {$error = "no username or password enterd";} } mysqli_close($connection); ?> השדות המסומנים ב '<span style="color:red;">*</span>' הינם חובה. <br /><br /> <div id="detailes"> <?php echo $error ;?> <form method="post" action="<?php echo $_SERVER['PHP_SELF'] ?>"> <label> שם משתמשם: <span style="color:red;">*</span> <input type="text" name="username" value="<?php $UserName ?>"/> </label> <br /> <label> סיסמה: <span style="color:red;">*</span> <input type="password" name="password" style="margin-right:45px;" /> </label> <br /> <label> ווידוי סיסמה: <span style="color:red;">*</span> <input type="password" name="password2" style="margin-right:13px;" /> </label> <br /> <label> מין: <input type="radio" name="Gender" value="male" style="margin-right:80px;" />זכר </label> <label> <input type="radio" name="Gender" value="female" style="margin-right:10px;" /> נקבה </label> <br /> <label> אימייל: <input type="Email" name="Email" value="<?php $Email ?>" style="margin-right:58px;" /> </label> <br /> תאריך לידה: <br /> <label>יום: <select name="Day" style="margin-right:80px;"> <option value='01'>01</option> <option value='02'>02</option> <option value='03'>03</option> <option value='04'>04</option> <option value='05'>05</option> <option value='06'>06</option> <option value='07'>07</option> <option value='08'>08</option> <option value='09'>09</option> <option value='10'>10</option> <option value='11'>11</option> <option value='12'>12</option> <option value='13'>13</option> <option value='14'>14</option> <option value='15'>15</option> <option value='16'>16</option> <option value='17'>17</option> <option value='18'>18</option> <option value='19'>19</option> <option value='20'>20</option> <option value='21'>21</option> <option value='22'>22</option> <option value='23'>23</option> <option value='24'>24</option> <option value='25'>25</option> <option value='26'>26</option> <option value='27'>27</option> <option value='28'>28</option> <option value='29'>29</option> <option value='30'>30</option> <option value='31'>31</option> </select> </label> <br /> <label>חודש: <select name="Month" value='' style="margin-right:64px;"> <option value='01'>ינואר</option> <option value='02'>פבואר</option> <option value='03'>מרץ</option> <option value='04'>אפריל</option> <option value='05'>מאי</option> <option value='06'>יוני</option> <option value='07'>יולי</option> <option value='08'>אוגוסט</option> <option value='09'>ספטמבר</option> <option value='10'>אוקטובר</option> <option value='11'>נובמבר</option> <option value='12'>דצמבר</option> </select> </label> <br /> <label>שנה: <select name="Year" style="margin-right:72px;"> <option value='2011'>2011</option> <option value='2010'>2010</option> <option value='2009'>2009</option> <option value='2008'>2008</option> <option value='2007'>2007</option> <option value='2006'>2006</option> <option value='2005'>2005</option> <option value='2004'>2004</option> <option value='2003'>2003</option> <option value='2002'>2002</option> <option value='2001'>2001</option> <option value='2000'>2000</option> <option value='1999'>1999</option> <option value='1998'>1998</option> <option value='1997'>1997</option> <option value='1996'>1996</option> <option value='1995'>1995</option> <option value='1994'>1994</option> <option value='1993'>1993</option> <option value='1992'>1992</option> <option value='1991'>1991</option> <option value='1990'>1990</option> <option value='1989'>1989</option> <option value='1988'>1988</option> <option value='1987'>1987</option> <option value='1986'>1986</option> <option value='1985'>1985</option> <option value='1984'>1984</option> <option value='1983'>1983</option> <option value='1982'>1982</option> <option value='1981'>1981</option> <option value='1980'>1980</option> <option value='1979'>1979</option> <option value='1978'>1978</option> <option value='1977'>1977</option> <option value='1976'>1976</option> <option value='1975'>1975</option> <option value='1974'>1974</option> <option value='1973'>1973</option> <option value='1972'>1972</option> <option value='1971'>1971</option> <option value='1970'>1970</option> <option value='1969'>1969</option> <option value='1968'>1968</option> <option value='1967'>1967</option> <option value='1966'>1966</option> <option value='1965'>1965</option> </select> </label> <br /> <label> סקייפ: <input type="text" name="Skype" value="<?php $Skype ?>" style="margin-right:62px;" /> </label> <br /> <label> מסנג'ר: <input type="text" name="Msn" value="<?php $Msn ?>" style="margin-right:53px;" /> </label> <br /> <label> <input type="submit" value="הרשם" name="submit" /> </label> </form> </div> </div>

i have a problom with this code i made for a register, i keep on geting the error "no username or password enterd" no matter what here is the page (most of it is the form so its not that long ) <?php require_once('db_login.php'); $connection = mysql_connect($db_host, $db_username, $db_password, $db_database) or die("error connecting to db". mysql_error()); $error = ""; if(isset($_POST['submit'])){ //grabing info $UserName = mysqli_real_escape_string($connection, trim($_POST['username'])); $password = mysqli_real_escape_string($connection, trim($_POST['password'])); $password2 = mysqli_real_escape_string($connection, trim($_POST['password2'])); $Email = mysqli_real_escape_string($connection, trim($_POST['Email'])); $Gender = mysqli_real_escape_string($connection, trim($_POST['Gender'])); $Msn = mysqli_real_escape_string($connection, trim($_POST['Msn'])); $Skype = mysqli_real_escape_string($connection, trim($_POST['Skype'])); $Year = mysqli_real_escape_string($connection, trim($_POST['Year'])); $Month = mysqli_real_escape_string($connection, trim($_POST['Month'])); $Day = mysqli_real_escape_string($connection, trim($_POST['Day'])); if(!empty($UserName) && !empty($password) && !empty($password2) && ($password == $password2) ){ $query = "SELECT * FROM users WHERE UserName = '$UserName'" ; $data = mysqli_query($connection, $query); if(mysqli_num_rows($data) == 0){ $query_to_users = "INSERT INTO users VALUES (null,'$UserName','$password',now())"; $query_to_usersDetails = "INSERT INTO user_details VALUES (null,'$B_day','$Email','$Gender','$Msn','$Skype')"; $result = mysql_query( $query_to_users ); if (!$result){ die("could not query database <br />". mysql_error()); } $result2 = mysql_query($query_to_usersDetails); if (!$result2){ die("could not query database <br />". mysql_error()); } echo " ok ok ok ok "; mysqli_close($connection); exit(); } else{ $error = "username is allredy taken";} } else {$error = "no username or password enterd";} } mysqli_close($connection); ?> השדות המסומנים ב '<span style="color:red;">*</span>' הינם חובה. <br /><br /> <div id="detailes"> <?php echo $error ;?> <form method="post" action="<?php echo $_SERVER['PHP_SELF'] ?>"> <label> שם משתמשם: <span style="color:red;">*</span> <input type="text" name="username" value="<?php $UserName ?>"/> </label> <br /> <label> סיסמה: <span style="color:red;">*</span> <input type="password" name="password" style="margin-right:45px;" /> </label> <br /> <label> ווידוי סיסמה: <span style="color:red;">*</span> <input type="password" name="password2" style="margin-right:13px;" /> </label> <br /> <label> מין: <input type="radio" name="Gender" value="male" style="margin-right:80px;" />זכר </label> <label> <input type="radio" name="Gender" value="female" style="margin-right:10px;" /> נקבה </label> <br /> <label> אימייל: <input type="Email" name="Email" value="<?php $Email ?>" style="margin-right:58px;" /> </label> <br /> תאריך לידה: <br /> <label>יום: <select name="Day" style="margin-right:80px;"> <option value='01'>01</option> <option value='02'>02</option> <option value='03'>03</option> <option value='04'>04</option> <option value='05'>05</option> <option value='06'>06</option> <option value='07'>07</option> <option value='08'>08</option> <option value='09'>09</option> <option value='10'>10</option> <option value='11'>11</option> <option value='12'>12</option> <option value='13'>13</option> <option value='14'>14</option> <option value='15'>15</option> <option value='16'>16</option> <option value='17'>17</option> <option value='18'>18</option> <option value='19'>19</option> <option value='20'>20</option> <option value='21'>21</option> <option value='22'>22</option> <option value='23'>23</option> <option value='24'>24</option> <option value='25'>25</option> <option value='26'>26</option> <option value='27'>27</option> <option value='28'>28</option> <option value='29'>29</option> <option value='30'>30</option> <option value='31'>31</option> </select> </label> <br /> <label>חודש: <select name="Month" value='' style="margin-right:64px;"> <option value='01'>ינואר</option> <option value='02'>פבואר</option> <option value='03'>מרץ</option> <option value='04'>אפריל</option> <option value='05'>מאי</option> <option value='06'>יוני</option> <option value='07'>יולי</option> <option value='08'>אוגוסט</option> <option value='09'>ספטמבר</option> <option value='10'>אוקטובר</option> <option value='11'>נובמבר</option> <option value='12'>דצמבר</option> </select> </label> <br /> <label>שנה: <select name="Year" style="margin-right:72px;"> <option value='2011'>2011</option> <option value='2010'>2010</option> <option value='2009'>2009</option> <option value='2008'>2008</option> <option value='2007'>2007</option> <option value='2006'>2006</option> <option value='2005'>2005</option> <option value='2004'>2004</option> <option value='2003'>2003</option> <option value='2002'>2002</option> <option value='2001'>2001</option> <option value='2000'>2000</option> <option value='1999'>1999</option> <option value='1998'>1998</option> <option value='1997'>1997</option> <option value='1996'>1996</option> <option value='1995'>1995</option> <option value='1994'>1994</option> <option value='1993'>1993</option> <option value='1992'>1992</option> <option value='1991'>1991</option> <option value='1990'>1990</option> <option value='1989'>1989</option> <option value='1988'>1988</option> <option value='1987'>1987</option> <option value='1986'>1986</option> <option value='1985'>1985</option> <option value='1984'>1984</option> <option value='1983'>1983</option> <option value='1982'>1982</option> <option value='1981'>1981</option> <option value='1980'>1980</option> <option value='1979'>1979</option> <option value='1978'>1978</option> <option value='1977'>1977</option> <option value='1976'>1976</option> <option value='1975'>1975</option> <option value='1974'>1974</option> <option value='1973'>1973</option> <option value='1972'>1972</option> <option value='1971'>1971</option> <option value='1970'>1970</option> <option value='1969'>1969</option> <option value='1968'>1968</option> <option value='1967'>1967</option> <option value='1966'>1966</option> <option value='1965'>1965</option> </select> </label> <br /> <label> סקייפ: <input type="text" name="Skype" value="<?php $Skype ?>" style="margin-right:62px;" /> </label> <br /> <label> מסנג'ר: <input type="text" name="Msn" value="<?php $Msn ?>" style="margin-right:53px;" /> </label> <br /> <label> <input type="submit" value="הרשם" name="submit" /> </label> </form> </div> </div>

is there a way in php to link from the root dir ? like in html you just use the '/' at the start for the link " <a herf="/link.php" ></a> " but i noticed this does not work when using php like include or require. so is there anywey to tell a link to start from root dir? without using the ../../link.php

it works ! thx alot for your help and i toke a look at this sites cookies and i understand what you mean, im new to php (about 2 weeks ) and i have alot to laern about security. thx agin.

the code that seting the cookies is $row = mysqli_fetch_array($data); setcookie('User_Id', $row['user_id'],time() +(60 * 60 * 1)); setcookie('UserName', $row['username'],time() +(60 * 60 * 1)); the code that displying the welcome and log in is a if else statment, and i know that the cookies are not being deleted bcus i chack in firefox "delete coockies by site " option and after delete them via firefox i get the plz plgin msg here is the intire login page (some stuff maybe in hebrew plz ignore): <?php require_once('db_login.php'); //the error massged $Login_error = "" ; //chacck if looged in, else check if trying to login if (!isset($_COOKIE['User_Id'])){ if (isset($_POST['submit'])){ //connect to db $connection = mysqli_connect($db_host, $db_username, $db_password, $db_database) or die ('damn'); //grabing user enterd details $user_username = mysqli_real_escape_string($connection, trim($_POST['UserName'])); $user_password = mysqli_real_escape_string($connection, trim($_POST['password'])); if (!empty($user_username) && !empty($user_password)){ $query = "SELECT username, user_id FROM users WHERE username = '$user_username' AND ". "password = '$user_password'"; $data = mysqli_query($connection, $query); echo mysqli_num_rows($data); if(mysqli_num_rows($data) == 1){ $Login_error ="yay"; //user name and pass are ok $LoginDate = date('j\.n\.Y \בשעה H\:i') ; $row = mysqli_fetch_array($data); setcookie('User_Id', $row['user_id'],time() +(60 * 60 * 1)); setcookie('UserName', $row['username'],time() +(60 * 60 * 1)); $home_url = 'http://' .$_SERVER['HTTP_HOST'] . '/index.php'; header('Location: ' . $home_url) ; } else{ //worng username AND\OR password $Login_error ="שם המשתמש או הסיסמא לא נכונים"; } } else{ //no username and'or password were enterd $Login_error = "לא הכנסת שם משתמש וסיסמה"; } } } ?> <?php //if the cookie is empty show errormsg and form if(empty($_COOKIE['User_Id'])) { echo $Login_error ; ?> <script type="text/javascript" > $(document).ready(function () { $("#login").ready(function () { $("#login").slideDown('slow'); }); }); </script> <div id="login" style="background-color:#09C;border:1px solid; width:100%; height:25px; display:none; margin-bottom:5px;"> לא חבר באתר? <a href="/Register.php"><span style="color:#9C3; font-style:oblique;">הרשם</span></a> עכשיו! <form style="float:right" method="post" action="<?php echo $_SERVER['PHP_SELF'] ?>"> <label> שם משתמש: <input type="text" id="UserName" name="UserName"/> </label> <label> סיסמה: <input type="password" id="password" name="password"/> </label> <input type="submit" name="submit" value="התחבר" /> </form> </div> <?php } else{ ?> <script type="text/javascript" > $(document).ready(function () { $("#login").ready(function () { $("#login").slideDown('slow'); }); }); </script> <div id="login" style="background-color:#09C;border:1px solid; width:100%; height:25px; display:none; margin-bottom:5px;"> שלום <?php echo $_COOKIE['UserName']; ?> התחברתה לאחרונה ב לחץ <a href="Core/LogOut.php">כאן</a> על מנת להיתנתק </div> <?php }?> and the intire logout page: <?php if (isset($_COOKIE['User_Id'])){ setcookie('User_Id', "" ,time()-3600); setcookie('UserName', "" ,time()-3600); } $home_url = 'http://' .$_SERVER['HTTP_HOST'] . '/index.php'; header('Location: ' . $home_url) ; ?>

allready tried thay, hed a $home_url = 'http://' .$_SERVER['HTTP_HOST'] . '/index.php'; header('Location: ' . $home_url) ; in the same page and my index chacks to see wheter a cookie is in place if not it asks to log in if yes is says 'wellcome "username" ' and i get the wellcome msg

hya, ive given a link from my index page to a pgave i call logout.php in that page i have the following code: <?php if (isset($_COOKIE['User_Id'])){ setcookie('User_Id', "" ,time()-3600); setcookie('UserName', "" ,time()-3600); echo "cookies has been deleted"; } else {echo 'you are not loged in' ;} ?> i get the 'echo "cookies has been deleted";' msg but the cookies are not dellted, any ides ?

Soory used the 'm' tag by accident

hallo i cant seem to find whats worng with this login file i made that i include in my index page i keep on geting the "sorry, please enter your username and password to login" error while trying to log in with a valid username and password. <?php require_once('db_login.php'); //the error massged $Login_error = "" ; //chacck if looged in, else check if trying to login if (!isset($_COOKIE['User_Id'])){ if (isset($_POST['submit'])){ //connect to db $connection = mysql_connect($db_host, $db_username, $db_password); //grabing user enterd details $user_username = mysqli_real_escape_string($connection, trim($_POST['UserName'])); $user_password = mysqli_real_escape_string($connection, trim($_POST['password'])); if (!empty($user_username) && !empty($user_password)){ $query = "SELECT User_Id, UserName FROM users WHERE UserName = '$user_username' AND ". "password = '$user_password'"; $data = mysqli_query($connection, $query); if(mysqli_num_rows($data) == 1){ //user name and pass are ok setcookie('User_Id', $row['User_Id']); setcookie('password', $row['password']); $home_url = 'http://' .$_SERVER['HTTP_HOST']. dirname($_SERVER['PHP_SELF']) . '/index.php'; header('Location: ' . $home_url) ; } else{ //worng username AND\OR password $Login_error ="the username or password are incorrect"; } } else{ //no username and'or password were enterd $Login_error = "sorry, plz enter your username and password to login"; } } } ?> <?php //if the cookie is empty show errormsg and form if(empty($_COOKIE['User_Id'])) { echo $Login_error ; ; ?> <script type="text/javascript" > $(document).ready(function () { $("#login").ready(function () { $("#login").slideDown('slow'); }); }); </script> <div id="login" style="background-color:#09C;border:1px solid; width:100%; height:25px; display:none; margin-bottom:5px;"> לא חבר באתר? <a href="/Register.php"><span style="color:#9C3; font-style:oblique;">הרשם</span></a> עכשיו! <form style="float:right" method="post" action="<?php echo $_SERVER['PHP_SELF'] ?>"> <label> שם משתמש: <input type="text" id="UserName" name="UserName"/> </label> <label> סיסמה: <input type="password" id="password" name="password"/> </label> <input type="submit" name="submit" value="התחבר" /> </form> </div> <?php } else{ ?> <div id="login" style="background-color:#09C;border:1px solid; width:100%; height:25px; display:none; margin-bottom:5px;"> שלום <?php echo $_COOKIE['UserName']; ?> </div> <?php }?> thanks in advance