razorsese

Currently on my page all my important script is done in 1 page; I was thinking to break it in multiple php files So my question is does multiple requires slow down the PHP script?!

Ok thanks

I look for that !Thanks Does displaying data in my URL represent a security hole?!

It is possible to hide the data in the url?! I have something like this: ?action=viewArticle&articleid=1

if(!isset($_POST['form'])) it if( !isset($_COOKIE['form']))

No error appear

Sorry for my late relply; Well if i change the isset and whit a cookie active the form isn't appearing Actually in the 'comment.php' is the form needed to display if( isset($_POST['form'])) { addcomment($result['article']->id,$_POST);//addcoment on the page whit the current id } The 'comment.php' code: <form id="commentform" method='post' action="index.php?action=viewArticle&articleid=<?php echo $cpageid;?>" > <input type="hidden" name="id" class='cid' value="<?php echo $cpageid;?>"/> <p> <input type="text" name="usern" class='usern' maxlenght='40'/> <label for="usern">Username</label> </p> <p> <textarea name="com" class='com' COLS=40 ROWS=6></textarea> <label for="com">Comment</label> </p> <input type="hidden" name="page" class='page' value="<?php echo $cpageid;?>" /> <p> <input type="submit" name="submit" class='submit' value="Submit" /> </p> </form>

I got a weird problem; I got a form whit 2 fields and a submit button; When i click the submit button a jquery ajax script create a cookie named form; My problem is the form isn't disappearing when i click the submit(javascript is set to reload location) button even when i try to delete the cookie from the browser; on index: function addcomment($pass , $pst)//add comment and call form { $cpageid = $pass; $comment = new Comment; $comment->storeFormValues($pst); $comment->insertc(); require('comment.php'); } on the page where the form is called: <div id="commentbox" class="container_24"> <?php if(!isset($_POST['form'])) { addcomment($result['article']->id,$_POST);//addcoment on the page whit the current id } ?> </div>

Thanks for the tips. I will definitely to follow them

Yep But I didn't know of ctype_digit until now

Thanks xyph. Works like a charm Yep

Still not working Also if i try to select all comments and use var_dump like in the below code appear Notice: Undefined offset: 7 on: ($id[] = $_POST[$k+1]; ) array 0 => string '1' (length=1) 1 => string '1' (length=1) 2 => string '1' (length=1) 3 => string '1' (length=1) 4 => string '1' (length=1) 5 => null if(isset($_POST['submit'])) { foreach ($_POST as $k => $v){ if($v == '1'){ $id[] = $_POST[$k+1]; } } var_dump($id); }

Using whit none comment selected to delete foreach ($_POST as $k => $v){ echo $k."~".$v."<br>"; } output: submit~submit 1~0 h1~57/ 2~0 h2~56/ 3~0 h3~52/ 4~0 h4~51/ 5~0 h5~47/ 6~0 h6~46/ and var_dump($_POST); array 'submit' => string 'submit' (length=6) 1 => string '0' (length=1) 'h1' => string '57/' (length=3) 2 => string '0' (length=1) 'h2' => string '56/' (length=3) 3 => string '0' (length=1) 'h3' => string '52/' (length=3) 4 => string '0' (length=1) 'h4' => string '51/' (length=3) 5 => string '0' (length=1) 'h5' => string '47/' (length=3) 6 => string '0' (length=1) 'h6' => string '46/' (length=3)

My var_dump whit 2 selected comments to delete : array 1 => string '57/' (length=3) 2 => string '56/' (length=3) your's: var_dump($id); array 0 => int 1 1 => int 2

Var dump look like this: array 'submit' => string 'submit' (length=6) 1 => string '0' (length=1) 'h1' => string '57/' (length=3) 2 => string '0' (length=1) 'h2' => string '56/' (length=3) 3 => string '0' (length=1) 'h3' => string '52/' (length=3) 4 => string '0' (length=1) 'h4' => string '51/' (length=3) 5 => string '0' (length=1) 'h5' => string '47/' (length=3) 6 => string '0' (length=1) 'h6' => string '46/' (length=3)

My code works perfect for the job needed to be done But I feel is very sloppy Is there any chance to optimize it?! It's getting from a post all comment's id and variable 0 or 1 depending on input and then assign the ids whit value 1 to another variable then delete the comment whit the specific id; Initially all ids have the value 0; $id = array(); $ids = array(); if(isset($_POST['submit'])) { $data = array(); $data = $_POST; $i=0; foreach($data as $key=>$value) { $id[$i]=$value; $i++; } $j=0; for($d= 1; $d<$i;$d++) { if($id[$d] == 1) { $j++; $ids[$j] = $id[$d+1]; } } $ctx= new Comment; for($i=1;$i<=$j;$i++) { $ctx->commentdelete($ids[$i]); } header('Location:admin.php'); }

Thank you very much:)

Whit my code it only appear a list of 1 or 0 and the id but I don't know how to get to show only the id Like so: submit 0 60/ 0 59/ 0 58/ 0 57/ 0 56/ 0 45/ 0 38/ 1 37/ on my first page: <table border="2"> <tr> <th>Id</th> <th>User</th> <th>Comment</th> <th>Yes</th> <th>No</th> </tr> <form method="post" action="admincommentdelete.php" id="formc"> <?php $vv = array(); $st = Comment::test($result['article']->id,0,999); $vv['comment'] = $st['comment']; $i = 0; foreach($vv['comment'] as $p) { $i++; echo "<tr>"; echo "<td>".$p->id."</td>"; echo "<td>".$p->usern."</td>"; echo "<td>".$p->com."</td>"; echo "<td><input name=$i type=radio value='1'/></td>"; echo "<td><input name=$i type=radio value='0'/></td>"; echo "<input type=hidden name=h".$i." value=$p->id/>"; echo "</tr>"; } ?> <input type="submit" value="submit" name="submit"> </form> </table> second: <?php $id = array(); if(isset($_POST['submit'])) { $data = array(); $data = $_POST; foreach($data as $key) { echo $key."</br>"; } } ?>

I was wondering if i can create tables for every article my website have to store the user allowed comments to vote; Is there any limit for how many table a database can have?! And this is a viable solution?!

Thanks for the fast respone !!!! ))) Problem solved

I have a problem whit a php code Every time I click a link the page url is continuing to accumulate like here: ?action=viewArticle&articleid=7&page=1&page=1&page=1&page=3&page=3&page=2&page=3 the "&page=" is continuing to add but I want to display a single &page How I can do that?! echo "<a href= ' ".$_SERVER['REQUEST_URI']."&page=$v ' >$v</a>";

Well I drop the idea whit ip adress and switching to the user idea; I'm gonna try whit cookies but I was wondering if I could use a database to limit user vote For example let's say page 1 has : 1 main vote for article :45 comments to vote So every time user vote for one comment the column from database decrease by 1 and when it hit 0 it will not allow anymore vote just for double security But I think it might be a bad idea in practice

I have a page whit an article vote button and some comments each whit they're vote button How i can create a database to restrict an ip adress to vote twice on article and to vote twice on all comments?

So I'm trying to make a comment system so I was wondering It is good to reset the id per page ?! For example id :1 page :1 id:2 page:1 id:1 page:2 id:2 page:2 And so on.. And how I deal whit the duplicate ones!? Should I normalize the database?! (Note:I'm beginner whit database design)

Thank you very much