[SOLVED] Cookies Drivimg Me Crazzzzzy!

[steviez]

Hi,

 

I need my users to be logged in to access some pages on my site, So i have made this simple code to do it:

 

<?php
function loggedin() {
    if(!isset($_COOKIE['loggedin']))
    {
    header("location: $secure_url/login.php");
    }
?>

 

But it will not work, I am using PHP5 so im not sure if thats a problem. Please can someone help!

[kenrbnsn]

What do you mean by "it will not work". Please explain your problem better. Do you get any errors?

 

Ken

[craygo]

first off it won't work cause your function does not know $secure_url. You would have to pass the variable to the function or make it global

 

pass it

function loggedin($secure_url) {
    if(!isset($_COOKIE['loggedin']))
    {
    header("location: $secure_url/login.php");
    }
}

loggedin("https://mysiite.com");

 

Or use global

function loggedin() {
global $secure_url;
    if(!isset($_COOKIE['loggedin']))
    {
    header("location: $secure_url/login.php");
    }
}

 

Ray

 

 

[steviez]

Thanks for your help so far, the problem is that it is acting as thought the cookie is set... in other words it is not redirecting the user to the login page even though there is no cookie set.

[benphp]

Or try pulling the code out of the function and getting it to work on a page. Then put it back in a function once you get it working.

 

It won't redirect visitors if it doesn't know where to redirect them. You need to define $secure_url

[craygo]

Have you tried from other machines. I have seen cookie stay set forever. Maybe in your code somewhere you should make sure your named cookie is unset before you set it again. can you post code on how you are setting the cookie

 

Ray

 

[steviez]

even if i take the code out of the function and place it at the top of my page it still just gives access to it.

[craygo]

instead of isset maybe you should check the value.

if(!isset($_COOKIE['loggedin']) || $_COOKIE['loggedin'] IS NULL || $_COOKIE['loggedin'] == " ")

 

have you tried to echo the cookie and see what it is set at so you can compare it??

 

Ray

[steviez]

something even more strange is that if i do this:

 

<?php
function loggedin() {
    if(!isset($_COOKIE['loggedin']))
    {
    print("You are not logged in");
    #header("location: $secure_url/login.php");
    }
?>

 

It works and prints it out for all that are not logged in.

[craygo]

Do you have your errors suppressed?? Cause if you are outputting anything to the browser first, even just a tag, header will not work and will not error if you have them suppressed.

 

Ray

[steviez]

Thanks for everyones help, i have solved it by putting the code at the top of each page before the header