[SOLVED] having trouble pulling multiple rows from a db

[Kane250]

I have a database where I want to pull email addresses from one column, and I want it to display every one separated by commas, so I can insert it for email.

 

My code is incomplete I'm sure..I'm new to MySQL, and hung up on how I have to pull these from the table.

 

$connectsql = mysql_connect('localhost', 'user', 'pw') 
or die("Unable to connect to MySQL");
print "Connected to MySQL<br>";

$db_selected = mysql_select_db('user', $connectsql);

//Call Saved Email contacts to the email
$mlistcontacts = mysql_query('SELECT email FROM emaillist WHERE emailID>0');
$mlistcontacts = mysql_fetch_array ($mlistcontacts);
print $mlistcontacts['email'];

 

When I print this out it just displays the first email address in the table (first row).

 

Thanks in advance for any insight!

[fenway]

Well, you can push then onto an array in php and join them with commas, or you can use group_concat.

[fenway]

Well, you can push then onto an array in php and join them with commas, or you can use group_concat.

[Kane250]

Well aren't I already putting them into an array? That's what I was trying to do, but I also need to be able to call every one in the list. The list will be updated regularly, so some code that would add all emails with an ID>0 into a string seperated by commas is exactly what I need...

[mdnghtblue]

Not sure if this is the most efficient way, but this is how I'd do it:

 

 

$mlistcontacts = mysql_query('SELECT email FROM emaillist WHERE emailID>0');
while($mlistcontacts = mysql_fetch_array ($mlistcontacts))
{
$contacts[$i] = $mlistcontacts[email];
$i++;
}

echo implode(",", $contacts);

[fenway]

Well aren't I already putting them into an array?

 

No, you're not... that not's what fetch_array() does.

[mendoz]

Try this:

 

<?php


// Get the results from the database
$mlistcontacts = mysql_query('SELECT email FROM emaillist WHERE emailID>0');
// You want an associative array, not a numeric, so we'll use mysql_fetch_assoc
while($mlistcontacts = mysql_fetch_assoc ($mlistcontacts))
{
   // You forgot the single quotes around email
   $contacts[$i] = $mlistcontacts['email'];
   $i++;
}

echo implode(",", $contacts);



?>

[Kane250]

Thanks guys but neither worked. They both return just the first email address...  :-\

[Hooker]

Can i ask why you have the WHERE clause? is emailID auto inc or are you just using it as a boolen? because if its auto inc you're checking what exactly?

 

Honestly i've seen mysql get bitchy about less in my time so its worth a try removing it if it is auto inc.

[Kane250]

Can i ask why you have the WHERE clause? is emailID auto inc or are you just using it as a boolen? because if its auto inc you're checking what exactly?

 

Honestly i've seen mysql get bitchy about less in my time so its worth a try removing it if it is auto inc.

 

 

I'm using the WHERE clause becase I want it to pull every entry. Yes it is auto incrementing. Are you saying that I don't need the where clause?

[corbo950]

I'm using the WHERE clause becase I want it to pull every entry. Yes it is auto incrementing. Are you saying that I don't need the where clause?

 

The WHERE clause if for when you dont want to return all of the rows like if you only wanted to return people with a certain value in the table so if you want all of the values you dont want a WHERE clause

[fenway]

Thanks guys but neither worked. They both return just the first email address...  :-\

That's not possible... echo the value of the counter variable, if it's more than one, then there's something else going on.

[Kane250]

Thanks guys but neither worked. They both return just the first email address...  :-\

That's not possible... echo the value of the counter variable, if it's more than one, then there's something else going on.

 

If the counter variable is $i, which I think it is, then no, it only returns 1, nothing more...

[Kane250]

Is it a problem that I have 3 columns? One email, one first name, and one last name. Could that be stopping it somehow?

[fenway]

If the counter variable is $i, which I think it is, then no, it only returns 1, nothing more...

If that's true, then there is only one e-mailID that satifies your WHERE clause.  Drop the WHERE clause, see what happens.  It's not MySQL, it's the data.

[Kane250]

If the counter variable is $i, which I think it is, then no, it only returns 1, nothing more...

If that's true, then there is only one e-mailID that satifies your WHERE clause.  Drop the WHERE clause, see what happens.  It's not MySQL, it's the data.

 

No, even without the where clause, it does the same thing. The counter also only prints 1 as well. Here is my table data, I don't see what's wrong with it?

 

<img src="http://a.parsons.edu/~kalbarron/table.jpg">

[fenway]

Then either you're not connecting to the right DB, or your code isn't iterating over the rows (your initial code didn't)... but I've been assuming you've followed other suggestions.

 

Post your code.

[Kane250]

Then either you're not connecting to the right DB, or your code isn't iterating over the rows (your initial code didn't)... but I've been assuming you've followed other suggestions.

 

Post your code.

 

I used code that was previously suggested in this topic...it has to be connecting to the database correctly because it pulls one email address out of it, the first row.

 

Thanks for all your help!

 

<?php

//Connect to the database

$connectsql = mysql_connect('localhost', 'user', 'password') 
or die("Unable to connect to MySQL");
print "Connected to MySQL<br>";

$db_selected = mysql_select_db('database', $connectsql);

// Get the results from the database
$mlistcontacts = mysql_query('SELECT email FROM emaillist');

// You want an associative array, not a numeric, so we'll use mysql_fetch_assoc
while($mlistcontacts = mysql_fetch_assoc ($mlistcontacts))
{
   // You forgot the single quotes around email
   $contacts[$i] = $mlistcontacts['email'];
   $i++;
}

echo implode(",", $contacts);

print $i;

$to      = $_POST['to'];
$subject = $_POST['subject'];
$message = stripslashes ($_POST['msgpost']);


print "<pre>";
if ($_POST) {
mail($to, $subject, $message, "From: $from\nContent-Type: text/html; charset=iso-8859-1");
}
print "</pre>";
?>

[Kane250]

bump for hopefully more help  ???

[fenway]

What does mysql_num_rows() have to say?

No error messages?

[Kane250]

What does mysql_num_rows() have to say?

No error messages?

 

mysql_num_rows($contacts) doesn't print out anything actually... blank

[Kane250]

Fixed (sorta)

 

This:

// Get the results from the database
$mlistcontacts = mysql_query('SELECT email FROM emaillist');

while($mlistcontacts2 = mysql_fetch_assoc($mlistcontacts)){
$massmail = implode ($mlistcontacts2);
print ($massmail);
}

 

Returns each row, but now I'm having issues adding in the commas. I tried adding it in in both the print statement and the implode, and neither are doing it.. If I use mysql_fetch_array it will add the commas, but it will also print each row twice, and it will not have the comma the second time.

 

Ex: email@email.com, email@email.comanotheremail@email.com, anotheremail@email.comnewemail@email.com etc...

[Kane250]

All cleared up. Final Code:

 

<?php// Get the results from the database
$mlistcontacts = mysql_query('SELECT email FROM emaillist');

while($mlistcontacts2 = mysql_fetch_assoc($mlistcontacts)){
$massmail[] = $mlistcontacts2['email'];
}
print implode(",", $massmail);?>

 

Thanks for everyone's help!