[SOLVED] PHP - Mysql Help Please

[paulman888888]

How do i make the players column go up 1, on row $_GET['gameid']?

 

I have this so far

<?php
//i have my connection
$thegameid=$_GET['gameid'];
mysql_query("UPDATE players WHERE id='$thegameid' SET players = players + 1");
?>

 

Thankyou

Paul

[Barand]

mysql_query("UPDATE players SET players = players + 1 WHERE id='$thegameid'");

[br0ken]

Your query is almost right, just ordered wrong. Also, some validation of the input is required. Try this...

 

$thegameid = number_format($_GET['gameid'], 0, "", ""); // Format input as a number
mysql_query("UPDATE players SET players = players + 1 WHERE id= $thegameid");

[jelly]

 

<?php

     $thegameid = (int)$_GET['gameid']; // id MUST be an integer value
     
?>

 

:-)

[br0ken]

 

<?php

     $thegameid = (int)$_GET['gameid']; // id MUST be an integer value
     
?>

 

:-)

 

Sorry to digress but if the value passed wasn't an int, would this return 0? I've always wondered that about typecasting.

[jelly]

<?php

if ($thegameid = (int)$_GET['gameid'])
{
        	mysql_query("UPDATE players SET players = players + 1 WHERE id= $thegameid");
	}
else
{
               echo ('error'); 
}
?>

 

If the value isn't int that will return 0.

If $_GET['game'] = '123abc' that will return $thegameid = 123.

 

--

jelly.

[br0ken]

So in a way it's better than using number_format because that will only return a value greather than zero if the whole value is a true integer where as typecasting will remove the slightest bit of a number. Thanks Jelly!