php if statement

[talor123]

hey, i have no idea whats rong with my code... what meants to happen is if a user submits the rong user/password to login.php.. it will send back what the variable 'message' is equal to.. (eg: message=1) which will then be turned into the necessary image like so... if($number == "1") {$img = "invaild.png";}.. then that image will be used as a table row background on the login form... so the user knows what they have done rong.

 

heres my code..

 

<?

if(isset($_GET["message"])) {

$number = $_GET["message"];
if($number == "1"){$img = "invalid.png";}
elseif($number == "3"){$img = "details.png";}


$bg = "<tr style='background-image:url($img);'></tr>";
}
?>

<table class="tableclose" cellpadding="0" cellspacing="0" id="logtable">
<form action="login.php" method="post">
<tr style="background-color:43BF4F;"><td>Login</td></tr>
<?=$bg?>
<tr><td>Username:</td><td><input type="text" name="user"></td></tr>
<tr><td>Password:</td><td><input type="password" name="password"></td></tr>
<tr><td></td><td><input type="submit" value="Login"></td></tr>
</table>

 

thanks in advance

[DeanWhitehouse]

so whats the question?

[talor123]

sorry if i wasnt clear, the question is why is my code not doing what it meants to be doing(what i explained at first)

[DeanWhitehouse]

yes, but are there any errors, what isn't it doing, not setting the background?

 

[talor123]

yea.. its not setting the background for the table row

[sader]

first try to echo your $bg value

<? echo $bg; ?>

 

second I think you should include and <td> tags in your string

$bg = "<tr style='background-image:url($img); height:24px;'><td colspan=2></td></tr>";

[.josh]

Where is your code that passes "message" via the GET method? And on that note, why are you even using the GET method like this? It doesn't look like anybody could do any real harm by changing the value of "message" here, but still... you should be passing data through a session var.  But regardless, where is your code that passes your 1 or 3 to this script?

[teynon]

Wow, you guys are overcomplicating a simple HTML issue heh...

 

The TR you are making is simply that. A row. So the image will show up in that row only, which is empty. So, you need to set that image to the table background.

 

Example: $bg=" style='background-image:url($img);'";

 

<table<?=$bg;?>>