PHP Simple

[phaedo5]

Ok, this sort of seems simple, but it's giving me difficulty.

 

I have a statement like this:

 

if(preg_match('/whatever/', gethostbyaddr($_SERVER['REMOTE_ADDR'])) {

    $variable = true;

}

 

if(!$variable) {

  then do something

}

 

Is this not acceptable code?  It seems to work, sometimes.  Every once in a while a domain of 'whatver.com' will slip through and trigger my if statement.  It seems to work quite a bit though.  So I'm confused. 

 

I just want to know if I'm doing something that is 'not best practice' or if I'm even completely wrong. 

Any help would be great. 

Sorry it's sort of newb material.

 

 

[JasonLewis]

Define $variable before hand.

 

$variable = false;

if(preg_match('/whatever/', gethostbyaddr($_SERVER['REMOTE_ADDR'])) {
    $variable = true;
}

if(!$variable) {
   then do something
}