T_BOOLEAN_OR error

[T_Hayden]

I am writing a validation for a simple form with validation. It takes the information and sends it to the validation page which either emails it or sends it back. I am getting an error after submitting the form.

Parse error: parse error, unexpected T_BOOLEAN_OR in /home/www/baptistsermonhost/test/collegeform/collegeform.php on line 23

Here is Line 23
[code] if (empty($formVars['firstname'])) || (empty($formVars['lastname'])) || (empty($formVars['age'])) || (empty($formVars['line1'])) || (empty($formVars['city'])) || (empty($formVars['state'])) || (empty($formVars['areacode'])) || (empty($formVars['firstnumber'])) || (empty($formVars['secondnumber'])) {[/code]

[.josh]

you are missing the closing ) for the whole thing

[poirot]

No, actually this error happens because he/she missed the first parenthesis.
When it's added it, another error pops:

[!--quoteo--][div class=\'quotetop\']QUOTE[/div][div class=\'quotemain\'][!--quotec--]Parse error: parse error, unexpected '{' [/quote]
Then he/she can close the whole thing [img src=\"style_emoticons/[#EMO_DIR#]/laugh.gif\" style=\"vertical-align:middle\" emoid=\":laugh:\" border=\"0\" alt=\"laugh.gif\" /].

Anyway, you don't need to use (empty($var)) || (empty($var2))... empty($var) || empty($var2) is enough.

[code]if (empty($formVars['firstname']) || empty($formVars['lastname']) || empty($formVars['age']) || empty($formVars['line1']) || empty($formVars['city']) || empty($formVars['state']) || empty($formVars['areacode']) || empty($formVars['firstnumber']) || empty($formVars['secondnumber']))[/code]

[.josh]

okay so i missed the first one too. he needs to add ( ) around the whole darn thing.

[kenrbnsn]

I would advise against using "if (empty($fld))" to determine if something was entered into a field. If someone enters a zero, "0", in a field, the emtpy() function will return "true".

Here's how I would do this:
[code]<?php
$err = false;
foreach($_POST as $key=>$val)
    if (strlen(trim(stripslashes($val))) == 0) $err = true;
if ($err) echo "One of the fields was left blank";
?>[/code]

You could get slightly fancier:
[code]<?php
$err = array();
foreach($_POST as $key=>$val)
    if (strlen(trim(stripslashes($val))) == 0) $err[] = $key;
if (!empty($err)) echo 'The following fields were left blank: ' . implode(', ',$err);
?>[/code]

Ken

[.josh]

or you could simply do like

if ( !$formVars['age'] || !$formVars['name'] || ...) { .. }

[poirot]

Crayon, if you use that you will still have problems like

0 is false
" " (whitespace) is true

Refer to this table:
[a href=\"http://www.php.net/manual/en/types.comparisons.php\" target=\"_blank\"]http://www.php.net/manual/en/types.comparisons.php[/a]

I think ken's suggestion is appropriate.

[.josh]

okay so i'll just shut up now :\