Please review my website

[lovelycesar]

I created a website with some little knowledges of PHP, called http://www.autodetectip.com. Now, I suppose that it would be nice or not, and that it would be useful or not. Please make me a critique about it, also an advise! Thanks.

[xstevey_bx]

Commenting on the design only its a bit boring

Some simple graphics bordering the image would be cool I guess, like a graphical 'frame'.

 

You could say the design is very practical too as it doesnt require alot of bandwidth.

Times New roman is a boring font though But I suppose its cause im a fan of arial

 

 

[ardyandkari]

i second xstevey_bx's post about the design...

 

as to usefulness...what would someone do with this information?  if you were just expanding your knowledge of php and retrieving info about a user, great...otherwise i would implement this page/script with something that might be useful or even fun...

 

hmmmm, log in...after logging in it will capture the ip address of the user and put into db...the user with the most ip addresses in his record wins!!! (this would require a lot of traveling, but might be fun...could make some money too if it took off.)

 

 

[xstevey_bx]

ardyandkari that sounds like a really good idea for a little web site!

[ardyandkari]

do it...just remember that i came up with it and pay me many many american dollars...

[tibberous]

Sometimes it's nice to know your IP.

 

C+

[lovelycesar]

I am very pleasant when having your opinions here. In a short upcoming time, I will do like you recommend.

 

Thank all of you.

[proggR]

Kudos on being open source

[lovelycesar]

Commenting on the design only its a bit boring

Some simple graphics bordering the image would be cool I guess, like a graphical 'frame'.

 

You could say the design is very practical too as it doesnt require alot of bandwidth.

Times New roman is a boring font though But I suppose its cause im a fan of arial

 

 

i second xstevey_bx's post about the design...

 

as to usefulness...what would someone do with this information?  if you were just expanding your knowledge of php and retrieving info about a user, great...otherwise i would implement this page/script with something that might be useful or even fun...

 

hmmmm, log in...after logging in it will capture the ip address of the user and put into db...the user with the most ip addresses in his record wins!!! (this would require a lot of traveling, but might be fun...could make some money too if it took off.)

 

 

 

Thank you, I re-designed (http://www.autodetectip.com) it a little as you suggested.

Now I think that it's a bit better.

[nrg_alpha]

It's certainly better looking.. but when viewed in Opera 9.51 or IE 7, the google ad is centered, while everything else is flush left against the edge of the screen. I'm not sure what css rules you are using to center your divs, but I use:

 

.whateverDivNameHere {margin: 0 auto;} // or change the 0 to something else if you want to add some space to the website's top.

Perhaps having one master div that contains everything and auto-margining that?

 

In either case, I would test your site in multiple browsers.. if your site doesn't behave properly across all the major up-to-date browsers, then this means that there is some problems in the code (not necessarily from a validation standpoint, but from a structure standpoint).

 

Other than that, it is looking better for sure 

 

Cheers,

 

NRG

 

P.S I changed Opera's default background colour, and I can see it in the webpage (after all the content). You might want to put a CSS rule that establishes a black background for the whole site:

 

css:

body {background-color: #000000;}

 

This way, no matter what colour the user has set his / her web browser to, your site will still display properly.

[lovelycesar]

when viewed in Opera 9.51 or IE 7, the google ad is centered, while everything else is flush left against the edge of the screen.

--

P.S I changed Opera's default background colour, and I can see it in the webpage (after all the content). You might want to put a CSS rule that establishes a black background for the whole site:

 

css:

body {background-color: #000000;}

 

This way, no matter what colour the user has set his / her web browser to, your site will still display properly.

 

Great comments!

Thank you so much. Really I have not yet tested under various types of browsers.

I corrected some css defs. It seems that's fine under IE7 and Firefox 3.x

Can you review one more time?

[nrg_alpha]

The centering now looks correct in IE 7 and Firefox.. but if I change Firefox's background color to black, your site's background is black.

(you can test this by opening a new tab, and typing in 'about:config' as the url. This will bring you to a list of things you can change.. in the 'Filter' field, you can type in 'color', and only elements that involve color will show up. Double-click 'Browser.display.background_color' and change '#ffffff' to '#000000'. Then you will see the background of your site changes.

 

I'm not sure if you care if your site displays correctly in Opera or Safari.. (everything is now left [ except for the title 'Auto Detect Ip Adress' in the main window, and the footer..those are centered])

 

If you don't have those browsers, and want your site to display correctly in them, I suggest you download and install them, then test them.

 

Hope that helped.

 

Cheers,

 

NRG

[lovelycesar]

.. but if I change Firefox's background color to black, your site's background is black

 

I'm not sure if you care if your site displays correctly in Opera or Safari.. (everything is now left [ except for the title 'Auto Detect Ip Adress' in the main window, and the footer..those are centered])

 

NRG

 

Yes, thanks for reviewing site under various browsers.

- I defined the background, now it is #FFFFFF even though your settings in Firefox

- I added in the container div as { margin-left: auto; margin-right: auto;}, then the centered div shows as expected; I downloaded Opera & Safari for Win, div's now correctly centered.

Can you advise me why the menu, in IE7 I cannot click on an image to open link, but I can do it in FF3?

[nrg_alpha]

much better  It is all centered.

As for the links as images not working.. I'm not sure.. but a few things...

 

<li><a href="index.html" title="Auto Detect IP"><span><img class="move" src="theme/ips.png" alt=""><br>Detect-IP</span></a></li>

 

The

<br>

tag should be a self closing tag

<br />

.

You could try using two <a> tags to see if both images and links work?

 

<li><span><a href="index.html" title="Auto Detect IP"><img class="move" src="theme/ips.png" alt=""></a><br /><a href="index.html" title="Auto Detect IP">Detect-IP</a></span></a></li>

 

It's not pretty, but it might work? (though I'm not sure).

 

Once last suggestion.. the empty space below the footer is white.. I would try perhaps making it the same grey colour as the grey in the footer message. It look strange having a small grey footer, then this large white space.

 

Other than that, its taking shape.

 

Cheers,

 

NRG

[lovelycesar]

Thanks. I used Opera before; and now I see that Opera has a very nice skin out. As the site's content becomes longer, the shorter white footer I have.

As of you all, I have a better-looking site now.

Finally, please receive hereby my Big Thanks!

[lovelycesar]

For <br /> :

The sequence <FOO /> can be interpreted in at least two different ways, depending on the DOCTYPE of the document. For HTML 4.01 Strict, the '/' terminates the tag <FOO (with an implied '>'). However, since many browsers don't interpret it this way, even in the presence of an HTML 4.01 Strict DOCTYPE, it is best to avoid it completely in pure HTML documents and reserve its use solely for those written in XHTML.