how to make logout link

[karq]

can someone tell me how to make a logout link?

i'm a noob and my code maybe s*it but it works for me

my page code:

<?php
session_start();
$kasutaja=$_POST["kasutaja"];
$parool=$_POST["parool"];
$ava=fopen("kasu.txt","r");
$ava2=fopen("parol.txt","r");
$kasu=fread($ava,100);
$parol=fread($ava2,100);
if (session_is_registered("ses")) {
echo "<zen href=>Logi Välja</a><br />";
echo "<center><b>Tere Tulemast " . $kasutaja . "</b>";
echo "<br /> <form action='salv.php' method='POST' >
<textarea rows='20' cols='30' name='uudis'>";
include 'uudis.txt';
echo "</textarea> <br />";
echo "<input type='submit' value='Salvesta' />";
echo "</center>";
}

else {
if ($kasutaja==$kasu && $parool==$parol) {
$_SESSION["sees"]=$kasutaja==$kasu && $parool==$parol;
session_register("ses");
echo "<center><b>Tere Tulemast " . $kasutaja . "</b>";
echo "<br /> <form action='salv.php' method='POST' >
<textarea rows='20' cols='30' name='uudis'>";
include 'uudis.txt';
echo "</textarea> <br />";
echo "<input type='submit' value='Salvesta' />";
echo "</center>";

}
else {
session_destroy();
echo "Proovi uuesti!";
}
}
?>

[DarkWater]

You don't need to use session_register or session_is_registered anymore.  It's deprecated.

[Jabop]

<?php
if ($_GET['act']=='logout') {
    $_SESSION['logged']=array();
    header("Location: /index.html");
}
?>

[DarkWater]

You probably also want session_destroy().

[Jabop]

I don't see a reason to use session_destroy() if you are just wanting to log the user out. Sometimes the remaining session vars are useful, and only logged needs to be unset.

[DarkWater]

In that case, you need to specifically know which ones you want to destroy.  And if you rework your login system, you may need to heavily rework your logout system, etc.  Kind of annoying. ._.

[Jabop]

I don't see what you're trying to get across with what you just said?

 

<?php

// user login is successful, set up the session
$_SESSION['logged']['user']=$Person;

// example of someone trying to do something that requires being logged in

if ($_SESSION['logged']) {
     // do stuff that would be permissible
     // in this case, it is, cause the login was just successful
} else {
     $Err='You need to login to do that';
}
?>

 

I know you know how that code works, I don't have to explain. I just wanted to give you some type of structure to look at to see what I'm saying. There is no reason to completely destroy a session upon logging out. Ever. You simply should set $_SESSION['logged'] back to a blank array, thus saving all of your session info that isn't pertaining to the login system.

[DarkWater]

I know, but if you decided to change an aspect of your login system, you'd need to rework your logouts too.  This is neither here nor there and it's just a preference.  Whatever. =P

[karq]

ok  I sorted that logout link thing out, but now I have another problem, why can I use that last else?

<?php
session_start();
$kasutaja=$_POST["kasutaja"];
$parool=$_POST["parool"];
$ava=fopen("kasu.txt","r");
$ava2=fopen("parol.txt","r");
$kasu=fread($ava,100);
$parol=fread($ava2,100);
if (!isset($_SESSION["sees"])) {
if ($kasutaja==$kasu && $parool==$parol) {
$_SESSION["sees"];
echo "<a href='out.php'>Logi välja</a>";
echo "<center><b>Tere Tulemast " . $kasutaja . "</b>";
echo "<br /> <form action='salv.php' method='POST' >
<textarea rows='20' cols='30' name='uudis'>";
include 'uudis.txt';
echo "</textarea> <br />";
echo "<input type='submit' value='Salvesta' />";
echo "</center>";
}
}
else {
echo "<a href='out.php'>Logi välja</a>";
echo "<center><b>Tere Tulemast " . $kasutaja . "</b>";
echo "<br /> <form action='salv.php' method='POST' >
<textarea rows='20' cols='30' name='uudis'>";
include 'uudis.txt';
echo "</textarea> <br />";
echo "<input type='submit' value='Salvesta' />";
echo "</center>";
}
else { <----- This else I mean!!!!
echo "Proovi uuesti<br />";
echo "<a href='logi.php'>Tagasi</a>";
}


?>

[DarkWater]

You tell us.  Does it throw an error or anything?

[karq]

Yes it does

 

Parse error: syntax error, unexpected T_ELSE in /sees.php on line 32

[DarkWater]

Which if did you want that else to be a part of?

[karq]

Which if did you want that else to be a part of?

 

Thanks for the hint, got it working

[DarkWater]

Yeah, I didn't want to give the answer away that easily. xD  You had } }, thereby closing both ifs. xD