Mysql Wrapper - Help

[!jazz]

Hi Guys,

 

I'm currently developing a small Mysql wrapper and I'd like to ask you for a little help.

 

How would you improve this method?:

 

<?php

    public function sendQuery($Statement=NULL, $Variables=array())
    {
      if($Statement!=NULL)
      {
        if($Variables!=NULL)
        {
          $Vars = NULL;
          if(is_array($Variables) && count($Variables)>0)
          {
            foreach($Variables as $key => $value)
            {
              $Vars .= ',\''.$this->escapeString($value).'\'';              
            }
          }
          
          $Statement = '$query = sprintf("'.$Statement.'"'.$Vars.');';
          eval($Statement);
         
          $query = mysql_query($query, $this->LinkID);
          if($query)
          {
            $this->Query = $query;
          }
          else
          {
            $this->errorSET('Query could not be executed', true);
          }
        }
        else
        {
          $query = mysql_query($Statement, $this->LinkID);
          if($query)
          {
            $this->Query = $query;
          }
          else
          {
            $this->errorSET('Query could not be executed', true);
          }
        }
        return $this->Query;
      }
      return false;
    }
?>

 

So long,

JaZz

[!jazz]

push

 

[!jazz]

push

[trq]

Theres probably a few things you could do but one thing that jumps out straight away is this loop.

 

foreach($Variables as $key => $value)
{
  $Vars .= ',\''.$this->escapeString($value).'\'';              
}

 

It would be more efficient to replace it with a call to implode.

 

$Vars = "'" . implode("','",$varaiables) . "'";

[!jazz]

Theres probably a few things you could do but one thing that jumps out straight away is this loop.

 

foreach($Variables as $key => $value)
{
  $Vars .= ',\''.$this->escapeString($value).'\'';              
}

 

It would be more efficient to replace it with a call to implode.

 

$Vars = "'" . implode("','",$varaiables) . "'";

 

Yeah thanks.

Do you or someone else got some other suggestions?

 

JaZz