Alternative coloured rows

[rcouser]

Hello I am trying to created alternative coloured rows for my database results, I had a go with the code below but the result only display with the one style. The two styles are range1 and range2.

Could someone please help and see were I've went wrong.

Thanks

<?php 
			// initialize cell counter outside loop
			$row_colour = 1;
			$rowStyle = ($row_colour % 2 == 1) ? 'range1' : 'range2';
			do { ?>
                    <div class="<?php echo "$rowStyle" ?>">
                        <div class="rangedetails">
                            <h5><?php echo $ranges['range_title']; ?></h5>
                            <p><?php echo $ranges['range_description']; ?></p>
                        </div>
                        <div class="editbutton">
                            <a href="update_range.php?range_id=<?php echo $ranges['range_id']; ?>">Edit</a>
                        </div>
                        <div class="deletebutton">
                            <a href="delete_range.php?range_id=<?php echo $ranges['range_id']; ?>">Delete</a>
                        </div>
            		</div>
			<?php
				$ranges = $result->fetch_assoc();
				$row_colour++;
				} while ($ranges);
			?>

[The Little Guy]

Example: http://phpsnips.com/snippet.php?id=52

[genericnumber1]

<?php 
			// initialize cell counter outside loop
			$row_colour = 1;
			do { 
				$rowStyle = ($row_colour % 2 == 1) ? 'range1' : 'range2';?>
                    <div class="<?php echo "$rowStyle" ?>">
                        <div class="rangedetails">
                            <h5><?php echo $ranges['range_title']; ?></h5>
                            <p><?php echo $ranges['range_description']; ?></p>
                        </div>
                        <div class="editbutton">
                            <a href="update_range.php?range_id=<?php echo $ranges['range_id']; ?>">Edit</a>
                        </div>
                        <div class="deletebutton">
                            <a href="delete_range.php?range_id=<?php echo $ranges['range_id']; ?>">Delete</a>
                        </div>
            		</div>
			<?php
				$ranges = $result->fetch_assoc();
				$row_colour++;
				} while ($ranges);
			?>

 

you needed to move the $rowStyle = line down one.

 

evil do{}while() loops.....

[rcouser]

Thanks for the help, I thought it was something simple.

Why are do{}while() loops evil 

[discomatt]

They're 'evil' cause they're the only control structure with the arguments at the bottom - forces a slightly different approach. There's nothing wrong with using them.

[genericnumber1]

they're a little more difficult to read that's the only reason I said they're evil.