Email form and attachments

[mallen]

I have this script that allows a user to email an attachment. I'm trying to check the file size and type of file. See the section I added in the middle. Keeps giving e the message "wrong file type" and won't send the email.

<?php
   if ($_SERVER['REQUEST_METHOD']=="POST"){

   // we'll begin by assigning the To address and message subject
   $to="me@you.com";

   $subject="E-mail with attachment";

   // get the sender's name and email address
   // we'll just plug them a variable to be used later
   $from = stripslashes($_POST['fromname'])."<".stripslashes($_POST['fromemail']).">";

   // generate a random string to be used as the boundary marker
   $mime_boundary="==Multipart_Boundary_x".md5(mt_rand())."x";

   // store the file information to variables for easier access
   $tmp_name = $_FILES['filename']['tmp_name'];
   $type = $_FILES['filename']['type'];
   $name = $_FILES['filename']['name'];
   $size = $_FILES['filename']['size'];

   // here we'll hard code a text message
   // again, in reality, you'll normally get this from the form submission
   $message = "Here is your file: $name";

   // if the upload succeded, the file will exist
   if (file_exists($tmp_name)){

      // check to make sure that it is an uploaded file and not a system file
      if(is_uploaded_file($tmp_name)){

         // open the file for a binary read
         $file = fopen($tmp_name,'rb');

         // read the file content into a variable
         $data = fread($file,filesize($tmp_name));

         // close the file
         fclose($file);

         // now we encode it and split it into acceptable length lines
         $data = chunk_split(base64_encode($data));
     }

      // now we'll build the message headers
      $headers = "From: $from\r\n" .
         "MIME-Version: 1.0\r\n" .
         "Content-Type: multipart/mixed;\r\n" .
         " boundary=\"{$mime_boundary}\"";

      // next, we'll build the message body
      // note that we insert two dashes in front of the
      // MIME boundary when we use it
      $message = "This is a multi-part message in MIME format.\n\n" .
         "--{$mime_boundary}\n" .
         "Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
         "Content-Transfer-Encoding: 7bit\n\n" .
         $message . "\n\n";

      // now we'll insert a boundary to indicate we're starting the attachment
      // we have to specify the content type, file name, and disposition as
      // an attachment, then add the file content and set another boundary to
      // indicate that the end of the file has been reached
      $message .= "--{$mime_boundary}\n" .
         "Content-Type: {$type};\n" .
         " name=\"{$name}\"\n" .
         //"Content-Disposition: attachment;\n" .
         //" filename=\"{$fileatt_name}\"\n" .
         "Content-Transfer-Encoding: base64\n\n" .
         $data . "\n\n" .
         "--{$mime_boundary}--\n";
//Added content here******************************************
define ("MAX_SIZE","50"); 

function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$type = substr($str,$i+1,$l);
return $ext;
}

$errors=0;
$filename = stripslashes($_FILES['image']['name']);

$type = getExtension($name);
$type = strtolower($extension);

if (($type != "jpg") && ($type != "jpeg") && ($type != "png") && ($type != "pdf") && ($type != "dwg") && ($type != "gif")) 
{
echo 'Unknown file extension! Only .gif, .jpg, .png, pdf and dwg and files are allowed to be uploaded </a>.';
$errors=1;
die ();
}

$size=filesize($_FILES['image']['tmp_name']);

if ($size > MAX_SIZE*1024)
{
echo 'You have exceeded the size limit!';
$errors=1;
die ();
}




//End Added content**********************************



      // now we just send the message
      if (@mail($to, $subject, $message, $headers))
         echo "Message Sent";
      else
         echo "Failed to send";
   }
} else {
?>
<p>Send an e-mail with an attachment:</p>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" 
   enctype="multipart/form-data" name="form1">
   <p>From name: <input type="text" name="fromname"></p>
   <p>From e-mail: <input type="text" name="fromemail"></p>
   <p>File: <input type="file" name="filename"></p>
   <p><input type="submit" name="Submit" value="Submit"></p>
</form>
<?php } ?> 

[Adam]

Does it say "wrong file type" .. or does it say .. "Unknown file extension! Only .gif, .jpg, .png, pdf and dwg and files are allowed to be uploaded" ??

 

Have you double checked the function getExtension is returning the right value?

 

Adam

[mallen]

Unknown file extension! Only .gif, .jpg, .png, pdf and dwg and files are allowed to be uploaded

 

How would I know its returning the right value?

[.josh]

by echoing it out and seeing what it's holding.

[mallen]

I put echo $type;

and tried uploading a Word doc and it returned : application/msword

[Adam]

Well just cut and paste the function into a new file and test it out, eg:

 

<?php

function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$type = substr($str,$i+1,$l);
return $ext;
}

print getExtension('testfile.jpg');

?>

 

if it works properly should return "jpg", but possibly could be returning ".jpg" ??

 

You could use something MUCH simpler like:

 

function file_extension($filename) {
   $path_info = pathinfo($filename);
   return $path_info['extension'];
}

 

 

Adam

[Adam]

Ignore first half of last post, but there's your problem...

 

Adam

[.josh]

anyways, in your function,

 

return $ext;

 

should be

 

return $type;

[mallen]

Now I have

 

define ("MAX_SIZE","50"); 

function file_extension($filename) {
    $path_info = pathinfo($filename);
    return $path_info['extension'];
}

$errors=0;
$filename = stripslashes($_FILES['image']['name']);

$type = file_extension($name);
$type = strtolower($extension);

if (($type != "jpg") && ($type != "jpeg") && ($type != "png") && ($type != "pdf") && ($type != "dwg") && ($type != "gif")) 
{
echo 'Unknown file extension! Only .gif, .jpg, .png, pdf and dwg and files are allowed to be uploaded </a>.';
$errors=1;
die ();
}

$size=filesize($_FILES['image']['tmp_name']);

if ($size > MAX_SIZE*1024)
{
echo 'You have exceeded the size limit!';
$errors=1;
die ();
}

And I still get "Unknown file extension! Only .gif, .jpg, .png, pdf and dwg and files are allowed to be uploaded ."

[Adam]

double check $filename 's what its supposed to be ..

[redarrow]

if ($size > MAX_SIZE*1024)

{

 

correct.....

  $size = $_FILES['filename']['size'];

[mallen]

double check $filename 's what its supposed to be ..

Not sure what you mean here.  ???

[.josh]

by echoing it out and seeing what it's holding.

[mallen]

by echoing it out and seeing what it's holding.

I echoed $filename and it didn't return anything. ???

[mallen]

return $path_info['extension'];

 

I don't understand this part. Where is it getting 'extension'  ?

[Adam]

The function "pathinfo" - http://uk2.php.net/pathinfo - returns an array of information about a filepath .. are you using PHP4?

[mallen]

Thanks for the reply. I am using PHP 5. Anything you can help me get this working is appreciated.

[Adam]

$filename = stripslashes($_FILES['image']['name']);

$type = getExtension($name);
$type = strtolower($extension);

 

Problem is here i think, should be:

 

$filename = stripslashes($_FILES['filename']['name']);
$type = strtolower( getExtension( $filename));

[Adam]

You're using $_FILES['image'] and $_FILES['filename'] when it should be (as it is on the form) $_FILES['filename'] ..

[mallen]

Now I get: Fatal error: Call to undefined function getExtension() in .....

[Adam]

oh yeah you changed it to:

 

function file_extension($filename) {
    $path_info = pathinfo($filename);
    return $path_info['extension'];
}

 

... so needs to be:

 

$filename = stripslashes($_FILES['filename']['name']);
$type = strtolower( file_extension( $filename));

[mallen]

Ok I am getting close. Now I have this

<?php
   if ($_SERVER['REQUEST_METHOD']=="POST"){

   // we'll begin by assigning the To address and message subject
   $to="me@you.com";

   $subject="E-mail with attachment";

   // get the sender's name and email address
   // we'll just plug them a variable to be used later
   $from = stripslashes($_POST['fromname'])."<".stripslashes($_POST['fromemail']).">";

   // generate a random string to be used as the boundary marker
   $mime_boundary="==Multipart_Boundary_x".md5(mt_rand())."x";

   // store the file information to variables for easier access
   $tmp_name = $_FILES['filename']['tmp_name'];
   $type = $_FILES['filename']['type'];
   $name = $_FILES['filename']['name'];
   $size = $_FILES['filename']['size'];

   // here we'll hard code a text message
   // again, in reality, you'll normally get this from the form submission
   $message = "Here is your file: $name";

   // if the upload succeded, the file will exist
   if (file_exists($tmp_name)){

      // check to make sure that it is an uploaded file and not a system file
      if(is_uploaded_file($tmp_name)){

         // open the file for a binary read
         $file = fopen($tmp_name,'rb');

         // read the file content into a variable
         $data = fread($file,filesize($tmp_name));

         // close the file
         fclose($file);

         // now we encode it and split it into acceptable length lines
         $data = chunk_split(base64_encode($data));
     }

      // now we'll build the message headers
      $headers = "From: $from\r\n" .
         "MIME-Version: 1.0\r\n" .
         "Content-Type: multipart/mixed;\r\n" .
         " boundary=\"{$mime_boundary}\"";

      // next, we'll build the message body
      // note that we insert two dashes in front of the
      // MIME boundary when we use it
      $message = "This is a multi-part message in MIME format.\n\n" .
         "--{$mime_boundary}\n" .
         "Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
         "Content-Transfer-Encoding: 7bit\n\n" .
         $message . "\n\n";

      // now we'll insert a boundary to indicate we're starting the attachment
      // we have to specify the content type, file name, and disposition as
      // an attachment, then add the file content and set another boundary to
      // indicate that the end of the file has been reached
      $message .= "--{$mime_boundary}\n" .
         "Content-Type: {$type};\n" .
         " name=\"{$name}\"\n" .
         //"Content-Disposition: attachment;\n" .
         //" filename=\"{$fileatt_name}\"\n" .
         "Content-Transfer-Encoding: base64\n\n" .
         $data . "\n\n" .
         "--{$mime_boundary}--\n";

define ("MAX_SIZE","50"); 

function file_extension($filename) {
    $path_info = pathinfo($filename);
    return $path_info['extension'];
}




$errors=0;
$filename = stripslashes($_FILES['filename']['name']);
$type = strtolower( file_extension( $filename));


if (($type != "jpg") && ($type != "jpeg") && ($type != "png") && ($type != "pdf") && ($type != "dwg") && ($type != "gif")) 
{

echo 'Unknown file extension. Only .gif, .jpg, .png, pdf and dwg and files are allowed to be uploaded </a>.';
echo $path_parts['extension'], "\n";
$errors=1;
die ();
}



$size=filesize($_FILES['image']['tmp_name']);

if $size = $_FILES['filename']['size'];
{
echo 'You have exceeded the size limit!';
$errors=1;
die ();
}





      // now we just send the message
      if (@mail($to, $subject, $message, $headers))
         echo "Message Sent";
      else
         echo "Failed to send";
   }
} else {
?>
<p>Send an e-mail with an attachment:</p>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" 
   enctype="multipart/form-data" name="form1">
   <p>From name: <input type="text" name="fromname"></p>
   <p>From e-mail: <input type="text" name="fromemail"></p>
   <p>File: <input type="file" name="filename"></p>
   <p><input type="submit" name="Submit" value="Submit"></p>
</form>
<?php } ?> 

And I get this error

Parse error: syntax error, unexpected T_VARIABLE, expecting '(' in .....on line 109

 

Which  is this line

if $size = $_FILES['filename']['size'];

[Adam]

if's need brackets.. if (something == something) { ... }

 

should be:

 

if ($size == $_FILES['filename']['size'])

[mallen]

Ok got it working I think. Now I need to set the file size properly. I want to set a limit of 1MB.

[Adam]

Don't understand what you're trying to do there though...

 

$size=filesize($_FILES['image']['tmp_name']);

if ($size == $_FILES['filename']['size']);

{
echo 'You have exceeded the size limit!';
echo $size;
$errors=1;
die ();
}

 

$_FILES['image'] .. isn't actually used on the form, not sure why you have lots of references to it? But you need to set a size limit yourself. with that you're basically setting the filesize limit to equal the filesize of a file i'm not even sure exists; filesize($_FILES['image']['tmp_name']) ...? should look something more like:

 

if ($_FILES['filename']['size'] >= 1048576) {
echo 'You have exceeded the size limit of 1Mb!';
echo ' Actual size: '.$_FILES['filename']['size'];
$errors=1;
die ();
}