Strange copy problem

[aximbigfan]

I have this code (Thanks Aidan Lister!)

 

function copyr($source, $dest)
{
    // Simple copy for a file
    if (is_file($source)) {
        return copy($source, $dest);
    }

    // Make destination directory
    if (!is_dir($dest)) {
        mkdir($dest);
    }
    
    // If the source is a symlink
    if (is_link($source)) {
        $link_dest = readlink($source);
        return symlink($link_dest, $dest);
    }

    // Loop through the folder
    $dir = dir($source);
    while (false !== $entry = $dir->read()) {
        // Skip pointers
        if ($entry == '.' || $entry == '..') {
            continue;
        }

        // Deep copy directories
        if ($dest !== "$source/$entry") {
            copyr("$source/$entry", "$dest/$entry");
        }
    }

    // Clean up
    $dir->close();
    return true;
}

 

Say I have this dir

/Test1/Test2/Test3/

 

Say I try to

copyr("/Test1/Test2/", "/Test1");

 

The end result is that nothing happens. No errors. Literally, nothing.

 

Anyone see any reason for this to be happening? It does NOT happen when I

copyr("/Test1/Test2", "/otherdir/");

 

Thanks,

Chris

[genericnumber1]

it copies over itself.. what would you expect it to do?

[aximbigfan]

Is there any way to fix it? Recursive/loop stuff is not my strong point..

 

Thanks,

Chris

[genericnumber1]

what did you expect it to do? it copied the dir... it replaced itself, but it still copied the dir... so it did exactly what you asked.

[aximbigfan]

It should have just copied like this:

copyr("/Test/1/2/3", "/Test/");

 

The end result being

/Test/whatever-is-in-3

 

Chris

[genericnumber1]

Ah, you want it to just copy the contents of the destination dir, whereas right now it is copying the destination dir as well as its contents... is that correct?

[aximbigfan]

No, I do want it to copy the actual dir itself too. Sorry, I messed that example up..

 

Chris

[genericnumber1]

So you want it to rename the copied directory if it already exists and copy it under a new name?

[aximbigfan]

It _should_ just copy to the same dir. IE

I have this

/1/2/3

if I copy /1/2/3 to /1, I would like the path outcome to be /1/3

 

Thanks,

Chris

[genericnumber1]

Ah, and what is it doing currently? my quick overlook of the code says it should be doing that already.

[aximbigfan]

It doesn't do anything. The dir never gets copied to the new location.

 

EDIT: It WILL copy under certain conditions. Say i want to copy /dir/dir1/dir2 to /dir1/x . That will work.

 

Thanks,

Chris