Jump to content

PHP / Mysql design: scope question


shutat

Recommended Posts

I'm not sure if this is the right place, but I have a question relating to the scope of mysql. 

 

I haven't been coding very long in php, but in my intro C classes, I was often told to keep variable scope as narrow as possible.  When I started with mysql, I created small function such as the one below.  Where ever I had the need to query, I'd rely on a function - establish a connection, query a result, and then close from within that function.  However, is this is right approach?   

 

Any feedback would be greatly appreciated.

 


function foo () {

   sql connect
   sql query
   sql close

   return results
}

 

Link to comment
https://forums.phpfreaks.com/topic/127956-php-mysql-design-scope-question/
Share on other sites

for database queries this is not the right method becuase you will have a lot of overhead if you make a new connect for each query.  The best way is to create or use an existing database abstraction layer(there a quite a few out there) and make it a singleton so you can do:

 

<?php
$database = database:get_instance();
$data = $database->get_all($query);
?>

 

and that way each script only has 1 connection.

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.