bad thumbnail quality

[lukelee]

here is the code, the quality of the thumbnail is really bad, does anyone have any tips?

 

<?php
function makethumb($srcFile,$dstFile,$dstW,$dstH) {
$data = GetImageSize($srcFile,&$info);
switch ($data[2]) {
case 1:
$im = @ImageCreateFromGIF($srcFile);
break;
case 2:
$im = @imagecreatefromjpeg($srcFile);
break;
case 3:
$im = @ImageCreateFromPNG($srcFile);
break;
}
$srcW=ImageSX($im);
$srcH=ImageSY($im);
$ni=ImageCreate($dstW,$dstH);
ImageCopyResized($ni,$im,0,0,0,0,$dstW,$dstH,$srcW,$srcH);
ImageJpeg($ni,$dstFile);
}

$file1 = $_FILES['ufile']['name'][0];
$new_name1 = "upload/" . md5(uniqid(rand(), true)) . substr($file1, strrpos($file1, "."));
$filesize1=$_FILES['ufile']['size'][0];
if($filesize1>0)
{
$simage="n".date('Y-m-d-H-i-s',time()).".jpg";//$simage为生成缩略图文件名
move_uploaded_file($_FILES['ufile']['tmp_name'][0], $new_name1);
$dst_image="upload/".$simage;
makethumb($new_name1,$dst_image,'150','150');
}

?>

[Caesar]

<?php

ImageJpeg($ni,$dstFile, $quality);

?>

 

http://us.php.net/manual/en/function.imagejpeg.php

[DarkWater]

Use imagecopyresampled() instead of imagecopyresized().

[lukelee]

thanks for help, but still doesnt work, here is my new code:

function makethumb($srcFile,$dstFile,$dstW,$dstH) {
$data = GetImageSize($srcFile,&$info);
switch ($data[2]) {
case 1:
$im = @ImageCreateFromGIF($srcFile);
break;
case 2:
$im = @imagecreatefromjpeg($srcFile);
break;
case 3:
$im = @ImageCreateFromPNG($srcFile);
break;
}
$srcW=ImageSX($im);
$srcH=ImageSY($im);
$ni=ImageCreate($dstW,$dstH);

Imagecopyresampled($ni,$im,0,0,0,0,$dstW,$dstH,$srcW,$srcH);
ImageJpeg($ni,$dstFile, 80);

[Caesar]

Try using 1-9 (1 through 9) when setting the image quality. It's been a while since I had to use image functions but if I remember, this is different when using ImageCopyResampled() (Which let's you set quality by %).