[SOLVED] Cannot INSERT data

[ShaolinF]

Hi Guys

 

I am trying to insert some data into the database but its not working. The db connects and everything and I receive no errors. See code below:

 

$id = $_POST['id'];

$name = $_POST['name'];

 

//Connect to DB

connect();

$insert = mysql_query("INSERT INTO petition values('','".$id."','".$name.")");

 

function connect() {

$link = mysql_connect('localhost', 'petitUsr', '12345678a');

if (!$link) {

die('Could not connect to database: ' . mysql_error());

}

$selected = mysql_select_db('petition',$link) or die(mysql_error());

}

 

 

Anyone know what Im doing wrong?

 

[DeanWhitehouse]

add or die

[Mchl]

add or die

 

Lol... Read it aloud and listen how it sounds. Better yet shout it out: ADD OR DIE!!!

 

Heh... anyway...

What Blade meant was

add

or die(mysql_error()); 

after your query

 

$insert = mysql_query("INSERT INTO petition values('','".$id."','".$name.")") or die(mysql_error());

[ShaolinF]

add or die

Thanks, I fixed it now was an error in syntax. Another question, how do I protect from SQL injection?

[DeanWhitehouse]

Lol, better not shout it out then

[DeanWhitehouse]

mysql_real_escape_string is the best and most common way and is good to use in conjunction with other security

[Mchl]

Another question, how do I protect from SQL injection?

 

Here's a good read

 

http://www.webappsec.org/projects/articles/091007.shtml