PHP no longer registering my variables

[adamjones]

Hi.

I set up a CMS quite a while back, and it was all working fine, until about a week ago, when it just suddenly stopped echoing things, like usernames, last logins, etc..

 

I think it's just no longer registering the username, etc... But I haven't a clue why.

 

Can anyone find out the problem?

 

(This is the forum where username and password are posted to):

 

<?php
<?php
ob_start();
$host="localhost";
$username="domainey_x";
$password="pass";
$db_name="domainey_x"; 
$tbl_name="members";

mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword'];

$myusername = stripslashes($myusername);
$mypassword = stripslashes($mypassword);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
$data=mysql_fetch_array($result);
$access= $data['access'];
$id= $data['id'];
$name= $data['name'];
$email= $data['email'];
$number= $data['number'];

$count=mysql_num_rows($result);

if($count==1){
session_register("myusername");
session_register("access");
session_register("mypassword"); 
session_register("name"); 
session_register("email"); 
session_register("number"); 
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$lastlogin = $data['lastlogin']; 
session_register("lastlogin");
$DB_Query = @mysql_query("UPDATE `members` SET lastlogin=Now() WHERE username='$myusername'") OR die('MySQL error: '.mysql_error());
header("location:admin.php");
}
else {
echo "Silly PHP.
";
}

ob_end_flush();
?>

 

It logs in, etc, just doesn't register anything!

Cheers!

[tommyda]

try removing one of the <?php tags from the start.

[gevans]

session_register("myusername");

session_register("access");

session_register("mypassword");

session_register("name");

session_register("email");

session_register("number");

 

deprecated as of php 5.3

 

use

 

$_SESSION['myusername'] = $myusername;

[PFMaBiSmAd]

session_register (and the two other related functions) were disabled in php4.2 in the year 2002 when register_globals were turned off and have been completely removed in php6.

[gevans]

I stand corrected, I was going off the top of my head

 

I'd say your servers have just been updated

[adamjones]

Right.. :s

 

So, I need to like, re-learn all of PHP?

[Mchl]

Right.. :s

 

So, I need to like, re-learn all of PHP?

 

Nope. Just the changes

 

[gevans]

Right.. :s

 

So, I need to like, re-learn all of PHP?

 

Haha, session register being deprecated is hardly all of php

[adamjones]

Right.. :s

 

So, I need to like, re-learn all of PHP?

 

Haha, session register being deprecated is hardly all of php

 

Lol! I suppose not, but I'm just confused as to what I need to change?

[Mchl]

Check this out

 

This is "why"

http://www.zend.com/topics/White-paper-PHP4-PHP5.pdf

 

This is "what"

http://www.php.net/manual/en/migration5.php

[gevans]

session_register("myusername");

session_register("access");

session_register("mypassword");

session_register("name");

session_register("email");

session_register("number");

 

deprecated as of php 5.3

 

use

 

$_SESSION['myusername'] = $myusername;

[adamjones]

Ok.

 

I changed it to;

 

$_SESSION['myusername'] = $myusername;

$_SESSION['access'] = $access;

$_SESSION['mypassword'] = $mypassword;

$_SESSION['name'] = $name;

$_SESSION['email'] = $email;

$_SESSION['number'] = $number;

 

But it's still not registering them?

 

 

[Mchl]

I guess adding session_start before those, would help.

[adamjones]

I guess adding session_start before those, would help.

 

Well, I changed the code to this;

 

<?php
ob_start();
$host="localhost";
$username="domainey_x";
$password="pass";
$db_name="domainey_x"; 
$tbl_name="members";

mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword'];

$myusername = stripslashes($myusername);
$mypassword = stripslashes($mypassword);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
$data=mysql_fetch_array($result);
$access= $data['access'];
$id= $data['id'];
$name= $data['name'];
$email= $data['email'];
$number= $data['number'];

$count=mysql_num_rows($result);

if($count==1){
session_start();
$_SESSION['myusername'] = $myusername;
$_SESSION['access'] = $access;
$_SESSION['mypassword'] = $mypassword;
$_SESSION['name'] = $name;
$_SESSION['email'] = $email; 
$_SESSION['number'] = $number;
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$lastlogin = $data['lastlogin']; 
session_register("lastlogin");
$DB_Query = @mysql_query("UPDATE `members` SET lastlogin=Now() WHERE username='$myusername'") OR die('MySQL error: '.mysql_error());
header("location:admin.php");
}
else {
echo "silly PHP
";
}

ob_end_flush();
?>

 

But it's still not registering.

[Mchl]

One more left

session_register("lastlogin");

[adamjones]

One more left

session_register("lastlogin");

 

Thanks, but still not registering anything;

 

<?php
ob_start();
$host="localhost";
$username="domainey_x";
$password="pass";
$db_name="domainey_x"; 
$tbl_name="members";

mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword'];

$myusername = stripslashes($myusername);
$mypassword = stripslashes($mypassword);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
$data=mysql_fetch_array($result);
$access= $data['access'];
$id= $data['id'];
$name= $data['name'];
$email= $data['email'];
$number= $data['number'];

$count=mysql_num_rows($result);

if($count==1){
session_start();
$_SESSION['myusername'] = $myusername;
$_SESSION['access'] = $access;
$_SESSION['mypassword'] = $mypassword;
$_SESSION['name'] = $name;
$_SESSION['email'] = $email; 
$_SESSION['number'] = $number;
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$_SESSION['lastlogin'] = $lastlogin;
$DB_Query = @mysql_query("UPDATE `members` SET lastlogin=Now() WHERE username='$myusername'") OR die('MySQL error: '.mysql_error());
header("location:admin.php");
}
else {
echo "silly PHP
";
}

ob_end_flush();
?>

[Mchl]

Now we should probably check the code that uses those session variables.

 

But before that, let's make sure, that they actually go to session

 

var_dump($_SESSION);