[SOLVED] Insert INTO

[mike12255]

I got an image upload script, and when somone uploads an image, i want it to save the name + extension in the databse (along with an auto increomenting id)

 

I have my database already and my script is as follows:

 

<?php

include "connect.php";
//define a maxim size for the uploaded images in Kb
define ("MAX_SIZE","100"); 

//This function reads the extension of the file. It is used to determine if the file  is an image by checking the extension.
function getExtension($str) {
         $i = strrpos($str,".");
         if (!$i) { return ""; }
         $l = strlen($str) - $i;
         $ext = substr($str,$i+1,$l);
         return $ext;
}

//This variable is used as a flag. The value is initialized with 0 (meaning no error  found)  
//and it will be changed to 1 if an errro occures.  
//If the error occures the file will not be uploaded.
$errors=0;
//checks if the form has been submitted
if(isset($_POST['Submit'])) 
{
	//reads the name of the file the user submitted for uploading
	$image=$_FILES['image']['name'];
	//if it is not empty
	if ($image) 
	{
	//get the original name of the file from the clients machine
		$filename = stripslashes($_FILES['image']['name']);
	//get the extension of the file in a lower case format
  		$extension = getExtension($filename);
		$extension = strtolower($extension);
	//if it is not a known extension, we will suppose it is an error and will not  upload the file,  
//otherwise we will do more tests
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif")) 
		{
	//print error message
			echo '<h1>Unknown extension!</h1>';
			$errors=1;
		}
		else
		{
//get the size of the image in bytes
//$_FILES['image']['tmp_name'] is the temporary filename of the file
//in which the uploaded file was stored on the server
$size=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="uploads/".$image_name;
//we verify if the image has been uploaded, and print error instead
$copied = copy($_FILES['image']['tmp_name'], $newname);
if (!$copied) 
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}}}}

//If no errors registred, print the success message
if(isset($_POST['Submit']) && !$errors) 
{
	echo "<h1>File Uploaded Successfully! Try again!</h1>";
$insert ="INSERT INTO `phpbb_files`(`shortname` ) VALUES (`$image_name`)";


mysql_query($insert) or die(mysql_error());

}

?>

<!--next comes the form, you must set the enctype to "multipart/frm-data" and use an input type "file" -->
<form name="newad" method="post" enctype="multipart/form-data"  action="">
<table>
	<tr><td><input type="file" name="image"></td></tr>
	<tr><td><input name="Submit" type="submit" value="Upload image"></td></tr>
</table>	
</form>

 

 

Im getting the following error after clicking upload:

 

Unknown column '1233030072.gif' in 'field list'

 

i think its somewhere around this code thats causing the troubles:

 

<?php
if(isset($_POST['Submit']) && !$errors) 
{
	echo "<h1>File Uploaded Successfully! Try again!</h1>";
$insert ="INSERT INTO `phpbb_files`(`shortname` ) VALUES (`$image_name`)";


mysql_query($insert) or die(mysql_error());

}

?>

[.josh]

are you sure you're running the right script?  There's no way that insert could generate that error message.

[cooldude832]

echo out $insert somewhere to see what it says

[haku]

Dude, it's not $insert (or at least not right there). That code cannot produce that error. The error is somewhere else.

[mike12255]

i dont even know what the error means

 

 

@Crayon Violent yes im sure im running that script

[haku]

You need to post more of your code then, because the error that is being shown isn't coming from the code you posted.

 

That means that your SQL query is trying to add data to a column in your database called 1233030072.gif, which of course doesn't exist. You want to add 1233030072.gif to a column probably called 'image_name' or something like that.

 

So you will have query that says something like

 

'INSERT INTO phpbbfiles ($image_name) VALUES....

 

You will be using a variable in the first set of brackets, and that variable is wrong. Look for something like that.

[mike12255]

inside the () is the field name inside the table were i want the data inserted. Thats wrong?

 

And the entire script is posted. Its the first bit of code i posted.

[.josh]

I still think you are running the wrong script.  Maybe you uploaded it to the wrong location.  Maybe you forgot to upload the update. I don't know.  But there's no way you can get that error from the query.

[mike12255]

i just re-uploaded it. and tested it again. The same error so i know its the right script. Anyway i got to get to bed i got an exam in 8 hrs. Ill check this thread in the morning

 

[uniflare]

Yes, that code can produce the error and is.

 

MySQL requires data strings to be enclosed in single quotes " ' ", not tilde quotes " ` ", only column names are enclosed in tilde and so it thinks your passing a column name.

[uniflare]

in other words:

 

$insert ="INSERT INTO `phpbb_files`(`shortname` ) VALUES (`$image_name`)";

 

should be:

 

$insert ="INSERT INTO `phpbb_files`(`shortname` ) VALUES ('$image_name')";

[mike12255]

yeah i know i fixed it already - thanks to your previous message. Thanks alot!