[SOLVED] Making a function

[Luodeni]

hey everyone, I ve kind of a newby question. I first had this piece of code

 

<?php


if ( empty( $_POST['firstname'] )
{
    $message .= "error";
}



if ($message != "")
{
echo "<div style='color: #D00;'>" . $message . "</div><br />\n";
}
elseif ( empty( $message) )
{
echo "correct <br />";
}

?>

 

then I changed it to

 

<?php


function isNullOrEmpty( $valueToCheck )
{
if ( empty( $valueToCheck ) )
             {
	$message .= "You have to fill the contact's " . $valueToCheck . "! <br />";
}
else 
{
	$message = "";
}
return $message;
}



isNullOrEmpty( $_POST['firstname'] );



if ($message != "")
{
echo "<div style='color: #D00;'>" . $message . "</div><br />\n";
}
elseif ( empty( $message) )
{
echo "correct <br />";
}
?>

 

but now it always says my code is correct even when the field is empty. Does anyone knows what I am doing wrong with my function?  many thanks in advance

[kenrbnsn]

You have to assign the value returned by the function so you can use it.

<?php


function isNullOrEmpty( $valueToCheck )
{
if ( empty( $valueToCheck ) )
             {
	$message .= "You have to fill the contact's " . $valueToCheck . "! <br />";
}
else 
{
	$message = "";
}
return $message;
}



$message = isNullOrEmpty( $_POST['firstname'] );



if ($message != "")
{
echo "<div style='color: #D00;'>" . $message . "</div><br />\n";
}
elseif ( empty( $message) )
{
echo "correct <br />";
}
?>

 

Ken

[Luodeni]

ah such a small little mistake but it's working now.

 

thanks.